html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/527#issuecomment-137871954,https://api.github.com/repos/pydata/xarray/issues/527,137871954,MDEyOklzc3VlQ29tbWVudDEzNzg3MTk1NA==,1217238,2015-09-04T22:35:11Z,2015-09-04T22:35:11Z,MEMBER,"I haven't been very careful about insisting on a clean git history so far, so don't worry about rebase/squash.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-137870866,https://api.github.com/repos/pydata/xarray/issues/527,137870866,MDEyOklzc3VlQ29tbWVudDEzNzg3MDg2Ng==,5356122,2015-09-04T22:25:25Z,2015-09-04T22:25:25Z,MEMBER,"Ok, going to merge once the build passes. Will continue with the rest of the stuff next week. @shoyer should I rebase or squash these commits?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-137869341,https://api.github.com/repos/pydata/xarray/issues/527,137869341,MDEyOklzc3VlQ29tbWVudDEzNzg2OTM0MQ==,1217238,2015-09-04T22:19:10Z,2015-09-04T22:19:10Z,MEMBER,"I think this is pretty much good to go. Merge at your discretion!
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-137835422,https://api.github.com/repos/pydata/xarray/issues/527,137835422,MDEyOklzc3VlQ29tbWVudDEzNzgzNTQyMg==,5356122,2015-09-04T19:37:08Z,2015-09-04T19:37:08Z,MEMBER,"@shoyer Latest commit also added a little more to the docs on how to use the attributes `data` `axes`, and `name_dicts`.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-137811989,https://api.github.com/repos/pydata/xarray/issues/527,137811989,MDEyOklzc3VlQ29tbWVudDEzNzgxMTk4OQ==,1217238,2015-09-04T18:22:48Z,2015-09-04T18:22:48Z,MEMBER,"For the simple example in the doc -- use imshow instead of contourf? The result is definitely more aesthetically pleasing:
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-137598575,https://api.github.com/repos/pydata/xarray/issues/527,137598575,MDEyOklzc3VlQ29tbWVudDEzNzU5ODU3NQ==,1217238,2015-09-03T23:13:01Z,2015-09-03T23:13:01Z,MEMBER,"see https://github.com/clarkfitzg/xray/pull/1
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-137588842,https://api.github.com/repos/pydata/xarray/issues/527,137588842,MDEyOklzc3VlQ29tbWVudDEzNzU4ODg0Mg==,5356122,2015-09-03T22:15:47Z,2015-09-03T22:15:47Z,MEMBER,"By the way, I believe this is to a point where we could easily tune any of the aesthetics- say shrinking the width of the colorbar or using a different number of ticks / sizes on the labels.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-137587792,https://api.github.com/repos/pydata/xarray/issues/527,137587792,MDEyOklzc3VlQ29tbWVudDEzNzU4Nzc5Mg==,5356122,2015-09-03T22:09:32Z,2015-09-03T22:09:32Z,MEMBER,"Here's what's left to do:
- [ ] convenience method `darray.plot(row='z')`
- [ ] map example using matplotlib quiver plot
- [ ] port any more methods / features from Seaborn FacetGrid
@shoyer, am I forgetting anything?
Ready for this PR to be reviewed now. I can finish the rest in a follow up PR.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-131240388,https://api.github.com/repos/pydata/xarray/issues/527,131240388,MDEyOklzc3VlQ29tbWVudDEzMTI0MDM4OA==,5356122,2015-08-14T21:13:12Z,2015-09-03T21:57:53Z,MEMBER,"For this PR:
- [x] facet on rows and columns
- [x] Align label on colorbar
- [x] Label figure axes
- [x] Use xray plotting logic to make nice colorbar
- [x] Make and test choices around colorbar
EDIT - going to revisit `plt.contour(color='k')` after #537 gets worked out.
- [x] separate iteration over data from plotting - edge case: require the index to actually be unique `.is_unique`.
- [x] Use core string formatting for titles
- [x] tests for all of above
- [x] test `col_wrap`
- [x] write and organize docs
- [x] docs for public attribute- axes and such
On this PR or possibly a different one:
- [ ] Convenience method to easily make faceted plots- something like `darray.plot(col='time')`
- [x] port Seaborn's aspect capabilities
- [ ] matplotlib quiver plot for map example
- [x] Create new `xray.tutorial` module with function like `load_example_dataset` for plotting examples
Different PR:
- [ ] Facets and maps
- [ ] Inline documentation and plots for API reference
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-137490299,https://api.github.com/repos/pydata/xarray/issues/527,137490299,MDEyOklzc3VlQ29tbWVudDEzNzQ5MDI5OQ==,5356122,2015-09-03T15:45:49Z,2015-09-03T15:45:49Z,MEMBER,"@shoyer multiple labels on x / y axes compared to the one above.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-137282470,https://api.github.com/repos/pydata/xarray/issues/527,137282470,MDEyOklzc3VlQ29tbWVudDEzNzI4MjQ3MA==,1217238,2015-09-03T00:36:16Z,2015-09-03T00:36:16Z,MEMBER,"@clarkfitzg was that second plot supposed to be different?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-137274951,https://api.github.com/repos/pydata/xarray/issues/527,137274951,MDEyOklzc3VlQ29tbWVudDEzNzI3NDk1MQ==,5356122,2015-09-02T23:45:56Z,2015-09-02T23:45:56Z,MEMBER,"Starting to agree with @shoyer and Seaborn on the multiple labels:
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-137273992,https://api.github.com/repos/pydata/xarray/issues/527,137273992,MDEyOklzc3VlQ29tbWVudDEzNzI3Mzk5Mg==,5356122,2015-09-02T23:37:56Z,2015-09-02T23:37:56Z,MEMBER,"Getting better...
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-137263395,https://api.github.com/repos/pydata/xarray/issues/527,137263395,MDEyOklzc3VlQ29tbWVudDEzNzI2MzM5NQ==,5356122,2015-09-02T22:30:03Z,2015-09-02T22:30:03Z,MEMBER,"Thanks for the encouragement @jhamman - I'll take what I can get! Seem to be finding a way around it by setting custom `ax.xaxis.set_major_locator`
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-137257894,https://api.github.com/repos/pydata/xarray/issues/527,137257894,MDEyOklzc3VlQ29tbWVudDEzNzI1Nzg5NA==,2443309,2015-09-02T21:58:50Z,2015-09-02T21:58:50Z,MEMBER,"The colorbar looks great though :wink:
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-137254992,https://api.github.com/repos/pydata/xarray/issues/527,137254992,MDEyOklzc3VlQ29tbWVudDEzNzI1NDk5Mg==,5356122,2015-09-02T21:52:22Z,2015-09-02T21:52:22Z,MEMBER,"Aaaaaaahhh!!
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-137237428,https://api.github.com/repos/pydata/xarray/issues/527,137237428,MDEyOklzc3VlQ29tbWVudDEzNzIzNzQyOA==,5356122,2015-09-02T20:37:51Z,2015-09-02T20:37:51Z,MEMBER,"Issues seem to be mostly caused by the colorbar.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-136885470,https://api.github.com/repos/pydata/xarray/issues/527,136885470,MDEyOklzc3VlQ29tbWVudDEzNjg4NTQ3MA==,5356122,2015-09-01T22:54:31Z,2015-09-01T22:54:31Z,MEMBER,"I believe it's possible to fix automatically. Somehow. Will look into it further tomorrow.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-136881281,https://api.github.com/repos/pydata/xarray/issues/527,136881281,MDEyOklzc3VlQ29tbWVudDEzNjg4MTI4MQ==,1217238,2015-09-01T22:27:25Z,2015-09-01T22:27:25Z,MEMBER,"@clarkfitzg Is that something that can fixed simply by adjusting the `size` argument? Does matplotlib use figure size when determining tick labels? I'm not sure there's much we can do to fix this automatically.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-136880349,https://api.github.com/repos/pydata/xarray/issues/527,136880349,MDEyOklzc3VlQ29tbWVudDEzNjg4MDM0OQ==,5356122,2015-09-01T22:22:35Z,2015-09-01T22:22:45Z,MEMBER,"For reference, here's what is happening once aspect is adjusted. x axes are all crowded.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-136878263,https://api.github.com/repos/pydata/xarray/issues/527,136878263,MDEyOklzc3VlQ29tbWVudDEzNjg3ODI2Mw==,5356122,2015-09-01T22:09:49Z,2015-09-01T22:09:49Z,MEMBER,"Some issues cropping up with using `plt.tight_layout` when manipulating the aspect and size.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-136527660,https://api.github.com/repos/pydata/xarray/issues/527,136527660,MDEyOklzc3VlQ29tbWVudDEzNjUyNzY2MA==,5356122,2015-08-31T23:34:11Z,2015-09-01T22:02:34Z,MEMBER,"take aspects and figure sizes from seaborn
Done
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-136525214,https://api.github.com/repos/pydata/xarray/issues/527,136525214,MDEyOklzc3VlQ29tbWVudDEzNjUyNTIxNA==,5356122,2015-08-31T23:15:30Z,2015-09-01T21:35:12Z,MEMBER,"add ability to set `margin_titles=True`.
TODO- don't really understand the use case for this.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-136849815,https://api.github.com/repos/pydata/xarray/issues/527,136849815,MDEyOklzc3VlQ29tbWVudDEzNjg0OTgxNQ==,5356122,2015-09-01T20:20:49Z,2015-09-01T20:20:49Z,MEMBER,"yep, could definitely do that. I'm still not crazy about repeating the x, y labels like that. Let me see if I can come up with a nice alternative using text on the figure.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-136848233,https://api.github.com/repos/pydata/xarray/issues/527,136848233,MDEyOklzc3VlQ29tbWVudDEzNjg0ODIzMw==,1217238,2015-09-01T20:17:24Z,2015-09-01T20:17:53Z,MEMBER,"Skipping the missing block looks pretty nice to me!
I'm pretty happy with the aesthetics, though there's a case for copying the behavior from Seaborn, e.g.,
``` python
attend = sns.load_dataset(""attention"").query('subject < 6')
g = sns.FacetGrid(attend, col=""subject"", col_wrap=3,
size=2, ylim=(0, 10), aspect=0.8)
g = g.map(plt.plot, ""solutions"", ""score"")
```
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-136847156,https://api.github.com/repos/pydata/xarray/issues/527,136847156,MDEyOklzc3VlQ29tbWVudDEzNjg0NzE1Ng==,5356122,2015-09-01T20:15:05Z,2015-09-01T20:15:05Z,MEMBER,"Here's what we have now with one missing block.
Not sure about these aesthetics.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-136523447,https://api.github.com/repos/pydata/xarray/issues/527,136523447,MDEyOklzc3VlQ29tbWVudDEzNjUyMzQ0Nw==,5356122,2015-08-31T23:03:43Z,2015-09-01T17:53:25Z,MEMBER,"todo- make sure to seed random number generator or else use deterministic
Done
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-136524437,https://api.github.com/repos/pydata/xarray/issues/527,136524437,MDEyOklzc3VlQ29tbWVudDEzNjUyNDQzNw==,5356122,2015-08-31T23:10:18Z,2015-08-31T23:10:18Z,MEMBER,"add matplotlib quiver plot for `map` example.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-135912898,https://api.github.com/repos/pydata/xarray/issues/527,135912898,MDEyOklzc3VlQ29tbWVudDEzNTkxMjg5OA==,5356122,2015-08-28T23:29:27Z,2015-08-28T23:29:27Z,MEMBER,"Here's where the progress stands:
```
g = xray.plot.FacetGrid(t5, col='time', col_wrap=2)
g.map_dataarray(xray.plot.contour, color='k')
```
Looks like the column wrapping does the right thing by leaving the last axes blank.
Observe #537 is still an issue here. We'll have to make sure that when that is fixed it also works for these facets.
On Monday morning I can clean the code up, take out the seaborn chunks, reorganize the docs, and then I'll be ready to ask for a review.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-131173521,https://api.github.com/repos/pydata/xarray/issues/527,131173521,MDEyOklzc3VlQ29tbWVudDEzMTE3MzUyMQ==,5356122,2015-08-14T16:37:28Z,2015-08-14T16:37:28Z,MEMBER,"Thanks! The colorbar label spacing is a matplotlib thing- it only became a problem after rotating it to match the row labels. So I expect that I can fix it by changing the anchor point or placing it manually.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-130967264,https://api.github.com/repos/pydata/xarray/issues/527,130967264,MDEyOklzc3VlQ29tbWVudDEzMDk2NzI2NA==,2443309,2015-08-14T05:10:45Z,2015-08-14T05:10:45Z,MEMBER,"@clarkfitzg - These are looking really great. I think this is going to be a really useful tool.
The colorbar label is too close to the colorbar tick label, are we manually placing that or is this a matplotlib thing?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-130903866,https://api.github.com/repos/pydata/xarray/issues/527,130903866,MDEyOklzc3VlQ29tbWVudDEzMDkwMzg2Ng==,5356122,2015-08-14T00:47:54Z,2015-08-14T00:47:54Z,MEMBER,"Here's what a 4d array looks like.
```
In [26]: t4d = xray.concat([t2, t2 + 50], pd.Index(['normal', 'hot'], name='fourth_dim'))
# This is a 4d array
In [27]: t4d.coords
Out[27]:
Coordinates:
* lat (lat) float32 75.0 72.5 70.0 67.5 65.0 62.5 60.0 57.5 55.0 ...
* lon (lon) float32 200.0 202.5 205.0 207.5 210.0 212.5 215.0 ...
* time (time) datetime64[ns] 2013-01-01 2013-03-04T12:00:00
* fourth_dim (fourth_dim) object 'normal' 'hot'
In [28]: g = xray.plot.FacetGrid(t4d, col='time', row='fourth_dim')
In [29]: g.map_dataarray(xray.plot.imshow, 'lon', 'lat')
Out[29]:
```
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364
https://github.com/pydata/xarray/pull/527#issuecomment-130766241,https://api.github.com/repos/pydata/xarray/issues/527,130766241,MDEyOklzc3VlQ29tbWVudDEzMDc2NjI0MQ==,5356122,2015-08-13T17:17:05Z,2015-08-13T17:17:05Z,MEMBER,"@shoyer Here's what we currently have:
```
In [15]: g = xray.plot.FacetGrid(t, col='time', col_wrap=2)
In [16]: g.map_dataarray(xray.plot.contourf, 'lon', 'lat')
Out[16]:
```
Right now this assumes that the function for map_dataarray has the same signature as 2d xray plotting methods.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,100646364