html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3550#issuecomment-555923345,https://api.github.com/repos/pydata/xarray/issues/3550,555923345,MDEyOklzc3VlQ29tbWVudDU1NTkyMzM0NQ==,24736507,2019-11-20T09:41:02Z,2019-11-25T20:47:29Z,NONE,"Hello @r-beer! Thanks for updating this PR. We checked the lines you've touched for [PEP 8](https://www.python.org/dev/peps/pep-0008) issues, and found:
* In the file [`xarray/tests/test_computation.py`](https://github.com/pydata/xarray/blob/4ab4af44bc0835aa4918fdd9dae16e852b3a7962/xarray/tests/test_computation.py):
> [Line 817:1](https://github.com/pydata/xarray/blob/4ab4af44bc0835aa4918fdd9dae16e852b3a7962/xarray/tests/test_computation.py#L817): [E302](https://duckduckgo.com/?q=pep8%20E302) expected 2 blank lines, found 1
##### Comment last updated at 2019-11-25 20:47:29 UTC","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-557895005,https://api.github.com/repos/pydata/xarray/issues/3550,557895005,MDEyOklzc3VlQ29tbWVudDU1Nzg5NTAwNQ==,45787861,2019-11-24T14:41:44Z,2019-11-24T14:41:44Z,NONE,"I have added several test cases, almost all pass. The ones that don't pass are related to `dim=""time""` and incompletely implemented `pandas_cov` and `pandas_corr`, that currently don't have a `dim` parameter.
I had a look at `np.cov`, `np.corrcoef`, `pd.Series.cov`, `pd.frame.cov`, `pd.Series.corr`, and `pd.frame.corr`: Computation of `cov` and `corr` is implemented in many different ways.
`xr.cov` and `xr.corr` now imitate the behavior of the respective `pd.Series` functions.
I actually prefer the numpy behavior, resulting in covariance and correlation matrices. However I feel that efficient implementation of this behavior is above my current understanding of xarray. So, I would highly appreciate your support on this implementation!
Otherwise, I added the `ddof` parameter to `xr.cov` to imitate the behavior of the respective `pd.Series` functions. I now get the results that `pd.Series` produces. However, I had to set `ddof=1` for `xr.cov` and `ddof=0` for `xr.corr`. Does that make sense?","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-557874527,https://api.github.com/repos/pydata/xarray/issues/3550,557874527,MDEyOklzc3VlQ29tbWVudDU1Nzg3NDUyNw==,45787861,2019-11-24T10:11:31Z,2019-11-24T10:15:19Z,NONE,"> For `xarray.corr(array, array, dim='y')`, I think we'd expect an array of the same dimensionality as below, with one point as the correlation of 1.0 (because `{1,2}` is 100% correlated to `{1,2}`) and another `NaN`. Does that make sense?
On the one side, I am with you in terms of ""What You Put In Is What You Get Out"", on the other hand `pandas.Series.cov` and `np.cov` have other behaviors that both seem plausible:
So for the moment, we might stick with `pandas.Series.cov`?
Or (future PR?) we rather want the `np.cov` behavior, this would require more effort and the `repr` should probably be given as `xarray` instead of `np.array`, right? ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-557872510,https://api.github.com/repos/pydata/xarray/issues/3550,557872510,MDEyOklzc3VlQ29tbWVudDU1Nzg3MjUxMA==,45787861,2019-11-24T09:39:30Z,2019-11-24T09:39:30Z,NONE,"> I would start with having the code in the function; i.e. don't abstract too early unless we're really confident on the eventual state. When we find ourselves something multiple times, then we can start pulling it out into more abstractions (e.g. fixtures).
Alright! I found myself having very similar tests and therefore abstracted it to test_func. I completely agree with not abstracting too early and but when having the same structure several times.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-557829302,https://api.github.com/repos/pydata/xarray/issues/3550,557829302,MDEyOklzc3VlQ29tbWVudDU1NzgyOTMwMg==,45787861,2019-11-23T20:13:45Z,2019-11-23T20:13:45Z,NONE,"> Either way, it would be good to have a clear list of `da_a` and `da_b` and respective `expected` results. I am a bit confused about what we actually would expect for `xarray.DataArray([[1, 2], [np.nan, np.nan]], dims=['x', 'y'])`.
Maybe, as a first step some type checking would be enough, to identify such special cases as the one above and give a `ValueError` or `NotImplementedError`?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-557828920,https://api.github.com/repos/pydata/xarray/issues/3550,557828920,MDEyOklzc3VlQ29tbWVudDU1NzgyODkyMA==,45787861,2019-11-23T20:07:56Z,2019-11-23T20:08:11Z,NONE,">
>
> @shoyer good spot, thanks
>
> @r-beer we could add that as a test case
Yes, I will add it.
Thinking about test arrays in general:
Wouldn't it be good to define some data array fixtures in the `conftest.py` which can then be used in all different `test_function.py` tests?
In view of the additional test I started to restructure the `test_cov` and `test_corr` to a single `test_func`. I am now asking myself how much of the data preprocessing shall go to the parametrization and how much remains in the test function...
Any guidelines or suggestions?
Either way, it would be good to have a clear list of `da_a` and `da_b` and respective `expected` results. I am a bit confused about what we actually would expect for `xarray.DataArray([[1, 2], [np.nan, np.nan]], dims=['x', 'y'])`.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-557812486,https://api.github.com/repos/pydata/xarray/issues/3550,557812486,MDEyOklzc3VlQ29tbWVudDU1NzgxMjQ4Ng==,45787861,2019-11-23T16:33:58Z,2019-11-23T16:34:39Z,NONE,"Turns out the `assert np.allclose` statements actually failed for `cov`, but not for `corr`:
```bash
actual = xr.cov(ts1, ts2)
> assert np.allclose(expected, actual)
E assert False
E + where False = (0.004632253406505826, \narray(0.004323))
E + where = np.allclose
```
0.00463 vs. 0.00432","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-557790321,https://api.github.com/repos/pydata/xarray/issues/3550,557790321,MDEyOklzc3VlQ29tbWVudDU1Nzc5MDMyMQ==,45787861,2019-11-23T11:34:12Z,2019-11-23T11:34:12Z,NONE,">
>
> PS: I personally would like to use cov and corr also with dask. Does it also make sense to put this in a future PR, together with the above-mentioned other improvements?
>
> Further PRs:
>
> * Add `dot`, `cov` and `corr` to `computation.rst`
> > PS: It looks like `xr.dot` is only present in the ""API reference"" and not in https://xarray.pydata.org/en/stable/computation.html. We should add `dot`, `cov` and `corr` to `computation.rst` in a future PR.
>
> * Test (and if necessary implement) `dask` compatibility to `cov` and `corr`
>
> * Improve documentation on `How to contribute to the xarray documentation?`
> > I think it already gives a good overview, but then it might be unclear how to proceed.
> > Maybe it might make sense to add a subsection `How to contribute to the xarray documentation?` in which the different options are shortly described examplary:
> > ```
> > 1. change docstring, e.g. ....
> > 2. update api.rst, e.g. ....
> > 3. update whats-new.rst, e.g. ...
> > ```
> >
> >
> > Then, underline that building the documentation locally is optional:
> > ```
> > Optionally, you can build the docs locally as described in the next section.
> > ```
Further PRs:
- Add dot, cov and corr to computation.rst
PS: It looks like xr.dot is only present in the ""API reference"" and not in https://xarray.pydata.org/en/stable/computation.html. We should add dot, cov and corr to computation.rst in a future PR.
- Test (and if necessary implement) dask compatibility to cov and corr
- Improve documentation on How to contribute to the xarray documentation?
I think it already gives a good overview, but then it might be unclear how to proceed.
Maybe it might make sense to add a subsection How to contribute to the xarray documentation? in which the different options are shortly described examplary:
1. change docstring, e.g. ....
2. update api.rst, e.g. ....
3. update whats-new.rst, e.g. ...
Then, underline that building the documentation locally is optional:
Optionally, you can build the docs locally as described in the next section.
- Extend xarray functionality, such that pairwise correlations and covariances can be easily calculated.
Either write a wrapper function or extend xr.corr and xr.cov, such that the following computation is supported with ease:
```python
pairwise_dim = 'space'
for region in da_a[pairwise_dim]:
print(xr.corr(da_a.sel(space=region.item()), da_a, dim='time').values)
```
Target output would be an xarray with pairwise correlations, e.g.:
```bash
[ 1. -0.43942827 -0.22425502]
[-0.43942827 1. 0.30940081]
[-0.22425502 0.30940081 1. ]
```","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 1, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-557787104,https://api.github.com/repos/pydata/xarray/issues/3550,557787104,MDEyOklzc3VlQ29tbWVudDU1Nzc4NzEwNA==,45787861,2019-11-23T10:45:17Z,2019-11-23T10:45:17Z,NONE,"@dcherian, @max-sixty, @keewis, @Hoeze, second try: any more improvements required?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-557781732,https://api.github.com/repos/pydata/xarray/issues/3550,557781732,MDEyOklzc3VlQ29tbWVudDU1Nzc4MTczMg==,45787861,2019-11-23T09:23:46Z,2019-11-23T09:23:46Z,NONE,">
>
> > I'm not sure what's going on with the formatting. If you run ` black --version` and `black .` from the root of the repo, what do you get?
>
> ` black --version`:
>
> ```shell
> black, version 19.10b0
> ```
>
> `black .`:
>
> ```shell
> reformatted ...\xarray\xarray\core\dataarray.py
> All done! ✨ �🍰✨✨
> 1 file reformatted, 143 files left unchanged.
> ```
Now, I additionally get errors from pre-commit claiming that `GIT: unstaged files detected`.
Guess, the pre-commit installation was not completely correct?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-557777317,https://api.github.com/repos/pydata/xarray/issues/3550,557777317,MDEyOklzc3VlQ29tbWVudDU1Nzc3NzMxNw==,45787861,2019-11-23T08:08:44Z,2019-11-23T08:08:44Z,NONE,"> I'm not sure what's going on with the formatting. If you run ` black --version` and `black .` from the root of the repo, what do you get?
` black --version`:
```bash
black, version 19.10b0
```
`black .`:
```bash
reformatted ...\xarray\xarray\core\dataarray.py
All done! ✨ �🍰✨✨
1 file reformatted, 143 files left unchanged.
```
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-557706382,https://api.github.com/repos/pydata/xarray/issues/3550,557706382,MDEyOklzc3VlQ29tbWVudDU1NzcwNjM4Mg==,45787861,2019-11-22T21:46:25Z,2019-11-22T21:46:25Z,NONE,"PS: I personally would like to use cov and corr also with dask. Does it also make sense to put this in a future PR, together with the above-mentioned other improvements?
Further PRs:
- Add `dot`, `cov` and `corr` to `computation.rst`
> PS: It looks like `xr.dot` is only present in the ""API reference"" and not in https://xarray.pydata.org/en/stable/computation.html. We should add `dot`, `cov` and `corr` to `computation.rst` in a future PR.
- Test (and if necessary implement) `dask` compatibility to `cov` and `corr`
- Improve documentation on `How to contribute to the xarray documentation?`
> I think it already gives a good overview, but then it might be unclear how to proceed.
>
> Maybe it might make sense to add a subsection `How to contribute to the xarray documentation?` in which the different options are shortly described examplary:
>
> ```
> 1. change docstring, e.g. ....
> 2. update api.rst, e.g. ....
> 3. update whats-new.rst, e.g. ...
> ```
>
> Then, underline that building the documentation locally is optional:
>
> ```
> Optionally, you can build the docs locally as described in the next section.
> ```
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-557701008,https://api.github.com/repos/pydata/xarray/issues/3550,557701008,MDEyOklzc3VlQ29tbWVudDU1NzcwMTAwOA==,45787861,2019-11-22T21:27:59Z,2019-11-22T21:27:59Z,NONE,"@dcherian, @max-sixty, @keewis, @Hoeze, this is it, is it?
Let me know if there are some adjustments to be made. 🙂
And I still get `trailing whitespace errors`, despite having set up pre-commit to run black and flake8 automatically. Do I have to set some parameters to delete the trailing whitespaces?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-557085576,https://api.github.com/repos/pydata/xarray/issues/3550,557085576,MDEyOklzc3VlQ29tbWVudDU1NzA4NTU3Ng==,45787861,2019-11-21T13:31:19Z,2019-11-21T13:31:19Z,NONE,">
>
> Computation? Where is `xr.dot` documented?
`xr.dot` is implemented in computation, what do you mean by ""documented""?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-557071354,https://api.github.com/repos/pydata/xarray/issues/3550,557071354,MDEyOklzc3VlQ29tbWVudDU1NzA3MTM1NA==,1200058,2019-11-21T12:52:21Z,2019-11-21T12:52:21Z,NONE,"Awesome, thanks a lot @r-beer!","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-556991085,https://api.github.com/repos/pydata/xarray/issues/3550,556991085,MDEyOklzc3VlQ29tbWVudDU1Njk5MTA4NQ==,45787861,2019-11-21T09:14:20Z,2019-11-21T09:14:20Z,NONE,PS: accidently closed and commented instead of commenting,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-556990852,https://api.github.com/repos/pydata/xarray/issues/3550,556990852,MDEyOklzc3VlQ29tbWVudDU1Njk5MDg1Mg==,45787861,2019-11-21T09:13:44Z,2019-11-21T09:14:04Z,NONE,"> @r-beer let's go with @shoyer 's suggestion to change this from a method to a function `xr.cov` & `xr.corr`. Is that OK?
@shoyer, @max-sixty, @keewis, where should these functions be placed?
my first guesses:
- computation
- dataarray","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-556517301,https://api.github.com/repos/pydata/xarray/issues/3550,556517301,MDEyOklzc3VlQ29tbWVudDU1NjUxNzMwMQ==,45787861,2019-11-20T22:58:16Z,2019-11-20T22:58:16Z,NONE,"> (lmk if the docs were unclear and we can update)
I think it already gives a good overview, but then it might be unclear how to proceed.
Maybe it might make sense to add a subsection `How to contribute to the xarray documentation?` in which the different options are shortly described examplary:
```
1. change docstring, e.g. ....
2. update api.rst, e.g. ....
3. update whats-new.rst, e.g. ...
```
Then, underline that building the documentation locally is optional:
```
Optionally, you can build the docs locally as described in the next section.
```","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 1, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-556507107,https://api.github.com/repos/pydata/xarray/issues/3550,556507107,MDEyOklzc3VlQ29tbWVudDU1NjUwNzEwNw==,45787861,2019-11-20T22:48:25Z,2019-11-20T22:48:25Z,NONE,"For the sake of completeness (and to already learn the procedure) I just added some information to `whats-new.rst` and `api.rst` for the methods `da.cov` and `da.corr`.
I would be happy for feedback!
Tomorrow, I will rewrite the methods to functions and go through all the steps again. Good night from Germany!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-556492992,https://api.github.com/repos/pydata/xarray/issues/3550,556492992,MDEyOklzc3VlQ29tbWVudDU1NjQ5Mjk5Mg==,45787861,2019-11-20T22:34:58Z,2019-11-20T22:34:58Z,NONE,">
>
> @r-beer let's go with @shoyer 's suggestion to change this from a method to a function `xr.cov` & `xr.corr`. Is that OK?
Sure! I actually asked myself a similar software design question in another project.
Shouldn't be too much effort I guess? I will tackle it tomorrow. 😴 ","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-556490349,https://api.github.com/repos/pydata/xarray/issues/3550,556490349,MDEyOklzc3VlQ29tbWVudDU1NjQ5MDM0OQ==,45787861,2019-11-20T22:32:28Z,2019-11-20T22:32:28Z,NONE,">
>
> > I am now looking into the generation of the documentation.
>
> What do you mean by this? You shouldn't have to generate anything locally?
Oh, ok. I thought I have to create `xarray-docs` to update `whats-new.rst` and `api.rst`?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-556473132,https://api.github.com/repos/pydata/xarray/issues/3550,556473132,MDEyOklzc3VlQ29tbWVudDU1NjQ3MzEzMg==,45787861,2019-11-20T22:16:24Z,2019-11-20T22:16:24Z,NONE,">
>
> @r-beer your current test case looks fine, no stress on the fixtures!
Alright!
I am now looking into the generation of the documentation. However, it seems like the contributing guidelines are not up-to-date, as it's not possible to create the `xarray-docs` environment (see #3556).","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-556404945,https://api.github.com/repos/pydata/xarray/issues/3550,556404945,MDEyOklzc3VlQ29tbWVudDU1NjQwNDk0NQ==,45787861,2019-11-20T21:14:22Z,2019-11-20T21:14:22Z,NONE,"> @max-sixty, I have found the `da(request)` fixture. Do I correctly understand that the tests you mentioned above can be implemented using this fixture and parametrize decorators as in `@pytest.mark.parametrize(""da"", (1, 2), indirect=True)`?
I have tried to wrap my head around the elegant use of fixtures and parametrize but didn't get there yet. If you have some time to show a more elegant solution, I would be happy to learn! If not, I guess this should work, too.
Are the examples OK like this?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-556265324,https://api.github.com/repos/pydata/xarray/issues/3550,556265324,MDEyOklzc3VlQ29tbWVudDU1NjI2NTMyNA==,45787861,2019-11-20T19:13:20Z,2019-11-20T19:13:20Z,NONE,">
>
> I'm not sure about the examples in the `examples` folder, I think those are real-world examples?
>
> What I meant was examples like those in [`DataArray.integrate`](http://xarray.pydata.org/en/stable/generated/xarray.Dataset.integrate.html#xarray.Dataset.integrate) ([source](https://github.com/pydata/xarray/blob/6b70107ab3063187b663290538c0d5a4107dab6e/xarray/core/dataarray.py#L3063-L3110)) that simply demonstrate how to use that function.
OK! That simplifies the tasks quite a bit 🙂
I will implement this and the special cases for the tests, I might add Jupyter Notebook examples later to the documentation, when the `dataset.corr` functionality is also implemented.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-556248781,https://api.github.com/repos/pydata/xarray/issues/3550,556248781,MDEyOklzc3VlQ29tbWVudDU1NjI0ODc4MQ==,45787861,2019-11-20T18:59:08Z,2019-11-20T18:59:08Z,NONE,"> We could also add some variants which test along different dimensions / all NaNs / other special cases.
@max-sixty, I have found the `da(request)` fixture. Do I correctly understand that the tests you mentioned above can be implemented using this fixture and parametrize decorators as in `@pytest.mark.parametrize(""da"", (1, 2), indirect=True)`?","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-556244906,https://api.github.com/repos/pydata/xarray/issues/3550,556244906,MDEyOklzc3VlQ29tbWVudDU1NjI0NDkwNg==,45787861,2019-11-20T18:55:57Z,2019-11-20T18:55:57Z,NONE,"Concerning the examples, I have started to create a `Jupyter Notebook` in the examples folder.
Is this the right way to create the examples?
I have seen that the existing examples contain html code. Why is that? Why not only markdown?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-556094542,https://api.github.com/repos/pydata/xarray/issues/3550,556094542,MDEyOklzc3VlQ29tbWVudDU1NjA5NDU0Mg==,45787861,2019-11-20T16:48:16Z,2019-11-20T16:48:55Z,NONE,"> Test looks good. Let's make those adjustments you put in the `TODO` and add one for the other function?
@max-sixty, do you mean to add a TODO to the function mentioned in this commit: https://github.com/pydata/xarray/pull/3550/commits/d57eb7cfaf1407179080f0ca95e7951e5622b493?
Here, I think the `@requires_scipy_or_netCDF4` is actually necessary:
```python
@requires_scipy_or_netCDF4
@requires_dask
@pytest.mark.filterwarnings(""ignore:use make_scale(name) instead"")
def test_open_mfdataset_manyfiles(
```","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-556050094,https://api.github.com/repos/pydata/xarray/issues/3550,556050094,MDEyOklzc3VlQ29tbWVudDU1NjA1MDA5NA==,45787861,2019-11-20T15:19:16Z,2019-11-20T15:19:16Z,NONE,">
>
> Great start!
>
> Thanks for the review @keewis
>
> I think it's fine to leave `Dataset` for another PR; it'd be great to get this in, and given it's your first PR (welcome!) let's not bloat it
>
> Test looks good. Let's make those adjustments you put in the `TODO` and add one for the other function? We could also add some variants which test along different dimensions / all NaNs / other special cases.
Thank you two, @max-sixty and @keewis, for the constructive feedback that made the start easier!
I would also be happy to go once through the whole process and then implement the PR for the ds separately. This will probably cut the learning curve and accelerate the process.
Additionally, I wonder whether I have to configure black for the spaces between colons?
I had autoformatting running with autopep8 previously but since one of the last VS code updates something broke so I will set this up properly again on Friday or tomorrow.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-556010240,https://api.github.com/repos/pydata/xarray/issues/3550,556010240,MDEyOklzc3VlQ29tbWVudDU1NjAxMDI0MA==,45787861,2019-11-20T13:47:24Z,2019-11-20T13:47:24Z,NONE,">
>
> since the APIs of `DataArray` and `Dataset` are usually kept in sync as much as possible, it might be good to add the new methods to `Dataset`, too. This doesn't have to be in this PR, though, and I'd wait for confirmation first.
Yes, the functionality that I would be very interested in would be to calculate `corr()` also between different variables of a dataset as in [pandas.DataFrame.corr](https://pandas.pydata.org/pandas-docs/stable/reference/api/pandas.DataFrame.corr.html) as well as correlations between different locations within the same `DataArray` (e.g. correlations of time series with different latitudes).","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-555999418,https://api.github.com/repos/pydata/xarray/issues/3550,555999418,MDEyOklzc3VlQ29tbWVudDU1NTk5OTQxOA==,45787861,2019-11-20T13:17:37Z,2019-11-20T13:17:37Z,NONE,">
>
> for the new commit, yes. The older commits could be rewritten if you don't like the other email address being public (I guide you through the process if you want) but since PRs get squashed after the merge you don't have to.
OK, no need for the extra effort at this point, the squashing at the end of PR is fine for me. Thank you for the offer, anyway! 🙂
Are any other changes necessary for the PR?
ideas:
- examples for corr and cov usage
- whats-new.rst","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-555995427,https://api.github.com/repos/pydata/xarray/issues/3550,555995427,MDEyOklzc3VlQ29tbWVudDU1NTk5NTQyNw==,45787861,2019-11-20T13:06:32Z,2019-11-20T13:06:32Z,NONE,">
>
> There seems to be a problem with your email address (github can't match it to your account). Does it match the one you used for signing up on github?
Dear @keewis, I just set my real email address also as public email address and set my local git user name and email address accordingly. Does this solve the problem?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973
https://github.com/pydata/xarray/pull/3550#issuecomment-555966566,https://api.github.com/repos/pydata/xarray/issues/3550,555966566,MDEyOklzc3VlQ29tbWVudDU1NTk2NjU2Ng==,45787861,2019-11-20T11:39:11Z,2019-11-20T11:39:11Z,NONE,"@max-sixty, all three checks fail because `test_open_mfdataset_manyfiles` requires either netcdf4 or scipy.
Shall I, therefore, add the `@requires_scipy_or_netCDF4` decorator?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,525685973