html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/5721#issuecomment-903095007,https://api.github.com/repos/pydata/xarray/issues/5721,903095007,IC_kwDOAMm_X8411CLf,6628425,2021-08-21T10:18:33Z,2021-08-21T10:18:33Z,MEMBER,"Exactly, yeah, those are the problematic lines. That's an elegant solution. I think it will work with the minor modification to raise a `KeyError` if any of the indices returned by `get_indexer_nd` are less than zero:
```python
if method is not None:
indexer = get_indexer_nd(self.index, label, method, tolerance)
if np.any(indexer < 0):
raise KeyError(f""not all values found in index {coord_name!r}"")
else:
indexer = self.index.get_loc(label_value)
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,975385095
https://github.com/pydata/xarray/issues/5721#issuecomment-902918293,https://api.github.com/repos/pydata/xarray/issues/5721,902918293,IC_kwDOAMm_X8410XCV,6628425,2021-08-20T19:47:19Z,2021-08-20T19:47:19Z,MEMBER,"Thanks for the heads up @mathause. We'll need to think carefully about this with respect to partial datetime string indexing. `DatetimeIndex.get_indexer` and `DatetimeIndex.get_loc` behave differently with respect to datetime strings. `get_indexer` interprets strings as specific dates, while `get_loc` interprets them as ranges:
```
>>> import pandas as pd
>>> times = pd.date_range(""2000"", periods=5)
>>> times.get_indexer([""2000""])
array([0])
>>> times.get_loc(""2000"")
slice(0, 5, None)
```
In other words -- at least for partial datetime string indexing -- it may not be as simple as swapping in `get_indexer` for `get_loc`.
Perhaps @jbrockmendel has thoughts on how we should approach this?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,975385095