html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/5716#issuecomment-902286066,https://api.github.com/repos/pydata/xarray/issues/5716,902286066,IC_kwDOAMm_X841x8ry,5635139,2021-08-19T22:13:32Z,2021-08-19T22:13:32Z,MEMBER,"This looks good., thanks @pkopparla Thanks for reviewing @Illviljan . Agree re a test — at least to just test it runs, albeit trivial. `FrozenDict` would be better, though I think fine to do in another PR. We could return `dict(OPTIONS)` if we're worried people will attempt to set invalid values.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,974659059 https://github.com/pydata/xarray/pull/5716#issuecomment-902010417,https://api.github.com/repos/pydata/xarray/issues/5716,902010417,IC_kwDOAMm_X841w5Yx,14371165,2021-08-19T15:27:44Z,2021-08-19T15:27:44Z,MEMBER,"The returned dict should be read only, otherwise you can bypass all the validation checks that's done in `set_options`. I think you can use `FrozenDict` for that: https://github.com/pydata/xarray/blob/56cc0778d5edcb0173425b5850b834457c790210/xarray/core/utils.py#L476 Not sure if FrozenDict propagates the typing though, once OPTIONS is typed. We probably need to make sure that `get_options` is updated if `set_options` has been used. A test for that would be nice.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,974659059