html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/5449#issuecomment-856543812,https://api.github.com/repos/pydata/xarray/issues/5449,856543812,MDEyOklzc3VlQ29tbWVudDg1NjU0MzgxMg==,5821660,2021-06-08T07:51:49Z,2021-06-08T07:51:49Z,MEMBER,"Thanks for the ping @dcherian. 

There is this test: https://github.com/pydata/xarray/blob/da0489f4c7c823915dbb52b681b867baa16bc6e3/xarray/tests/test_computation.py#L1314-L1330 which provides `dtype` in `meta`. Maybe these different tests have to be aligned/combined? Unfortunately memory gets hazy over time, so I can't say much more about it without a deeper dive into.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,913830070
https://github.com/pydata/xarray/pull/5449#issuecomment-856529731,https://api.github.com/repos/pydata/xarray/issues/5449,856529731,MDEyOklzc3VlQ29tbWVudDg1NjUyOTczMQ==,10194086,2021-06-08T07:30:24Z,2021-06-08T07:30:24Z,MEMBER,No worries. I agree that only allowing one is cleaner. And definitively +1 on adding tests using meta.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,913830070
https://github.com/pydata/xarray/pull/5449#issuecomment-856294922,https://api.github.com/repos/pydata/xarray/issues/5449,856294922,MDEyOklzc3VlQ29tbWVudDg1NjI5NDkyMg==,2448579,2021-06-07T22:05:55Z,2021-06-07T22:05:55Z,MEMBER,"> but without much knowledge of how downstream libraries were using these arguments. 

IIRC xarray doesn't actually use it. `xarray.apply_ufunc` is a convenient wrapper for `apply_gufunc` so we just pass along what the user provides.

@kmuehlbauer added that test so maybe he can provide more context

>  Perhaps removing one of output_dtypes or meta from the test would be the best solution.

OK good point! There are a few tests for `output_dtypes` but we don't actually test for providing `dtype` in `meta`, so perhaps we should do that. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,913830070
https://github.com/pydata/xarray/pull/5449#issuecomment-856263319,https://api.github.com/repos/pydata/xarray/issues/5449,856263319,MDEyOklzc3VlQ29tbWVudDg1NjI2MzMxOQ==,5635139,2021-06-07T21:17:32Z,2021-06-07T21:17:32Z,MEMBER,Thanks @mathause !,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,913830070
https://github.com/pydata/xarray/pull/5449#issuecomment-856256166,https://api.github.com/repos/pydata/xarray/issues/5449,856256166,MDEyOklzc3VlQ29tbWVudDg1NjI1NjE2Ng==,10194086,2021-06-07T21:04:38Z,2021-06-07T21:04:38Z,MEMBER,thanks for the review - let's merge soon,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,913830070