html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/issues/5342#issuecomment-848943156,https://api.github.com/repos/pydata/xarray/issues/5342,848943156,MDEyOklzc3VlQ29tbWVudDg0ODk0MzE1Ng==,2448579,2021-05-26T16:52:50Z,2021-05-26T16:52:50Z,MEMBER,We should still make the changes proposed in https://github.com/pydata/xarray/issues/5342#issuecomment-844104261,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,895202415 https://github.com/pydata/xarray/issues/5342#issuecomment-845280227,https://api.github.com/repos/pydata/xarray/issues/5342,845280227,MDEyOklzc3VlQ29tbWVudDg0NTI4MDIyNw==,14808389,2021-05-20T16:43:56Z,2021-05-20T16:44:28Z,MEMBER,"for reference, the failing call is: ```python In [2]: bn.push(np.array([np.nan, 1.]), axis=0, n=None) Out[2]: array([nan, 1.]) ``` which should work with `bottleneck>=1.3` (I can reproduce the failure with `bottleneck=1.2.1`, which is the one you have in your environment).","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,895202415 https://github.com/pydata/xarray/issues/5342#issuecomment-845247492,https://api.github.com/repos/pydata/xarray/issues/5342,845247492,MDEyOklzc3VlQ29tbWVudDg0NTI0NzQ5Mg==,2448579,2021-05-20T16:01:50Z,2021-05-20T16:01:50Z,MEMBER,What version of bottleneck are you testing it with? We require `bottleneck >=1.3` (https://github.com/pydata/xarray/blob/master/ci/requirements/py37-min-all-deps.yml),"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,895202415 https://github.com/pydata/xarray/issues/5342#issuecomment-844104261,https://api.github.com/repos/pydata/xarray/issues/5342,844104261,MDEyOklzc3VlQ29tbWVudDg0NDEwNDI2MQ==,2448579,2021-05-19T13:25:25Z,2021-05-19T13:25:25Z,MEMBER,"Thanks. This is a new test. Here's where the error is triggered: https://github.com/pydata/xarray/blob/f3794ab1a75560f797b824c8c2d434aa65e7dd7d/xarray/core/dask_array_ops.py#L69-L73 We should specify both `dtype` and `meta` in the `map_*` calls like this: ``` python pushed = array.map_blocks(push, axis=axis, n=n, dtype=array.dtype, meta=array._meta) if len(array.chunks[axis]) > 1: pushed = pushed.map_overlap( push, axis=axis, n=n, depth={axis: (1, 0)}, boundary=""none"", dtype=array.dtype, meta=array._meta ) ``` Can you send in a PR please?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,895202415