html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/5278#issuecomment-835562066,https://api.github.com/repos/pydata/xarray/issues/5278,835562066,MDEyOklzc3VlQ29tbWVudDgzNTU2MjA2Ng==,14808389,2021-05-08T23:04:30Z,2021-05-08T23:04:30Z,MEMBER,"`__array_wrap__` doesn't allow specifying any kwargs (as far as I can tell), it has two parameters: `obj` and `context`. I'd have to read up on this, but `obj` seems to be the data (from `asarray` or `__array_prepare__`?) and `context` seems to be `None` most of the time.
In any case, I think we should try to replace `__array_wrap__` with `__array_function__` (or `__array_module__` / `__array_namespace__`?) soon.
Also, I agree on being consistent regarding the `out` parameter.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,879033384
https://github.com/pydata/xarray/issues/5278#issuecomment-835529368,https://api.github.com/repos/pydata/xarray/issues/5278,835529368,MDEyOklzc3VlQ29tbWVudDgzNTUyOTM2OA==,14808389,2021-05-08T21:45:32Z,2021-05-08T21:46:35Z,MEMBER,"`clip` dispatches through `__array_function__` (it's not a real ""ufunc""), so we don't really support that (there's a issue for adding `__array_function__`, but no progress yet). In general I think we should only support functions which don't have a `axis` parameter and return `NotImplemented` for all others, which means `clip` would be a good candidate.
We currently do have some support for `numpy.clip(arr, ...)` through `__array_wrap__` (so no support for `Dataset`), not sure if that even allows deviating from a standard?","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,879033384