html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/4984#issuecomment-800461714,https://api.github.com/repos/pydata/xarray/issues/4984,800461714,MDEyOklzc3VlQ29tbWVudDgwMDQ2MTcxNA==,5635139,2021-03-16T17:28:11Z,2021-03-16T17:28:11Z,MEMBER,"Great, merging!

Seconded re the docs! ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,819911891
https://github.com/pydata/xarray/pull/4984#issuecomment-800308560,https://api.github.com/repos/pydata/xarray/issues/4984,800308560,MDEyOklzc3VlQ29tbWVudDgwMDMwODU2MA==,5635139,2021-03-16T14:30:40Z,2021-03-16T14:30:40Z,MEMBER,"Excellent!

Could we add a very small test for the DataArray? Given the coverage on Dataset, it should mostly just test that the method works.

Any thoughts from others before we merge?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,819911891
https://github.com/pydata/xarray/pull/4984#issuecomment-799076455,https://api.github.com/repos/pydata/xarray/issues/4984,799076455,MDEyOklzc3VlQ29tbWVudDc5OTA3NjQ1NQ==,5635139,2021-03-15T04:13:46Z,2021-03-15T04:13:46Z,MEMBER,"Great re the dimensions!

I reviewed the tests more fully, they look great.

It looks like we need a `requires_numexpr` decorator on the tests — would you be OK to add that? 

Could we add a simple method to `DataArray` which converts to a Dataset, calls the functions, and converts back too? (there are lots of examples already of this, let me know any issues)

And we should add the methods to `api.rst`, and a whatsnew entry if possible.

---

Does anyone have any other thoughts? I think the API is very reasonable. I could imagine a more sophisticated API that could take a single query, rather than a dict of them by dimension — currently it's `da.query(x=""x>3"", y=""y>4"")`, but that would require more work and decisions, even if it were preferable.

","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,819911891
https://github.com/pydata/xarray/pull/4984#issuecomment-797842181,https://api.github.com/repos/pydata/xarray/issues/4984,797842181,MDEyOklzc3VlQ29tbWVudDc5Nzg0MjE4MQ==,5635139,2021-03-13T01:27:32Z,2021-03-13T01:27:32Z,MEMBER,"> Hi @max-sixty, no problem. Re this...
> 
> > Does the `pd.eval` work with more than two dimensions?
> 
> ...not quite sure what you mean, could you elaborate?

For sure — forgive me if I wasn't clear.

Currently the test runs over an array of two dimensions — `x` & `y`. Would `pd.query` work if there were also a `z` dimension?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,819911891