html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/4971#issuecomment-812868358,https://api.github.com/repos/pydata/xarray/issues/4971,812868358,MDEyOklzc3VlQ29tbWVudDgxMjg2ODM1OA==,14808389,2021-04-03T13:52:26Z,2021-04-03T13:52:26Z,MEMBER,"should we merge this? It is blocking #4902, which in turn is blocking #5041.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,818051289
https://github.com/pydata/xarray/pull/4971#issuecomment-811436416,https://api.github.com/repos/pydata/xarray/issues/4971,811436416,MDEyOklzc3VlQ29tbWVudDgxMTQzNjQxNg==,14808389,2021-03-31T20:22:04Z,2021-03-31T20:22:04Z,MEMBER,(the RTD build fails because `docs.scipy.org` is down),"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,818051289
https://github.com/pydata/xarray/pull/4971#issuecomment-811386980,https://api.github.com/repos/pydata/xarray/issues/4971,811386980,MDEyOklzc3VlQ29tbWVudDgxMTM4Njk4MA==,14808389,2021-03-31T19:39:17Z,2021-03-31T19:39:17Z,MEMBER,"I decided to change the default from `""drop""` to `""override""`, so the only thing that changes is that the `attrs` for variables will not be dropped but kept according to `combine_attrs`.

I guess that means that unless the CI fails this should be ready for review / merging?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,818051289
https://github.com/pydata/xarray/pull/4971#issuecomment-787521182,https://api.github.com/repos/pydata/xarray/issues/4971,787521182,MDEyOklzc3VlQ29tbWVudDc4NzUyMTE4Mg==,14808389,2021-02-28T20:53:23Z,2021-02-28T20:53:23Z,MEMBER,"for the main object, yes, but for the variables of that object `""drop""` is currently always used. That means that if we try to sync both we introduce a breaking change.

We might eventually want to switch both to `""drop_conflicts""` so we would need to go through a deprecation cycle anyways.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,818051289
https://github.com/pydata/xarray/pull/4971#issuecomment-787480122,https://api.github.com/repos/pydata/xarray/issues/4971,787480122,MDEyOklzc3VlQ29tbWVudDc4NzQ4MDEyMg==,10194086,2021-02-28T16:36:48Z,2021-02-28T16:36:48Z,MEMBER,"The motivation for `attrs_file` is given in  #2382. Maybe require `combine_attrs == ""override""` when `attrs_file is not None`?

The current behavior is `combine_attrs=""override""`, right? So when choosing something else this would have to be deprecated","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,818051289