html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/4879#issuecomment-1278202565,https://api.github.com/repos/pydata/xarray/issues/4879,1278202565,IC_kwDOAMm_X85ML9LF,1217238,2022-10-13T21:34:05Z,2022-10-13T21:34:05Z,MEMBER,I think we could fix this by marking CachingFileManager with `typing.final`,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,803068773 https://github.com/pydata/xarray/pull/4879#issuecomment-1269050790,https://api.github.com/repos/pydata/xarray/issues/4879,1269050790,IC_kwDOAMm_X85LpC2m,1217238,2022-10-05T22:27:28Z,2022-10-05T22:27:28Z,MEMBER,Anyone want to review here? I think this should be ready to go in.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,803068773 https://github.com/pydata/xarray/pull/4879#issuecomment-1268700309,https://api.github.com/repos/pydata/xarray/issues/4879,1268700309,IC_kwDOAMm_X85LntSV,1217238,2022-10-05T17:06:02Z,2022-10-05T17:57:19Z,MEMBER,"~~Actually maybe we don't need to keep files open after pickling... let me give this one more try.~~ Nevermind, this didn't work -- it still results in failing tests with dask-distributed on Windows.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,803068773 https://github.com/pydata/xarray/pull/4879#issuecomment-1268684962,https://api.github.com/repos/pydata/xarray/issues/4879,1268684962,IC_kwDOAMm_X85Lnpii,1217238,2022-10-05T16:51:14Z,2022-10-05T16:51:14Z,MEMBER,"OK, after a bit more futzing tests are passing and I think this is actually ready to go in. I ended up leaving in the reference counting after all -- I couldn't figure out another way to keep files open after a pickle round-trip.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,803068773 https://github.com/pydata/xarray/pull/4879#issuecomment-1259823913,https://api.github.com/repos/pydata/xarray/issues/4879,1259823913,IC_kwDOAMm_X85LF2Mp,1217238,2022-09-27T17:26:06Z,2022-09-27T17:26:06Z,MEMBER,"I added @cjauvin's integration test, and verified that the fix works for the scipy and h5netcdf backends. Unfortunately, it doesn't work yet for the netCDF4 backend. I don't think we can solve this in Xarray without fixes netCDF4-Python or the netCDF-C library: https://github.com/Unidata/netcdf4-python/issues/1195 ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,803068773 https://github.com/pydata/xarray/pull/4879#issuecomment-775749858,https://api.github.com/repos/pydata/xarray/issues/4879,775749858,MDEyOklzc3VlQ29tbWVudDc3NTc0OTg1OA==,1217238,2021-02-09T08:05:40Z,2021-02-09T08:05:40Z,MEMBER,"Thanks for sharing the test case, which I'll add to this PR. I ran it locally and it seems to pass with this PR for the netCDF4 and SciPy netCDF backends (but not h5netcdf). So I'm not entirely sure what to make of that. On Mon, Feb 8, 2021 at 1:56 PM Christian Jauvin wrote: > As my colleague @huard suggested, I have > written an additional test which demonstrates the problem (essentially the > same idea I proposed in my initial issue > ): > > master...cjauvin:add-netcdf-refresh-test > > > As I explained in the issue I have a potential fix for the problem: > > master...cjauvin:netcdf-caching-bug > > > but the problem is that it feels a bit weird to have to that, so I suspect > that there's a better way to solve it. > > — > You are receiving this because you authored the thread. > Reply to this email directly, view it on GitHub > , or > unsubscribe > > . > ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,803068773