html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/4835#issuecomment-799825521,https://api.github.com/repos/pydata/xarray/issues/4835,799825521,MDEyOklzc3VlQ29tbWVudDc5OTgyNTUyMQ==,13301940,2021-03-15T23:20:24Z,2021-03-15T23:20:24Z,MEMBER,"Thank you @keewis, @dcherian, @shoyer! ","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 1, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,790677360 https://github.com/pydata/xarray/pull/4835#issuecomment-799412180,https://api.github.com/repos/pydata/xarray/issues/4835,799412180,MDEyOklzc3VlQ29tbWVudDc5OTQxMjE4MA==,13301940,2021-03-15T13:18:15Z,2021-03-15T13:18:15Z,MEMBER,I plan to merge this later today (unless there's any objection and/or necessary changes),"{""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,790677360 https://github.com/pydata/xarray/pull/4835#issuecomment-793290179,https://api.github.com/repos/pydata/xarray/issues/4835,793290179,MDEyOklzc3VlQ29tbWVudDc5MzI5MDE3OQ==,13301940,2021-03-09T02:40:26Z,2021-03-09T02:40:26Z,MEMBER,"> The only issue I have with the new theme is that due to the maximum line length we use some examples have horizontal scroll bars (unless the left side bar is hidden). @keewis, I fixed this issue. @pydata/xarray, this PR is ready. Unless there's any additional issue that needs to be addressed before merging, feel free to merge this. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,790677360 https://github.com/pydata/xarray/pull/4835#issuecomment-792450644,https://api.github.com/repos/pydata/xarray/issues/4835,792450644,MDEyOklzc3VlQ29tbWVudDc5MjQ1MDY0NA==,13301940,2021-03-08T04:19:51Z,2021-03-08T04:19:51Z,MEMBER,"> It'd be nice to get the left sidebar to ""pin"" like the right one. Right now if you scroll enough ,it disappears @dcherian, this is fixed. When you get a moment, take another look and let me know if I missed anything. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,790677360 https://github.com/pydata/xarray/pull/4835#issuecomment-792176039,https://api.github.com/repos/pydata/xarray/issues/4835,792176039,MDEyOklzc3VlQ29tbWVudDc5MjE3NjAzOQ==,13301940,2021-03-07T02:33:15Z,2021-03-07T02:33:15Z,MEMBER," @dcherian, > Can we add another level of organization to API reference in the sidebar: ""Top-Level Functions"", ""Dataset"" etc.? > It'd be nice to get the left sidebar to ""pin"" like the right one. Right now if you scroll enough ,it disappears I have yet to figure this out. If someone knows how to do this (whether with or without custom HTML template), please let me know :) > Another minor comment: How about renaming ""external resources"" to ""Tutorials & Videos""? Similarly ""Related projects"" to ""Ecosystem""? Done! @keewis, > The only issue I have with the new theme is that due to the maximum line length we use some examples have horizontal scroll bars (unless the left side bar is hidden). I will see if there's a remedy for this. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,790677360 https://github.com/pydata/xarray/pull/4835#issuecomment-790823788,https://api.github.com/repos/pydata/xarray/issues/4835,790823788,MDEyOklzc3VlQ29tbWVudDc5MDgyMzc4OA==,13301940,2021-03-04T18:16:55Z,2021-03-04T18:16:55Z,MEMBER,"@pydata/xarray, this is ready for another round of reviews... ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,790677360 https://github.com/pydata/xarray/pull/4835#issuecomment-789910109,https://api.github.com/repos/pydata/xarray/issues/4835,789910109,MDEyOklzc3VlQ29tbWVudDc4OTkxMDEwOQ==,13301940,2021-03-03T17:29:15Z,2021-03-03T17:30:42Z,MEMBER,"> Is there a particular reason why we're moving away from `nbsphinx`? I got a bit carried away when I saw the _Markdown_ design document in https://github.com/pydata/xarray/pull/4979 :). I figured with myst/myst-nb, it would be easier to support documentation source written in any format (`.md`, `.rst`, `.ipynb`) in the future. I will revert back to nbsphinx ((the switch is probably not yet worth it). > unrelated to that: the internals page is a collection of mostly unrelated topics. It might be good to break it up into separate pages (e.g. ""Variable"", ""duckarray integration"", ""accessors"", ""zarr spec"", ""custom backends"", etc.) 👍🏽. I am going to separate them into different pages","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,790677360 https://github.com/pydata/xarray/pull/4835#issuecomment-789822281,https://api.github.com/repos/pydata/xarray/issues/4835,789822281,MDEyOklzc3VlQ29tbWVudDc4OTgyMjI4MQ==,13301940,2021-03-03T16:00:56Z,2021-03-03T16:00:56Z,MEMBER,"@keewis, I recall you mentioning that the xarray's sphinx build on RTD is configured to turn warnings into errors. Currently, I have an extension that warns that it's not safe for parallel reads. As a result, the entire build fails: > WARNING: the myst_nb extension is not safe for parallel reading > WARNING: doing serial read Can you suggest any workaround for this issue?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,790677360 https://github.com/pydata/xarray/pull/4835#issuecomment-773502287,https://api.github.com/repos/pydata/xarray/issues/4835,773502287,MDEyOklzc3VlQ29tbWVudDc3MzUwMjI4Nw==,13301940,2021-02-04T18:07:00Z,2021-02-04T18:07:00Z,MEMBER,"Thank you for the pointer to the matplolib's doc structure. I hadn't figured out the distinction between examples and tutorials until I looked at their examples (which seem to focus on a single feature) and tutorials (which seem to be a complete workflow with deep-dives) pages. After looking at other projects, namely pymc3(https://docs.pymc.io/nb_tutorials/index.html, https://docs.pymc.io/nb_examples/index.html), scikit-learn (https://scikit-learn.org/stable/auto_examples/index.html, https://scikit-learn.org/stable/tutorial/index.html), I'm in favor of (1) having dedicated sections for both tutorials and examples and (2) merging the getting-started guide with user-guide. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,790677360 https://github.com/pydata/xarray/pull/4835#issuecomment-773481086,https://api.github.com/repos/pydata/xarray/issues/4835,773481086,MDEyOklzc3VlQ29tbWVudDc3MzQ4MTA4Ng==,13301940,2021-02-04T17:33:05Z,2021-02-04T17:33:05Z,MEMBER,"> So I wonder if it makes sense to move ""Getting Started"" under ""User Guide"" and add a new top-level ""Tutorials"" @dcherian, I should point out that I created a new section [(`gallery`)](https://xray--4835.org.readthedocs.build/en/4835/gallery.html) and this is where I've been putting the examples/tutorials. Are you suggesting that we merge the `gallery`, `getting-started-guide` with the `user-guide`? Or should we just - merge the `getting-started` with the `user-guide` and - then move the https://xray--4835.org.readthedocs.build/en/4835/index.html#see-also to the gallery section?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,790677360 https://github.com/pydata/xarray/pull/4835#issuecomment-772776512,https://api.github.com/repos/pydata/xarray/issues/4835,772776512,MDEyOklzc3VlQ29tbWVudDc3Mjc3NjUxMg==,13301940,2021-02-03T19:48:54Z,2021-02-03T20:24:22Z,MEMBER,"> that's because of the headings in `whats-new.rst`. I think you have to be consistent with the style you use (`=`, `+`, `~`, `-`). Ah okay... ~~Is this issue connected to a specific sphinx version or readthedocs? I'm asking because I don't run into this issue locally~~ Edit: I was too quick to reply. 👍🏽 for @DocOtak's explanation (https://github.com/pydata/xarray/pull/4835#issuecomment-772729659)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,790677360 https://github.com/pydata/xarray/pull/4835#issuecomment-772778377,https://api.github.com/repos/pydata/xarray/issues/4835,772778377,MDEyOklzc3VlQ29tbWVudDc3Mjc3ODM3Nw==,13301940,2021-02-03T19:51:56Z,2021-02-03T19:51:56Z,MEMBER,"> Also, the build step also has a `-W` flag which turns warnings into Errors and causes a non 0 exit status. This is probably because the read the docs config file for xarray has a `fail_on_warning` set to true Thank you for the clarification.... ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,790677360 https://github.com/pydata/xarray/pull/4835#issuecomment-772714849,https://api.github.com/repos/pydata/xarray/issues/4835,772714849,MDEyOklzc3VlQ29tbWVudDc3MjcxNDg0OQ==,13301940,2021-02-03T18:14:37Z,2021-02-03T18:14:37Z,MEMBER,"@pydata/xarray, does anyone know what's going on with readthedocs: https://readthedocs.org/projects/xray/builds/12928622/? I can't seem to figure out the error causing the build failures. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,790677360 https://github.com/pydata/xarray/pull/4835#issuecomment-764290596,https://api.github.com/repos/pydata/xarray/issues/4835,764290596,MDEyOklzc3VlQ29tbWVudDc2NDI5MDU5Ng==,13301940,2021-01-21T04:40:57Z,2021-01-21T04:40:57Z,MEMBER,Cc @jhamman ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,790677360