html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/4750#issuecomment-753682203,https://api.github.com/repos/pydata/xarray/issues/4750,753682203,MDEyOklzc3VlQ29tbWVudDc1MzY4MjIwMw==,5635139,2021-01-03T22:00:40Z,2021-01-03T22:00:40Z,MEMBER,Looks great! Any other comments from anyone before we merge?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,777526340 https://github.com/pydata/xarray/pull/4750#issuecomment-753679973,https://api.github.com/repos/pydata/xarray/issues/4750,753679973,MDEyOklzc3VlQ29tbWVudDc1MzY3OTk3Mw==,5635139,2021-01-03T21:40:38Z,2021-01-03T21:40:38Z,MEMBER,"Re number of rows — no strong view — something between 12-20 seems great. Would you like to add a whatsnew too? Thanks!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,777526340 https://github.com/pydata/xarray/pull/4750#issuecomment-753679789,https://api.github.com/repos/pydata/xarray/issues/4750,753679789,MDEyOklzc3VlQ29tbWVudDc1MzY3OTc4OQ==,5635139,2021-01-03T21:39:11Z,2021-01-03T21:39:11Z,MEMBER,"For `black`, you should be able to run `black .` in the root of the project, and black will format all the files. A more integrated approach is to run `pre-commit install` and then either on every commit or `pre-commit run` will run all the checks. You should also be able to integrate `black` with your editor, such that it makes the changes on every file save. Let me know if you need any help with that, or the pre-commit docs are here: https://pre-commit.com/ — having to run it manually for each file doesn't sound like fun 😄 ! If it's unclear, then we should make our docs clearer — it's on us, not you. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,777526340 https://github.com/pydata/xarray/pull/4750#issuecomment-753596176,https://api.github.com/repos/pydata/xarray/issues/4750,753596176,MDEyOklzc3VlQ29tbWVudDc1MzU5NjE3Ng==,14371165,2021-01-03T10:26:39Z,2021-01-03T10:26:39Z,MEMBER,"I just do ```python import black black.main([f""{filename}""]) ``` in my ipython console and that usually works. Does xarray have any further settings? Any opinions on the default max_rows? It should be an even number so it divides cleanly with 2. I prefer 12 now because it leaves some room for a lot of coords as well.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,777526340 https://github.com/pydata/xarray/pull/4750#issuecomment-753578756,https://api.github.com/repos/pydata/xarray/issues/4750,753578756,MDEyOklzc3VlQ29tbWVudDc1MzU3ODc1Ng==,5635139,2021-01-03T07:14:49Z,2021-01-03T07:14:49Z,MEMBER,"Looks good! I made the change on black (lmk if you need a hand setting that up client-side — ideally that should just work and make contributing easier not harder). PRing a change so the black diff prints too","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,777526340 https://github.com/pydata/xarray/pull/4750#issuecomment-753550006,https://api.github.com/repos/pydata/xarray/issues/4750,753550006,MDEyOklzc3VlQ29tbWVudDc1MzU1MDAwNg==,14371165,2021-01-03T00:47:53Z,2021-01-03T00:47:53Z,MEMBER,"Added a test now and of course the code got a little heavier to handle the edge cases. I don't really get why this black is complaining. I get no diffs on my version. It would be nice if it would show the changes so I can manually make it happy. Dask shows the black diffs for example.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,777526340 https://github.com/pydata/xarray/pull/4750#issuecomment-753532879,https://api.github.com/repos/pydata/xarray/issues/4750,753532879,MDEyOklzc3VlQ29tbWVudDc1MzUzMjg3OQ==,5635139,2021-01-02T21:37:27Z,2021-01-02T21:37:27Z,MEMBER,"Looks great! Could we add a test? We should already have done tests for reprs, so we can add a test case with enough lines for this to kick in.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,777526340