html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/4516#issuecomment-714845199,https://api.github.com/repos/pydata/xarray/issues/4516,714845199,MDEyOklzc3VlQ29tbWVudDcxNDg0NTE5OQ==,6628425,2020-10-23T01:08:50Z,2020-10-23T01:08:50Z,MEMBER,"Thanks to @topper-123's PR being merged upstream, this is now fixed. The next time our CI runs it should be green (I tested things out offline). If we want we can consider leveraging `_id` in `CFTimeIndex` later, but this particular issue can be closed.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,723181209
https://github.com/pydata/xarray/issues/4516#issuecomment-714146475,https://api.github.com/repos/pydata/xarray/issues/4516,714146475,MDEyOklzc3VlQ29tbWVudDcxNDE0NjQ3NQ==,6628425,2020-10-22T01:30:25Z,2020-10-22T01:30:25Z,MEMBER,"Thanks @topper-123 -- I see you also made https://github.com/pandas-dev/pandas/pull/37321, making `Index._id` optional again, which I appreciate!
We do rely on private attributes in some places, but we're typically cautious about doing that, because their behavior can change without warning. For instance, in this case pandas-dev/pandas#37087 would have been a breaking change in a different way, since `_reset_identity` went from returning an Index, to operating on the Index in place.
Looking at the history of `pandas.Index`, it generally seems like outside the recent change, `_reset_identity` has been pretty stable over the years, though we'd still need to mull over the trade-off between the performance benefit and the robustness of the subclass to changes in pandas.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,723181209
https://github.com/pydata/xarray/issues/4516#issuecomment-711100380,https://api.github.com/repos/pydata/xarray/issues/4516,711100380,MDEyOklzc3VlQ29tbWVudDcxMTEwMDM4MA==,6628425,2020-10-18T00:54:31Z,2020-10-18T00:54:31Z,MEMBER,I posted a question in the pandas repo related to this: https://github.com/pandas-dev/pandas/issues/37213.,"{""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,723181209
https://github.com/pydata/xarray/issues/4516#issuecomment-711022646,https://api.github.com/repos/pydata/xarray/issues/4516,711022646,MDEyOklzc3VlQ29tbWVudDcxMTAyMjY0Ng==,6628425,2020-10-17T14:42:42Z,2020-10-17T14:44:21Z,MEMBER,"Indeed a bisect reveals pandas-dev/pandas#37087 was the cause:
```
abd3acf05516611e9e90d57ae363f1567e30f49a is the first bad commit
commit abd3acf05516611e9e90d57ae363f1567e30f49a
Author: Terji Petersen
Date: Wed Oct 14 13:26:45 2020 +0100
CLN: clean Index._id (#37087)
pandas/core/indexes/base.py | 21 +++++++++++++--------
pandas/core/indexes/multi.py | 4 +++-
pandas/tests/arithmetic/test_object.py | 3 ++-
3 files changed, 18 insertions(+), 10 deletions(-)
```
I think it's that `_id` used to automatically be initialized to `None` and now it needs to be explicitly initialized within the constructor. They added some try-except logic in the `is_` method to handle the case where `_id` has not been initialized, but there's an error happening now within the `view` method. Here's a more minimal example:
```
In [1]: import xarray as xr
In [2]: xr.cftime_range(""2000"", periods=2).view()
---------------------------------------------------------------------------
AttributeError Traceback (most recent call last)
in
----> 1 xr.cftime_range(""2000"", periods=2).view()
~/Software/pandas/pandas/core/indexes/base.py in view(self, cls)
630 result = self._shallow_copy()
631 if isinstance(result, Index):
--> 632 result._id = self._id
633 return result
634
AttributeError: 'CFTimeIndex' object has no attribute '_id'
```
I'll have to think about things a little more to see if we should pursue an upstream fix or whether we can address it in xarray.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,723181209