html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/4510#issuecomment-719538691,https://api.github.com/repos/pydata/xarray/issues/4510,719538691,MDEyOklzc3VlQ29tbWVudDcxOTUzODY5MQ==,10194086,2020-10-30T13:01:38Z,2020-10-30T13:01:38Z,MEMBER,"I added a test to ensure `da.name` is conserved & the tests passed. So this is finished from my side. I guess this is not so easy to review as I change one or two lines per function in a lot of functions. So maybe someone could just review the tests? Or maybe you already did? While working on this I thought `rolling` could profit from some refactoring but I kept it out of this PR. I might follow up with do this if I find time.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,721853828 https://github.com/pydata/xarray/pull/4510#issuecomment-709266070,https://api.github.com/repos/pydata/xarray/issues/4510,709266070,MDEyOklzc3VlQ29tbWVudDcwOTI2NjA3MA==,10194086,2020-10-15T12:15:29Z,2020-10-15T12:15:29Z,MEMBER,"As mentioned in #4513 I should probably switch from `ds.rolling(..., keep_attrs=True).mean()` to `ds.rolling(...).mean( keep_attrs=True)`. Let's see if there is feedback/ a consensus on #4513","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,721853828