html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/4432#issuecomment-694855220,https://api.github.com/repos/pydata/xarray/issues/4432,694855220,MDEyOklzc3VlQ29tbWVudDY5NDg1NTIyMA==,14808389,2020-09-18T13:04:40Z,2020-09-18T13:20:45Z,MEMBER,"~it did, the first failing commit is https://github.com/pydata/xarray/pull/4432/commits/381aaf8cc37502907506011f8cb9f4149e229d2d~

Edit: sorry, you're right, the first commit should have also failed. Not sure why that happened, and we can't really check because the build logs were already deleted.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,703881154
https://github.com/pydata/xarray/pull/4432#issuecomment-694817581,https://api.github.com/repos/pydata/xarray/issues/4432,694817581,MDEyOklzc3VlQ29tbWVudDY5NDgxNzU4MQ==,1312546,2020-09-18T11:36:49Z,2020-09-18T11:36:49Z,MEMBER,"I'm not sure, but I don't think so. It's strange that it didn't fail on the
pull request.

On Thu, Sep 17, 2020 at 8:51 PM Maximilian Roos <notifications@github.com>
wrote:

> Might be best to proceed with #4434
> <https://github.com/pydata/xarray/pull/4434> for now. I'll need to give
> this a bit of thought.
>
> OK, as you wish, I'll merge if that passes.
>
> But your change did pass before the merge. Could it be a conflict (in
> functionality, not git) with recent changes on master?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/pydata/xarray/pull/4432#issuecomment-694601049>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AAKAOISNY5A5N2A44YR2ZMLSGK4JTANCNFSM4RQ6OP2Q>
> .
>
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,703881154
https://github.com/pydata/xarray/pull/4432#issuecomment-694601049,https://api.github.com/repos/pydata/xarray/issues/4432,694601049,MDEyOklzc3VlQ29tbWVudDY5NDYwMTA0OQ==,5635139,2020-09-18T01:51:04Z,2020-09-18T01:51:04Z,MEMBER,"> Might be best to proceed with #4434 for now. I'll need to give this a bit of thought.

OK, as you wish, I'll merge if that passes. 

But your change did pass before the merge. Could it be a conflict (in functionality, not git) with recent changes on master?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,703881154
https://github.com/pydata/xarray/pull/4432#issuecomment-694594817,https://api.github.com/repos/pydata/xarray/issues/4432,694594817,MDEyOklzc3VlQ29tbWVudDY5NDU5NDgxNw==,1312546,2020-09-18T01:27:30Z,2020-09-18T01:27:30Z,MEMBER,Might be best to proceed with https://github.com/pydata/xarray/pull/4434 for now. I'll need to give this a bit of thought.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,703881154
https://github.com/pydata/xarray/pull/4432#issuecomment-694593225,https://api.github.com/repos/pydata/xarray/issues/4432,694593225,MDEyOklzc3VlQ29tbWVudDY5NDU5MzIyNQ==,1312546,2020-09-18T01:22:43Z,2020-09-18T01:22:43Z,MEMBER,"Huh, I'm able to reproduce locally. Looking into it now.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,703881154
https://github.com/pydata/xarray/pull/4432#issuecomment-694572691,https://api.github.com/repos/pydata/xarray/issues/4432,694572691,MDEyOklzc3VlQ29tbWVudDY5NDU3MjY5MQ==,5635139,2020-09-18T00:24:48Z,2020-09-18T00:24:48Z,MEMBER,"Hmmm. It did pass before the merge _from_ master:

![Uploading image.png…]()
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,703881154
https://github.com/pydata/xarray/pull/4432#issuecomment-694567822,https://api.github.com/repos/pydata/xarray/issues/4432,694567822,MDEyOklzc3VlQ29tbWVudDY5NDU2NzgyMg==,14808389,2020-09-18T00:11:46Z,2020-09-18T00:11:46Z,MEMBER,"with the merge we have a test failure:
```
_______________________ test_persist_Dataset[<lambda>1] ________________________

persist = <function <lambda> at 0x7fe8d1646048>

    @pytest.mark.parametrize(
        ""persist"", [lambda x: x.persist(), lambda x: dask.persist(x)[0]]
    )
    def test_persist_Dataset(persist):
        ds = Dataset({""foo"": (""x"", range(5)), ""bar"": (""x"", range(5))}).chunk()
        ds = ds + 1
        n = len(ds.foo.data.dask)
    
        ds2 = persist(ds)
    
>       assert len(ds2.foo.data.dask) == 1
E       AssertionError: assert 2 == 1
E        +  where 2 = len(<dask.highlevelgraph.HighLevelGraph object at 0x7fe8c45f4518>)
E        +    where <dask.highlevelgraph.HighLevelGraph object at 0x7fe8c45f4518> = dask.array<add, shape=(5,), dtype=int64, chunksize=(5,), chunktype=numpy.ndarray>.dask
E        +      where dask.array<add, shape=(5,), dtype=int64, chunksize=(5,), chunktype=numpy.ndarray> = <xarray.DataArray 'foo' (x: 5)>\ndask.array<add, shape=(5,), dtype=int64, chunksize=(5,), chunktype=numpy.ndarray>\nDimensions without coordinates: x.data
E        +        where <xarray.DataArray 'foo' (x: 5)>\ndask.array<add, shape=(5,), dtype=int64, chunksize=(5,), chunktype=numpy.ndarray>\nDimensions without coordinates: x = <xarray.Dataset>\nDimensions:  (x: 5)\nDimensions without coordinates: x\nData variables:\n    foo      (x) int64 dask.array<chunksize=(5,), meta=np.ndarray>\n    bar      (x) int64 dask.array<chunksize=(5,), meta=np.ndarray>.foo

/home/vsts/work/1/s/xarray/tests/test_dask.py:943: AssertionError
```
does anyone know why that happens?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,703881154
https://github.com/pydata/xarray/pull/4432#issuecomment-694550329,https://api.github.com/repos/pydata/xarray/issues/4432,694550329,MDEyOklzc3VlQ29tbWVudDY5NDU1MDMyOQ==,5635139,2020-09-17T23:19:18Z,2020-09-17T23:19:18Z,MEMBER,"Thanks @TomAugspurger ! 
Merging so we can get this into 0.16.1","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,703881154