html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/4409#issuecomment-691217305,https://api.github.com/repos/pydata/xarray/issues/4409,691217305,MDEyOklzc3VlQ29tbWVudDY5MTIxNzMwNQ==,1217238,2020-09-11T17:20:06Z,2020-09-11T17:20:06Z,MEMBER,"One way to fix this is to iterate over variables instead of `_coord_names`, e.g., instead of:
```python
for k in self._coord_names:
...
```
use:
```python
for k in self._variables:
if k in self._coord_names:
...
```
I believe we already use this trick in a few places for exactly this reason.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,694448177
https://github.com/pydata/xarray/pull/4409#issuecomment-691181491,https://api.github.com/repos/pydata/xarray/issues/4409,691181491,MDEyOklzc3VlQ29tbWVudDY5MTE4MTQ5MQ==,1217238,2020-09-11T16:03:59Z,2020-09-11T16:03:59Z,MEMBER,"OK, my guess is that this is happening because there is someplace where we iterate over a Python `set` (which has a non-deterministic order based on hashing) rather than a Python `dict`. If we can nail down where that is happening we should remove it!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,694448177
https://github.com/pydata/xarray/pull/4409#issuecomment-690879736,https://api.github.com/repos/pydata/xarray/issues/4409,690879736,MDEyOklzc3VlQ29tbWVudDY5MDg3OTczNg==,1217238,2020-09-11T05:18:02Z,2020-09-11T05:18:02Z,MEMBER,"Can you give an example of a non-deterministic coordinate order? That sounds surprising to me, given that on Python 3.6+ dictionaries preserve insertion order.
My preference would be not to sort mappings automatically, either in `__init__` or when formatting. I think users find it a little more intuitive to preserve the order of dict keys.
It's true that this is only a guarantee on Python 3.7+, but both CPython 3.6 and all versions of pypy 3 preserve dict insertion order, so in practice we can pretty much always guarantee this. (And soon, Python 3.7 will be required for xarray.)","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,694448177