html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/4233#issuecomment-681812005,https://api.github.com/repos/pydata/xarray/issues/4233,681812005,MDEyOklzc3VlQ29tbWVudDY4MTgxMjAwNQ==,10194086,2020-08-27T08:50:15Z,2020-08-27T08:50:15Z,MEMBER,thanks @jenssss I see this is your first PR - welcome to xarray!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,658938729
https://github.com/pydata/xarray/pull/4233#issuecomment-679967683,https://api.github.com/repos/pydata/xarray/issues/4233,679967683,MDEyOklzc3VlQ29tbWVudDY3OTk2NzY4Mw==,10194086,2020-08-25T11:27:33Z,2020-08-25T11:28:31Z,MEMBER,LGTM. I'll merge in a day or two unless someone else has a comment. (#3924),"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,658938729
https://github.com/pydata/xarray/pull/4233#issuecomment-679911389,https://api.github.com/repos/pydata/xarray/issues/4233,679911389,MDEyOklzc3VlQ29tbWVudDY3OTkxMTM4OQ==,10194086,2020-08-25T09:22:27Z,2020-08-25T09:22:27Z,MEMBER,"Thanks! I have two more suggestions:

Can you add an additional line with 
```python
([""2000-01-01T12:00"", ""2000-01-02T12:00"", ""NaT""], [0.5, 1.5]), 
```
here:

https://github.com/pydata/xarray/blob/8313c3eb7e92c15a82a3ae8ba7dff7d49a37c309/xarray/tests/test_interp.py#L575

to have a test with a missing datetime.

Do you also want to add a note to the docstring, e.g. adding `Missing values are skipped`. Here:

https://github.com/pydata/xarray/blob/a36d0a1d4657c848dcdd76d0ecb9c783ad464057/xarray/core/dataarray.py#L1425
here:
https://github.com/pydata/xarray/blob/a36d0a1d4657c848dcdd76d0ecb9c783ad464057/xarray/core/dataarray.py#L1495

Does it also work for DataSets? Then maybe add to the docstring here:

https://github.com/pydata/xarray/blob/a36d0a1d4657c848dcdd76d0ecb9c783ad464057/xarray/core/dataset.py#L2603

and here:

https://github.com/pydata/xarray/blob/a36d0a1d4657c848dcdd76d0ecb9c783ad464057/xarray/core/dataset.py#L2731","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,658938729
https://github.com/pydata/xarray/pull/4233#issuecomment-679327397,https://api.github.com/repos/pydata/xarray/issues/4233,679327397,MDEyOklzc3VlQ29tbWVudDY3OTMyNzM5Nw==,10194086,2020-08-24T19:42:16Z,2020-08-24T19:42:16Z,MEMBER,"I misremembered the behavior of the old `np.min` with datetimes - see this comment: https://github.com/pydata/xarray/pull/3924/files#discussion_r407101544

Sorry for sending you down the wrong path. I can have another look tomorrow. ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,658938729
https://github.com/pydata/xarray/pull/4233#issuecomment-678920617,https://api.github.com/repos/pydata/xarray/issues/4233,678920617,MDEyOklzc3VlQ29tbWVudDY3ODkyMDYxNw==,10194086,2020-08-24T05:59:47Z,2020-08-24T05:59:47Z,MEMBER,"Looks good - if you want to go a step further you can probably do something along the lines of (untested):

```python
if new_x.dtype in ""mM"" and LooseVersion(np.__version__) < LooseVersion(""1.18"") and new_x.isnull().any():
    raise ValueError(""numpy 1.18 or newer required to use interp with datetime/ timedelta array containing missing values"")
else:
    imin = ... np.nanmin(...)
    imax = ...
```



","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,658938729