html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/4230#issuecomment-840696698,https://api.github.com/repos/pydata/xarray/issues/4230,840696698,MDEyOklzc3VlQ29tbWVudDg0MDY5NjY5OA==,2448579,2021-05-13T17:02:54Z,2021-05-13T17:02:54Z,MEMBER,I think @tomwhite has implemented this functionality. Thanks everyone.,"{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 1, ""eyes"": 0}",,657792526
https://github.com/pydata/xarray/pull/4230#issuecomment-822119562,https://api.github.com/repos/pydata/xarray/issues/4230,822119562,MDEyOklzc3VlQ29tbWVudDgyMjExOTU2Mg==,2448579,2021-04-19T02:08:49Z,2021-04-19T02:09:37Z,MEMBER,"> I haven't implemented the nested options for display_expand - is it worth adding the extra complexity here?
Not sure :). Can you open a PR please?
EDIT: Oops you've already opened one! thanks!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,657792526
https://github.com/pydata/xarray/pull/4230#issuecomment-814255041,https://api.github.com/repos/pydata/xarray/issues/4230,814255041,MDEyOklzc3VlQ29tbWVudDgxNDI1NTA0MQ==,2448579,2021-04-06T16:24:06Z,2021-04-06T16:24:06Z,MEMBER,"> maintaining the existing behaviour, which is that for the HTML dataset repr all three sections are expanded by default,
The existing behaviour could be `""default""`, `True` could be fully expanded always; and `False` could be never expanded.
> display_expand_attrs, display_expand_coords, display_expand_data, and display_expand_data_vars f
These are a lot with potentially two more: `indexes` and `encoding`.
Should we instead do something like
``` python
xr.set_options(display_expand = {
""data_vars"": False,
""coords"": ""default"",
""attrs"": False,
})
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,657792526
https://github.com/pydata/xarray/pull/4230#issuecomment-696423758,https://api.github.com/repos/pydata/xarray/issues/4230,696423758,MDEyOklzc3VlQ29tbWVudDY5NjQyMzc1OA==,4160723,2020-09-21T23:01:09Z,2020-09-21T23:01:09Z,MEMBER,"> but I think a name like html_expand_data or html_collapse_data would be more descriptive, because this refer specifically to the ""data"" section of HTML reprs.
Do we want that this expand/collapse option affects the text repr too (i.e., collapsed = show inline values repr vs. expanded = show the whole data repr)? This might be more consistent, although obviously there's no way to interactively expand/collapse the data section in the text repr.
In that case `display_expand_data` or `display_collapse_data` would be better names (using the same prefix than the `display_style` option).","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,657792526
https://github.com/pydata/xarray/pull/4230#issuecomment-667622174,https://api.github.com/repos/pydata/xarray/issues/4230,667622174,MDEyOklzc3VlQ29tbWVudDY2NzYyMjE3NA==,1217238,2020-08-02T03:45:40Z,2020-08-02T03:45:40Z,MEMBER,"The scope is limited enough here that it would be fine to include the
cleanup in this PR. The bigger issue is that names exposed in a public API
need to be chosen much more carefully than internal only names — and we
definitely don’t want to expose the current poorly chosen internal name for
this feature to users.
On Sat, Aug 1, 2020 at 7:32 PM Michael Aye wrote:
> i'm fine in fixing the name of the variable, but usually open source teams
> don't want a PR that addresses more than one issue at a time, are you sure
> you want it in here?
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> , or
> unsubscribe
>
> .
>
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,657792526
https://github.com/pydata/xarray/pull/4230#issuecomment-667601315,https://api.github.com/repos/pydata/xarray/issues/4230,667601315,MDEyOklzc3VlQ29tbWVudDY2NzYwMTMxNQ==,1217238,2020-08-01T23:48:07Z,2020-08-01T23:48:07Z,MEMBER,"I support adding an option for this, but I think a name like `html_expand_data` or `html_collapse_data` would be more descriptive, because this refer specifically to the ""data"" section of HTML reprs.
I also agree with @jsignell that the current naming seems to be reversed ""expanded"" should mean show the data section and ""collapsed"" should mean hiding it.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,657792526