html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/4103#issuecomment-639750328,https://api.github.com/repos/pydata/xarray/issues/4103,639750328,MDEyOklzc3VlQ29tbWVudDYzOTc1MDMyOA==,2448579,2020-06-05T19:39:14Z,2020-06-05T19:39:14Z,MEMBER,Thanks @OriolAbril . I see this is your first PR. Thanks!,"{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 1, ""eyes"": 0}",,626215981
https://github.com/pydata/xarray/pull/4103#issuecomment-636076408,https://api.github.com/repos/pydata/xarray/issues/4103,636076408,MDEyOklzc3VlQ29tbWVudDYzNjA3NjQwOA==,2448579,2020-05-29T16:52:47Z,2020-05-29T16:52:47Z,MEMBER,Thanks @OriolAbril . This looks good to me. Can you add a note under enhancements in `whats-new.rst`?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,626215981
https://github.com/pydata/xarray/pull/4103#issuecomment-635410791,https://api.github.com/repos/pydata/xarray/issues/4103,635410791,MDEyOklzc3VlQ29tbWVudDYzNTQxMDc5MQ==,2448579,2020-05-28T15:10:15Z,2020-05-28T15:10:15Z,MEMBER,Modified test sounds good to me. I'll open another issue.,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,626215981
https://github.com/pydata/xarray/pull/4103#issuecomment-635398749,https://api.github.com/repos/pydata/xarray/issues/4103,635398749,MDEyOklzc3VlQ29tbWVudDYzNTM5ODc0OQ==,2448579,2020-05-28T14:49:52Z,2020-05-28T14:49:52Z,MEMBER,"Nice job @OriolAbril! you seem to have found a bug where renaming doesn't create an `IndexVariable` when necessary. I will look into this.

```
__________________ TestDataArray.test_reset_index_keep_attrs ___________________

self = <xarray.tests.test_dataarray.TestDataArray object at 0x7f266d36c4d0>

    def test_reset_index_keep_attrs(self):
        coord_1 = xr.DataArray([1, 2], dims=[""coord_1""], attrs={""attrs"": True})
        da = xr.DataArray([1, 0], [coord_1])
        obj = da.reset_index(""coord_1"").rename({""coord_1_"": ""coord_1""})
>       assert_identical(da, obj)

xarray/tests/test_dataarray.py:1837: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
xarray/testing.py:267: in _assert_internal_invariants
    _assert_dataarray_invariants(xarray_obj)
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

da = <xarray.DataArray (coord_1: 2)>
array([1, 0])
Coordinates:
  * coord_1  (coord_1) int64 1 2

    def _assert_dataarray_invariants(da: DataArray):
        assert isinstance(da._variable, Variable), da._variable
        _assert_variable_invariants(da._variable)
    
        assert isinstance(da._coords, dict), da._coords
        assert all(isinstance(v, Variable) for v in da._coords.values()), da._coords
        assert all(set(v.dims) <= set(da.dims) for v in da._coords.values()), (
            da.dims,
            {k: v.dims for k, v in da._coords.items()},
        )
        assert all(
            isinstance(v, IndexVariable) for (k, v) in da._coords.items() if v.dims == (k,)
>       ), {k: type(v) for k, v in da._coords.items()}
E       AssertionError: {'coord_1': <class 'xarray.core.variable.Variable'>}

```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,626215981