html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3847#issuecomment-643496930,https://api.github.com/repos/pydata/xarray/issues/3847,643496930,MDEyOklzc3VlQ29tbWVudDY0MzQ5NjkzMA==,14808389,2020-06-12T21:49:47Z,2020-06-12T21:50:02Z,MEMBER,"I think we could bump the version even further (at least to `2.8`, maybe also `2.9`) so that should probably be a different PR","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,577425749
https://github.com/pydata/xarray/pull/3847#issuecomment-643448649,https://api.github.com/repos/pydata/xarray/issues/3847,643448649,MDEyOklzc3VlQ29tbWVudDY0MzQ0ODY0OQ==,14808389,2020-06-12T19:31:37Z,2020-06-12T19:31:37Z,MEMBER,unless there are any objections (@shoyer?) I'm going to merge this tomorrow.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,577425749
https://github.com/pydata/xarray/pull/3847#issuecomment-636833504,https://api.github.com/repos/pydata/xarray/issues/3847,636833504,MDEyOklzc3VlQ29tbWVudDYzNjgzMzUwNA==,14808389,2020-06-01T12:31:20Z,2020-06-01T12:31:20Z,MEMBER,"gentle ping, @shoyer","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,577425749
https://github.com/pydata/xarray/pull/3847#issuecomment-634888639,https://api.github.com/repos/pydata/xarray/issues/3847,634888639,MDEyOklzc3VlQ29tbWVudDYzNDg4ODYzOQ==,14808389,2020-05-27T19:23:30Z,2020-05-27T19:24:14Z,MEMBER,"anyway, with this the tests finally pass :tada: so this should be ready for review and merging.","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 1, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,577425749
https://github.com/pydata/xarray/pull/3847#issuecomment-634876945,https://api.github.com/repos/pydata/xarray/issues/3847,634876945,MDEyOklzc3VlQ29tbWVudDYzNDg3Njk0NQ==,14808389,2020-05-27T19:04:40Z,2020-05-27T19:04:40Z,MEMBER,"then it seems that this PR removes this intentional restriction. I'm not sure it is still needed, though: we don't use `np.testing.assert_allclose` internally because we want to provide our own error messages, and the actual comparison is done with https://github.com/pydata/xarray/blob/e5cc19cd8f8a69e0743f230f5bf51b7778a0ff96/xarray/core/duck_array_ops.py#L204
which should allow dispatching","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,577425749
https://github.com/pydata/xarray/pull/3847#issuecomment-634867837,https://api.github.com/repos/pydata/xarray/issues/3847,634867837,MDEyOklzc3VlQ29tbWVudDYzNDg2NzgzNw==,14808389,2020-05-27T18:48:15Z,2020-05-27T18:48:15Z,MEMBER,"hmm... using `arr.compute()` fails while `np.array(arr)` works. For now, I'm converting all dask arrays to numpy if the dask version is not high enough (I can't do that only for `bool_` arrays since they have been converted to float somewhere).

@shoyer: I'm confused, I thought that `xr.testing.assert_allclose` explicitly supported duck arrays (it calls `duck_array_ops.allclose_or_equiv`). TBC, what I was talking about was these lines:
https://github.com/pydata/xarray/blob/e5cc19cd8f8a69e0743f230f5bf51b7778a0ff96/xarray/testing.py#L124
https://github.com/pydata/xarray/blob/e5cc19cd8f8a69e0743f230f5bf51b7778a0ff96/xarray/testing.py#L132-L135
where the `.values` always convert to `numpy`","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,577425749
https://github.com/pydata/xarray/pull/3847#issuecomment-634826398,https://api.github.com/repos/pydata/xarray/issues/3847,634826398,MDEyOklzc3VlQ29tbWVudDYzNDgyNjM5OA==,14808389,2020-05-27T17:39:51Z,2020-05-27T17:39:51Z,MEMBER,let's see if that works,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,577425749
https://github.com/pydata/xarray/pull/3847#issuecomment-634611339,https://api.github.com/repos/pydata/xarray/issues/3847,634611339,MDEyOklzc3VlQ29tbWVudDYzNDYxMTMzOQ==,14808389,2020-05-27T11:57:18Z,2020-05-27T11:57:18Z,MEMBER,"I needed to use `assert_allclose` in the `pint` tests in #3975, so I modified it to use `.data` instead of `.values` and now the exact same tests are failing. So it seems that `assert_allclose` never worked with `dask` but always converted to `numpy`. Would it make sense to investigate further, or is it better to just wait until we can merge this?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,577425749
https://github.com/pydata/xarray/pull/3847#issuecomment-628185474,https://api.github.com/repos/pydata/xarray/issues/3847,628185474,MDEyOklzc3VlQ29tbWVudDYyODE4NTQ3NA==,14808389,2020-05-13T19:03:14Z,2020-05-13T19:03:14Z,MEMBER,"Unfortunately, simply replacing `assert np.allclose(...)` with `np.testing.assert_allclose(...)` does not fix this. Also, I undid the swapping of arguments to `allclose_or_equiv` which makes the `min-all-deps` CI fail, too. Does anyone know why that works?

Would it make sense to wait until we can bump the dask version to `2.9`?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,577425749
https://github.com/pydata/xarray/pull/3847#issuecomment-625554011,https://api.github.com/repos/pydata/xarray/issues/3847,625554011,MDEyOklzc3VlQ29tbWVudDYyNTU1NDAxMQ==,14808389,2020-05-07T23:52:27Z,2020-05-08T00:39:31Z,MEMBER,"@pydata/xarray, this is really close but I'm not familiar enough with `dask` to get it to work with `dask<2.9.1`.

Once we get the `py36-min-all-deps` and `py36-min-nep18` CI to pass, this should be ready for a final review and merging.

Edit: there seem to be a few failing tests related to `pint` (I will fix those) but the tests in question are in `test_duck_array_ops.py` and only fail with `py36-min-nep18`.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,577425749
https://github.com/pydata/xarray/pull/3847#issuecomment-604749478,https://api.github.com/repos/pydata/xarray/issues/3847,604749478,MDEyOklzc3VlQ29tbWVudDYwNDc0OTQ3OA==,14808389,2020-03-27T00:10:27Z,2020-03-27T00:10:27Z,MEMBER,"The issue is with how `dask<2.9.1` handles dtypes on compute (in `nanvar`?) when the data is an array with dtype `object` filled with `False` and some missing values represented by `np.nan`.

I really lack experience with `dask`, though, so I'm clueless as to what to do to fix that (besides calling `compute` before passing to `allclose_or_equiv`) and would appreciate help with this.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,577425749
https://github.com/pydata/xarray/pull/3847#issuecomment-601350745,https://api.github.com/repos/pydata/xarray/issues/3847,601350745,MDEyOklzc3VlQ29tbWVudDYwMTM1MDc0NQ==,14808389,2020-03-19T18:40:41Z,2020-03-19T18:40:41Z,MEMBER,"unfortunately, we need `dask>=2.9.1` for that. I could try debugging a bit more to find out exactly why it fails (or someone helps me with that?), but that would take me a bit more time than just skipping / xfailing those tests if on `dask<2.9.1`.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,577425749
https://github.com/pydata/xarray/pull/3847#issuecomment-601288023,https://api.github.com/repos/pydata/xarray/issues/3847,601288023,MDEyOklzc3VlQ29tbWVudDYwMTI4ODAyMw==,14808389,2020-03-19T16:46:49Z,2020-03-19T16:49:31Z,MEMBER,"to me the failing tests on the `min-all-deps` and `min-nep18` CI seem like a `dask` issue (in `var`?) that has been resolved in later versions: if we compute `actual` before passing it to `assert_allclose` the tests don't fail. How should I resolve this?

Also, where should I put the `whats-new.rst` entry?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,577425749
https://github.com/pydata/xarray/pull/3847#issuecomment-596516918,https://api.github.com/repos/pydata/xarray/issues/3847,596516918,MDEyOklzc3VlQ29tbWVudDU5NjUxNjkxOA==,14808389,2020-03-09T13:15:24Z,2020-03-09T13:15:24Z,MEMBER,now only the `min-all-deps` and `min-nep18` CI fail. I suspect that is due to the pinned dependencies.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,577425749
https://github.com/pydata/xarray/pull/3847#issuecomment-596256394,https://api.github.com/repos/pydata/xarray/issues/3847,596256394,MDEyOklzc3VlQ29tbWVudDU5NjI1NjM5NA==,14808389,2020-03-08T21:44:30Z,2020-03-08T21:44:30Z,MEMBER,the failures should be a bug in `pint` and hopefully fixed by hgrecco/pint#1044,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,577425749