html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/3660#issuecomment-576794699,https://api.github.com/repos/pydata/xarray/issues/3660,576794699,MDEyOklzc3VlQ29tbWVudDU3Njc5NDY5OQ==,1217238,2020-01-21T17:37:45Z,2020-01-21T17:37:45Z,MEMBER,"OK great! Looks good to me! On Tue, Jan 21, 2020 at 9:32 AM Deepak Cherian wrote: > *@dcherian* commented on this pull request. > ------------------------------ > > In xarray/tests/test_sparse.py > : > > > @@ -873,3 +873,16 @@ def test_dask_token(): > t5 = dask.base.tokenize(ac + 1) > assert t4 != t5 > assert isinstance(ac.data._meta, sparse.COO) > + > + > +@requires_dask > > There's a importorskip(""sparse"") on top so I think this is fine > > — > You are receiving this because you commented. > Reply to this email directly, view it on GitHub > , > or unsubscribe > > . > ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,544661257 https://github.com/pydata/xarray/pull/3660#issuecomment-576117204,https://api.github.com/repos/pydata/xarray/issues/3660,576117204,MDEyOklzc3VlQ29tbWVudDU3NjExNzIwNA==,1217238,2020-01-20T05:49:33Z,2020-01-20T05:49:33Z,MEMBER,"This looks like an dask bug that we fixed a somewhat recently (6 months ago?). I wouldn’t worry about it too much about it. Supporting old versions of dependencies is a best effort, not a mandate. I would just skip it on old versions of dask and move on.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,544661257