html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/3654#issuecomment-574754400,https://api.github.com/repos/pydata/xarray/issues/3654,574754400,MDEyOklzc3VlQ29tbWVudDU3NDc1NDQwMA==,14808389,2020-01-15T16:59:00Z,2020-01-15T16:59:00Z,MEMBER,"thanks for the review, @dcherian","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,543276677 https://github.com/pydata/xarray/pull/3654#issuecomment-574740754,https://api.github.com/repos/pydata/xarray/issues/3654,574740754,MDEyOklzc3VlQ29tbWVudDU3NDc0MDc1NA==,14808389,2020-01-15T16:31:07Z,2020-01-15T16:31:07Z,MEMBER,I'll merge once the tests pass.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,543276677 https://github.com/pydata/xarray/pull/3654#issuecomment-572318759,https://api.github.com/repos/pydata/xarray/issues/3654,572318759,MDEyOklzc3VlQ29tbWVudDU3MjMxODc1OQ==,14808389,2020-01-09T00:09:47Z,2020-01-09T00:09:47Z,MEMBER,this should probably be merged before any of the other related PRs,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,543276677 https://github.com/pydata/xarray/pull/3654#issuecomment-572317802,https://api.github.com/repos/pydata/xarray/issues/3654,572317802,MDEyOklzc3VlQ29tbWVudDU3MjMxNzgwMg==,14808389,2020-01-09T00:06:02Z,2020-01-09T00:06:02Z,MEMBER,the test failures are due to the pint update which means they should not be related. I'll mark them as xfail and fix them in the appropriate PR (#3611 for the `apply_ufunc` failures and the `Dataset` PR I will open once all `Variable` and `DataArray` tests are passing for the `to_stacked_array` failures),"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,543276677 https://github.com/pydata/xarray/pull/3654#issuecomment-572309210,https://api.github.com/repos/pydata/xarray/issues/3654,572309210,MDEyOklzc3VlQ29tbWVudDU3MjMwOTIxMA==,14808389,2020-01-08T23:32:53Z,2020-01-08T23:37:30Z,MEMBER,"this should be ready for review and merge. --- Also, I found a few issues that I'm posting here so I won't forget about them: * documentation: - the examples of `Variable.rolling_window` pass a variable `x` that is not set anywhere and would change the results - the docstring of `set_dims` is quite confusing (to me, at least), it does not mention the `shape` parameter (which would be the same as passing a dictionary with values `dict(zip(dims, shape))` to `dims`) or that broadcasting is used to expand if necessary (so no reshaping). * code: `pad_with_fill_value` seems to implement pad for dask arrays for all versions of dask, but at least for recent versions we should rely dask's implementation instead I can update the documentation, but I'd leave the revisiting of the dask issues (there are a lot of them) to someone else.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,543276677