html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/3631#issuecomment-578505415,https://api.github.com/repos/pydata/xarray/issues/3631,578505415,MDEyOklzc3VlQ29tbWVudDU3ODUwNTQxNQ==,6628425,2020-01-26T14:10:54Z,2020-01-26T14:10:54Z,MEMBER,Thanks @huard!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,538620718 https://github.com/pydata/xarray/pull/3631#issuecomment-578322789,https://api.github.com/repos/pydata/xarray/issues/3631,578322789,MDEyOklzc3VlQ29tbWVudDU3ODMyMjc4OQ==,6628425,2020-01-24T22:13:11Z,2020-01-24T22:13:11Z,MEMBER,"Indeed thanks @huard -- I'll give this another once-over tomorrow. If everything checks out, which I anticipate it will, I'll merge it then.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,538620718 https://github.com/pydata/xarray/pull/3631#issuecomment-578272334,https://api.github.com/repos/pydata/xarray/issues/3631,578272334,MDEyOklzc3VlQ29tbWVudDU3ODI3MjMzNA==,6628425,2020-01-24T19:41:15Z,2020-01-24T19:41:15Z,MEMBER,"> It seems like `assert_allclose` doesn't like nans. Other suggestion ? Hmm...I think it should treat NaNs as equal by default. Are you using the version defined here? https://github.com/pydata/xarray/blob/ecd67f457240db5bc3316c092ca0bb3a134b4239/xarray/tests/__init__.py#L170","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,538620718