html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/3595#issuecomment-561819897,https://api.github.com/repos/pydata/xarray/issues/3595,561819897,MDEyOklzc3VlQ29tbWVudDU2MTgxOTg5Nw==,2448579,2019-12-04T20:13:57Z,2019-12-04T20:13:57Z,MEMBER,"I think that it's sensible that `keep_attrs` controls whether individual variable attrs are kept after mapping a function on each variable.

This is a behaviour change though. I'm not sure how to deal with that.

cc @max-sixty ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,532878771
https://github.com/pydata/xarray/issues/3595#issuecomment-561810709,https://api.github.com/repos/pydata/xarray/issues/3595,561810709,MDEyOklzc3VlQ29tbWVudDU2MTgxMDcwOQ==,2448579,2019-12-04T19:49:00Z,2019-12-04T19:52:10Z,MEMBER,"Looking at the code, `keep_attrs` controls whether the dataset attrs are kept, not the invidual variable attrs.

https://github.com/pydata/xarray/blob/577d3a75ea8bb25b99f9d31af8da14210cddff78/xarray/core/dataset.py#L4233-L4240

This may be fixable by threading keep_attrs down through `maybe_wrap_array` and then ultimately to `Variable.__array_wrap__` when you can choose to keep attrs if `keep_attrs is True`.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,532878771