html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3502#issuecomment-553680297,https://api.github.com/repos/pydata/xarray/issues/3502,553680297,MDEyOklzc3VlQ29tbWVudDU1MzY4MDI5Nw==,5635139,2019-11-14T01:22:57Z,2019-11-14T01:22:57Z,MEMBER,Thanks @andersy005 !,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,520306672
https://github.com/pydata/xarray/pull/3502#issuecomment-553009531,https://api.github.com/repos/pydata/xarray/issues/3502,553009531,MDEyOklzc3VlQ29tbWVudDU1MzAwOTUzMQ==,2448579,2019-11-12T17:48:30Z,2019-11-12T17:48:30Z,MEMBER,Let's do bug fixes,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,520306672
https://github.com/pydata/xarray/pull/3502#issuecomment-553008854,https://api.github.com/repos/pydata/xarray/issues/3502,553008854,MDEyOklzc3VlQ29tbWVudDU1MzAwODg1NA==,13301940,2019-11-12T17:47:11Z,2019-11-12T17:47:11Z,MEMBER,"@dcherian & @shoyer, thank you both for your help! 

In which section(bug fixes? enhancements?) in `whats-new.rst` should I document these changes?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,520306672
https://github.com/pydata/xarray/pull/3502#issuecomment-552744698,https://api.github.com/repos/pydata/xarray/issues/3502,552744698,MDEyOklzc3VlQ29tbWVudDU1Mjc0NDY5OA==,13301940,2019-11-12T05:47:26Z,2019-11-12T05:47:26Z,MEMBER,"@dcherian, 

> You'll have to convert back from the numpy array before exiting that function.

I was able to address this using @shoyer's suggestion above.  ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,520306672
https://github.com/pydata/xarray/pull/3502#issuecomment-552493241,https://api.github.com/repos/pydata/xarray/issues/3502,552493241,MDEyOklzc3VlQ29tbWVudDU1MjQ5MzI0MQ==,2448579,2019-11-11T15:34:55Z,2019-11-11T15:34:55Z,MEMBER,"Thanks for taking this on, Anderson.

You'll have to convert back from the numpy array before exiting that function. It may be simpler if you avoid the cast and just keep the change from `equivalent` to `allclose_or_equiv`.

For reference, here's how xarray determines `dtype` for netCDF4
https://github.com/pydata/xarray/blob/4e9240a2087ffbf119919e1ac98046bbf164f94d/xarray/backends/netCDF4_.py#L131-L141

(I found this by working looking for the `createVariable` statement here)
https://github.com/pydata/xarray/blob/4e9240a2087ffbf119919e1ac98046bbf164f94d/xarray/backends/netCDF4_.py#L439-L485
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,520306672
https://github.com/pydata/xarray/pull/3502#issuecomment-552049679,https://api.github.com/repos/pydata/xarray/issues/3502,552049679,MDEyOklzc3VlQ29tbWVudDU1MjA0OTY3OQ==,13301940,2019-11-09T01:13:22Z,2019-11-09T01:21:27Z,MEMBER,"@dcherian, what is the right way to do the type casting in `encode()`?

I thought of trying something along these lines:

```python
encoding[""missing_value""] = encoding[""missing_value""].astype(data.dtype)
```
However, I quickly realized that this breaks when `encoding[""missing_value""]` is not a numpy object. 


EDIT:

I will try using `np.asarray()`:

```python
encoding[""missing_value""] = np.asarray(encoding[""missing_value""]).astype(data.dtype)
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,520306672