html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3302#issuecomment-554389294,https://api.github.com/repos/pydata/xarray/issues/3302,554389294,MDEyOklzc3VlQ29tbWVudDU1NDM4OTI5NA==,2448579,2019-11-15T14:53:12Z,2019-11-15T14:53:12Z,MEMBER,I'm going to merge this. Happy to make any other changes.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,492866552
https://github.com/pydata/xarray/pull/3302#issuecomment-549561349,https://api.github.com/repos/pydata/xarray/issues/3302,549561349,MDEyOklzc3VlQ29tbWVudDU0OTU2MTM0OQ==,2448579,2019-11-04T21:44:49Z,2019-11-04T21:44:49Z,MEMBER,"This could use another round of testing / review
(cc @dnowacki-usgs @stefraynaud @max-sixty )","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,492866552
https://github.com/pydata/xarray/pull/3302#issuecomment-545009960,https://api.github.com/repos/pydata/xarray/issues/3302,545009960,MDEyOklzc3VlQ29tbWVudDU0NTAwOTk2MA==,2448579,2019-10-22T15:10:19Z,2019-11-04T21:44:07Z,MEMBER,"Thanks @dnowacki-usgs that's a nice test. I think the right fix is to make `index` a `Variable` so that we get automatic broadcasting.
Things left to do (or at least add xfail tests + errors):
- [x] support for cftime indexes and offsets
- [x] what to do when `use_coordinate=False`
- [x] what to do with unlabeled dimensions
- [x] document convention for gap length
- [x] add examples to docs","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,492866552
https://github.com/pydata/xarray/pull/3302#issuecomment-546395069,https://api.github.com/repos/pydata/xarray/issues/3302,546395069,MDEyOklzc3VlQ29tbWVudDU0NjM5NTA2OQ==,2448579,2019-10-25T15:14:51Z,2019-10-25T15:14:51Z,MEMBER,Done for now. Ready for final review / testing.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,492866552
https://github.com/pydata/xarray/pull/3302#issuecomment-532257718,https://api.github.com/repos/pydata/xarray/issues/3302,532257718,MDEyOklzc3VlQ29tbWVudDUzMjI1NzcxOA==,2448579,2019-09-17T14:53:52Z,2019-09-17T14:53:52Z,MEMBER,"yes, I think you are right. I was thinking that it would be nice to have the number-of-nan-points and gap-length metrics converge for uniformly spaced coordinates but I don't think that's possible in any sensible way.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,492866552
https://github.com/pydata/xarray/pull/3302#issuecomment-531807552,https://api.github.com/repos/pydata/xarray/issues/3302,531807552,MDEyOklzc3VlQ29tbWVudDUzMTgwNzU1Mg==,2448579,2019-09-16T14:39:41Z,2019-09-16T14:39:41Z,MEMBER,"The thing I find weird is that for
```
array([nan, nan, nan, 1., nan, nan, 4., nan, nan])
Coordinates:
* y (y) int64 0 1 2 3 4 5 6 7 8
```
the center gap's length = `7-4 = 3` which is the number of NaNs + 1. But maybe this is OK.
1. We should check what that pandas PR does and align with that
2. `interp` calls `scipy.interpolate.interp` which does do extrapolation, so we should figure out a sensible solution for the edges (extrapolating coordinates using the first and last spacing seems reasonable to me).
@stefraynaud I don't have time to work on this now. Please feel free to modify this and open a new PR. You could try to push to this branch but I'm not sure it will work.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,492866552
https://github.com/pydata/xarray/pull/3302#issuecomment-531294795,https://api.github.com/repos/pydata/xarray/issues/3302,531294795,MDEyOklzc3VlQ29tbWVudDUzMTI5NDc5NQ==,2448579,2019-09-13T16:00:33Z,2019-09-13T16:00:33Z,MEMBER,OK added test and now raises error for irregularly spaced coordinates. I agree that this should be good for now.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,492866552
https://github.com/pydata/xarray/pull/3302#issuecomment-531283688,https://api.github.com/repos/pydata/xarray/issues/3302,531283688,MDEyOklzc3VlQ29tbWVudDUzMTI4MzY4OA==,2448579,2019-09-13T15:29:34Z,2019-09-13T15:29:34Z,MEMBER,"Thanks @stefraynaud . I'm having trouble figuring out defining the length of a gap in the irregular coordinate case.
e.g.
```
da4 = xr.DataArray([np.nan, np.nan, np.nan, 1, np.nan, np.nan, 4, np.nan, np.nan],
dims=[""y""], coords={""y"": [0, 2, 5, 6, 7, 8, 10, 12, 14]})
```
```
array([nan, nan, nan, 1., nan, nan, 4., nan, nan])
Coordinates:
* y (y) int64 0 2 5 6 7 8 10 12 14
```
What is the length of these three gaps given that xarray doesn't have any understanding of grids?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,492866552
https://github.com/pydata/xarray/pull/3302#issuecomment-531080613,https://api.github.com/repos/pydata/xarray/issues/3302,531080613,MDEyOklzc3VlQ29tbWVudDUzMTA4MDYxMw==,2448579,2019-09-13T03:00:42Z,2019-09-13T03:00:42Z,MEMBER,":+1:
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,492866552
https://github.com/pydata/xarray/pull/3302#issuecomment-530890655,https://api.github.com/repos/pydata/xarray/issues/3302,530890655,MDEyOklzc3VlQ29tbWVudDUzMDg5MDY1NQ==,2448579,2019-09-12T15:55:49Z,2019-09-12T15:55:49Z,MEMBER,"Thanks @max-sixty I've updated the tests.
> Any thoughts on maxgap? limit_gap? Neither clicks that well!
I pulled `maxgap` from this ~stalled~ Pandas PR: https://github.com/pandas-dev/pandas/pull/25141
OK it looks like that PR is alive again, so maybe it's good to keep the same kwarg? ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,492866552