html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3250#issuecomment-526280260,https://api.github.com/repos/pydata/xarray/issues/3250,526280260,MDEyOklzc3VlQ29tbWVudDUyNjI4MDI2MA==,1217238,2019-08-29T17:17:19Z,2019-08-29T17:17:19Z,MEMBER,thanks @crusaderky !,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,484499801
https://github.com/pydata/xarray/pull/3250#issuecomment-524456563,https://api.github.com/repos/pydata/xarray/issues/3250,524456563,MDEyOklzc3VlQ29tbWVudDUyNDQ1NjU2Mw==,1217238,2019-08-23T20:45:45Z,2019-08-23T20:45:45Z,MEMBER,"We definitely do not guarantee implementation details like xarray objects
having a __dict__. A warning for subclasses is already going above and
beyond IMO.

On Fri, Aug 23, 2019 at 2:42 PM crusaderky <notifications@github.com> wrote:

> @max-sixty <https://github.com/max-sixty> any package that for any reason
> expects xarray objects to have a __dict__ will break overnight. Any
> package that subclasses from xarray will get a warning.
>
> —
> You are receiving this because your review was requested.
> Reply to this email directly, view it on GitHub
> <https://github.com/pydata/xarray/pull/3250?email_source=notifications&email_token=AAJJFVUD2QSIIOF5DHLCGUTQGBDR5A5CNFSM4IO7AUA2YY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD5BI4IA#issuecomment-524455456>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AAJJFVUYHG37O2SWYURYRDDQGBDR5ANCNFSM4IO7AUAQ>
> .
>
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,484499801