html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3238#issuecomment-542979204,https://api.github.com/repos/pydata/xarray/issues/3238,542979204,MDEyOklzc3VlQ29tbWVudDU0Mjk3OTIwNA==,5635139,2019-10-17T03:14:06Z,2019-10-17T03:14:06Z,MEMBER,Great! Quite an effort @keewis —thank you!,"{""total_count"": 3, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 3, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,484015016
https://github.com/pydata/xarray/pull/3238#issuecomment-542938278,https://api.github.com/repos/pydata/xarray/issues/3238,542938278,MDEyOklzc3VlQ29tbWVudDU0MjkzODI3OA==,5635139,2019-10-16T23:56:26Z,2019-10-16T23:56:26Z,MEMBER,"I think these tests are unrelated and we can merge?

```python


=================================== FAILURES ===================================
_________________________ test_datetime_reduce[False] __________________________

dask = False

    @arm_xfail
    @pytest.mark.parametrize(""dask"", [False, True])
    def test_datetime_reduce(dask):
        time = np.array(pd.date_range(""15/12/1999"", periods=11))
        time[8:11] = np.nan
        da = DataArray(np.linspace(0, 365, num=11), dims=""time"", coords={""time"": time})
    
        if dask and has_dask:
            chunks = {""time"": 5}
            da = da.chunk(chunks)
    
        actual = da[""time""].mean()
>       assert not pd.isnull(actual)
E       AssertionError: assert not True
E        +  where True = <function isna at 0x7fcbdefdbae8>(<xarray.DataArray 'time' ()>\narray('NaT', dtype='datetime64[ns]'))
E        +    where <function isna at 0x7fcbdefdbae8> = pd.isnull

xarray/tests/test_duck_array_ops.py:288: AssertionError
__________________________ test_datetime_reduce[True] __________________________

dask = True

    @arm_xfail
    @pytest.mark.parametrize(""dask"", [False, True])
    def test_datetime_reduce(dask):
        time = np.array(pd.date_range(""15/12/1999"", periods=11))
        time[8:11] = np.nan
        da = DataArray(np.linspace(0, 365, num=11), dims=""time"", coords={""time"": time})
    
        if dask and has_dask:
            chunks = {""time"": 5}
            da = da.chunk(chunks)
    
        actual = da[""time""].mean()
>       assert not pd.isnull(actual)
E       AssertionError: assert not True
E        +  where True = <function isna at 0x7fcbdefdbae8>(<xarray.DataArray 'time' ()>\narray('NaT', dtype='datetime64[ns]'))
E        +    where <function isna at 0x7fcbdefdbae8> = pd.isnull
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,484015016
https://github.com/pydata/xarray/pull/3238#issuecomment-542913779,https://api.github.com/repos/pydata/xarray/issues/3238,542913779,MDEyOklzc3VlQ29tbWVudDU0MjkxMzc3OQ==,5635139,2019-10-16T22:14:56Z,2019-10-16T22:14:56Z,MEMBER,"> Added integration tests against `pint <https://pint.readthedocs.io/>`_.  Note that these tests currently require a special version of pint to run *and are otherwise skipped*. Also note that at the moment of writing, there are issues when pint interacts with non-numpy array libraries, e.g. dask or sparse.

(remove emphasis in actual version)

> readers will be much more interested in what they can actually do with pint

👍 , let's add a sentence","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,484015016
https://github.com/pydata/xarray/pull/3238#issuecomment-542416181,https://api.github.com/repos/pydata/xarray/issues/3238,542416181,MDEyOklzc3VlQ29tbWVudDU0MjQxNjE4MQ==,5635139,2019-10-15T21:38:43Z,2019-10-15T21:38:43Z,MEMBER,OK great! @crusaderky any final thoughts? Anyone else?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,484015016
https://github.com/pydata/xarray/pull/3238#issuecomment-542391175,https://api.github.com/repos/pydata/xarray/issues/3238,542391175,MDEyOklzc3VlQ29tbWVudDU0MjM5MTE3NQ==,5635139,2019-10-15T20:30:30Z,2019-10-15T20:30:30Z,MEMBER,"> I assumed this to be the same as datetime, which means object labels instead of strings. So now only the top-level functions and dataset are missing.

👍 ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,484015016
https://github.com/pydata/xarray/pull/3238#issuecomment-533181017,https://api.github.com/repos/pydata/xarray/issues/3238,533181017,MDEyOklzc3VlQ29tbWVudDUzMzE4MTAxNw==,5635139,2019-09-19T15:20:01Z,2019-09-19T15:20:01Z,MEMBER,"In general we've tried to make `identical` as exactly identical, including types etc, so I think different units would return `False` there","{""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,484015016
https://github.com/pydata/xarray/pull/3238#issuecomment-523926972,https://api.github.com/repos/pydata/xarray/issues/3238,523926972,MDEyOklzc3VlQ29tbWVudDUyMzkyNjk3Mg==,5635139,2019-08-22T14:19:37Z,2019-08-22T14:19:37Z,MEMBER,"Great! This is going to be exciting. Ping here for any questions!

> From what is already done, `mypy .` fails because of `pint` (this the same as with `quantities` in #2956). What would I do to fix that?

V easy - add to `setup.cfg` like other libraries listed there","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,484015016