html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3142#issuecomment-519683957,https://api.github.com/repos/pydata/xarray/issues/3142,519683957,MDEyOklzc3VlQ29tbWVudDUxOTY4Mzk1Nw==,5635139,2019-08-08T20:55:14Z,2019-08-08T20:55:14Z,MEMBER,"Please ping here / tag me on the relevant PR with any issues, and I'll help!","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,469871658
https://github.com/pydata/xarray/pull/3142#issuecomment-519678389,https://api.github.com/repos/pydata/xarray/issues/3142,519678389,MDEyOklzc3VlQ29tbWVudDUxOTY3ODM4OQ==,5635139,2019-08-08T20:37:26Z,2019-08-08T20:37:26Z,MEMBER,"OK - going to hit the button as soon as tests pass.
🙏 ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,469871658
https://github.com/pydata/xarray/pull/3142#issuecomment-519627371,https://api.github.com/repos/pydata/xarray/issues/3142,519627371,MDEyOklzc3VlQ29tbWVudDUxOTYyNzM3MQ==,2448579,2019-08-08T18:06:04Z,2019-08-08T18:06:04Z,MEMBER,"
:exclamation:
","{""total_count"": 1, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 1}",,469871658
https://github.com/pydata/xarray/pull/3142#issuecomment-519624476,https://api.github.com/repos/pydata/xarray/issues/3142,519624476,MDEyOklzc3VlQ29tbWVudDUxOTYyNDQ3Ng==,5635139,2019-08-08T17:58:09Z,2019-08-08T17:58:09Z,MEMBER,"@pydata/xarray this is ready to go!
Any final comments / thoughts / feedback?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,469871658
https://github.com/pydata/xarray/pull/3142#issuecomment-519238589,https://api.github.com/repos/pydata/xarray/issues/3142,519238589,MDEyOklzc3VlQ29tbWVudDUxOTIzODU4OQ==,5635139,2019-08-07T19:33:04Z,2019-08-07T19:33:04Z,MEMBER,"> On a different note, have you considered adding the pyupgrade and autoflake8 autoformatters?
Nice, I didn't know those. I had use `autopep8` before. `isort` is another I use a lot.
> +1, but let's avoid bloating and leave it for a later PR
Yeah - not sure of the balance here.
I think the focus should be on easy initial contributions. Consistent formatting is helpful in reading and reviewing code, and eliminating any formatting iterations.
Each extra tool's benefit needs to be weighed against the startup cost of another install - unless there's a way of eliminating that (e.g. I've seen some bots add the code changes from GH)
An alternative is to run those additional tools across the whole codebase on occasion, assuming this doesn't create too many merge conflicts.
Interested in others' thoughts... (but probably for another PR)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,469871658
https://github.com/pydata/xarray/pull/3142#issuecomment-519026245,https://api.github.com/repos/pydata/xarray/issues/3142,519026245,MDEyOklzc3VlQ29tbWVudDUxOTAyNjI0NQ==,6213168,2019-08-07T09:49:17Z,2019-08-07T09:49:17Z,MEMBER,"I did a manual pass of pyupgrade (#3190), and it looks good.
+1, but let's avoid bloating and leave it for a later PR","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,469871658
https://github.com/pydata/xarray/pull/3142#issuecomment-518373612,https://api.github.com/repos/pydata/xarray/issues/3142,518373612,MDEyOklzc3VlQ29tbWVudDUxODM3MzYxMg==,1217238,2019-08-05T19:48:44Z,2019-08-05T19:48:44Z,MEMBER,"Let's do it after merging #2277
On Mon, Aug 5, 2019 at 11:17 AM Maximilian Roos
wrote:
> What are people's thoughts on doing this now? There are a few big merges
> happening atm, so could do this after those.
>
> I tested the approach above
> and
> it worked well. I don't have any more external validation than my test
> though. If anyone has experience here, please let us know.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> ,
> or mute the thread
>
> .
>
","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,469871658
https://github.com/pydata/xarray/pull/3142#issuecomment-518342495,https://api.github.com/repos/pydata/xarray/issues/3142,518342495,MDEyOklzc3VlQ29tbWVudDUxODM0MjQ5NQ==,5635139,2019-08-05T18:17:12Z,2019-08-05T18:17:12Z,MEMBER,"What are people's thoughts on doing this now? There are a few big merges happening atm, so could do this after those.
I tested the approach [above](https://github.com/pydata/xarray/pull/3142#issuecomment-514325568) and it worked well. I don't have any more external validation than my test though. If anyone has experience here, please let us know.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,469871658
https://github.com/pydata/xarray/pull/3142#issuecomment-514325568,https://api.github.com/repos/pydata/xarray/issues/3142,514325568,MDEyOklzc3VlQ29tbWVudDUxNDMyNTU2OA==,5635139,2019-07-23T18:19:46Z,2019-07-23T18:19:46Z,MEMBER,"I think we can suggest something like this to existing PRs to eliminate manual conflicts, and I'm attempting to find something more official. Let me know if anyone knows of something:
- Merge master prior to the `black` commit (any conflicts are real conflicts and require resolving)
- Apply `black .` to this branch
- Merge master at the `black` commit, resolving in favor of our changes: `git merge [black-commit] -X ours`
- Merge current master (any conflicts here are real and again require resolving) ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,469871658
https://github.com/pydata/xarray/pull/3142#issuecomment-512970882,https://api.github.com/repos/pydata/xarray/issues/3142,512970882,MDEyOklzc3VlQ29tbWVudDUxMjk3MDg4Mg==,5635139,2019-07-18T20:16:27Z,2019-07-18T20:16:27Z,MEMBER,"FYI, unfortunately `pep8speaks` doesn't yet support black","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,469871658