html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3116#issuecomment-524342860,https://api.github.com/repos/pydata/xarray/issues/3116,524342860,MDEyOklzc3VlQ29tbWVudDUyNDM0Mjg2MA==,1197350,2019-08-23T14:45:13Z,2019-08-23T14:45:13Z,MEMBER,"I finally got the page to build and it looks great!
http://xarray.pydata.org/en/scipy19-docs/examples/ROMS_ocean_model.html
There was an issue with the ROMS MD5 checksum which I fixed in https://github.com/pydata/xarray-data/pull/17. The checksums .md5 files cannot have newlines at the end.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467768201
https://github.com/pydata/xarray/pull/3116#issuecomment-517650108,https://api.github.com/repos/pydata/xarray/issues/3116,517650108,MDEyOklzc3VlQ29tbWVudDUxNzY1MDEwOA==,1197350,2019-08-02T10:24:50Z,2019-08-23T14:44:01Z,MEMBER,"I am returning to this after some vacation. Thanks so much @hetland for this great example!
The test failures are not related to this PR. I see only three things that need to be done to get this ready to merge.
- [x] Add a short introductory paragraph at the very top of the notebook with some very general backgroud. Remember we have users from tons of different fields (e.g. finance, bioinformatics); they will have no idea what ROMS stands for or even what an ocean model is. We need a few sentences to introduce this example and explain what it shows (primarily how to visualize data that has irregular / derived coordinate geometry)
- [x] Remove or resolve the commented-out code in the example.
- [x] Add credit to @hetland in `whats-new.rst`
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467768201
https://github.com/pydata/xarray/pull/3116#issuecomment-522024714,https://api.github.com/repos/pydata/xarray/issues/3116,522024714,MDEyOklzc3VlQ29tbWVudDUyMjAyNDcxNA==,1197350,2019-08-16T14:16:22Z,2019-08-16T14:16:22Z,MEMBER,Thanks for this @hetland! I'm going to merge now!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467768201
https://github.com/pydata/xarray/pull/3116#issuecomment-511538753,https://api.github.com/repos/pydata/xarray/issues/3116,511538753,MDEyOklzc3VlQ29tbWVudDUxMTUzODc1Mw==,1197350,2019-07-15T19:33:14Z,2019-07-15T19:33:14Z,MEMBER,I just saw the new PR (#3134). You don't need to start a new PR unless something is truly broken here. You can just keep pushing to this one.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467768201
https://github.com/pydata/xarray/pull/3116#issuecomment-511536815,https://api.github.com/repos/pydata/xarray/issues/3116,511536815,MDEyOklzc3VlQ29tbWVudDUxMTUzNjgxNQ==,1197350,2019-07-15T19:26:58Z,2019-07-15T19:26:58Z,MEMBER,"You have to rebase your feature branch on the upstream/scipy19-docs branch in order to get #3121 to work locally.
```
git fetch upstream
git rebase upstream/scipy19-docs
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467768201
https://github.com/pydata/xarray/pull/3116#issuecomment-511536283,https://api.github.com/repos/pydata/xarray/issues/3116,511536283,MDEyOklzc3VlQ29tbWVudDUxMTUzNjI4Mw==,1197350,2019-07-15T19:25:22Z,2019-07-15T19:25:22Z,MEMBER,Can you post the error and stack trace?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467768201
https://github.com/pydata/xarray/pull/3116#issuecomment-511253099,https://api.github.com/repos/pydata/xarray/issues/3116,511253099,MDEyOklzc3VlQ29tbWVudDUxMTI1MzA5OQ==,1197350,2019-07-15T01:33:30Z,2019-07-15T01:33:30Z,MEMBER,"@hetland - thanks so much for this! Now that https://github.com/pydata/xarray-data/pull/13 has been merged, can you try to update your example to use the `xr.tutorial.open_dataset('ROMS_example.nc')` function?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,467768201