html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/issues/3092#issuecomment-511555108,https://api.github.com/repos/pydata/xarray/issues/3092,511555108,MDEyOklzc3VlQ29tbWVudDUxMTU1NTEwOA==,6213168,2019-07-15T20:22:28Z,2019-07-15T20:22:28Z,MEMBER,"I tried your setup.cfg above but still getting inconsistencies with black when I have comments in the imports. black: ```python import foo # Let me explain why we do this import bar ``` isort: ```python import foo # Let me explain why we do this import bar ``` and I strongly agree with black.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,466750687 https://github.com/pydata/xarray/issues/3092#issuecomment-511552648,https://api.github.com/repos/pydata/xarray/issues/3092,511552648,MDEyOklzc3VlQ29tbWVudDUxMTU1MjY0OA==,6213168,2019-07-15T20:15:28Z,2019-07-15T20:15:28Z,MEMBER,"I just ran isort on my own project. Overall, it gave me a bunch of good suggestions, but the amount of times I twitched my nose and manually reverted what it did are too many for my tastes. Besides the aforementioned incompatibilities with black, I hate when it changes ``` from .. import module1 from .. import module2 ``` to ``` from .. import module1, module2 ``` which in my opinion flies in the face of the PEP8 rule of never importing two modules on the same line. So my opinion is: +1 for a manually vetted one-time run; -1 for automatic integration in CI.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,466750687 https://github.com/pydata/xarray/issues/3092#issuecomment-511545508,https://api.github.com/repos/pydata/xarray/issues/3092,511545508,MDEyOklzc3VlQ29tbWVudDUxMTU0NTUwOA==,6213168,2019-07-15T19:54:30Z,2019-07-15T19:54:30Z,MEMBER,"flake8 is not just about formatting; none of the pyflakes errors (e.g. double/unused imports) are covered by black. I didn't know about isort, nice. However, from a very quick test, it's not compatible with black e.g. if you run black -> isort -> black, the two tools keep touching each other's changes.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,466750687