html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/3045#issuecomment-508025994,https://api.github.com/repos/pydata/xarray/issues/3045,508025994,MDEyOklzc3VlQ29tbWVudDUwODAyNTk5NA==,5635139,2019-07-03T09:53:54Z,2019-07-03T09:53:54Z,MEMBER,Thanks @jukent! We're happy to have you as a contributor!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460680578
https://github.com/pydata/xarray/pull/3045#issuecomment-507831204,https://api.github.com/repos/pydata/xarray/issues/3045,507831204,MDEyOklzc3VlQ29tbWVudDUwNzgzMTIwNA==,1217238,2019-07-02T20:25:02Z,2019-07-02T20:25:02Z,MEMBER,thanks @jukent !,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460680578
https://github.com/pydata/xarray/pull/3045#issuecomment-507791624,https://api.github.com/repos/pydata/xarray/issues/3045,507791624,MDEyOklzc3VlQ29tbWVudDUwNzc5MTYyNA==,1217238,2019-07-02T18:22:11Z,2019-07-02T18:22:11Z,MEMBER,pep8speaks has a few minor style complaints to fix: https://github.com/pydata/xarray/pull/3045#issuecomment-505651366,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460680578
https://github.com/pydata/xarray/pull/3045#issuecomment-507532924,https://api.github.com/repos/pydata/xarray/issues/3045,507532924,MDEyOklzc3VlQ29tbWVudDUwNzUzMjkyNA==,5635139,2019-07-02T06:07:56Z,2019-07-02T06:07:56Z,MEMBER,"The code looks great now, nice work @jukent - very succinct

If we can add that small test that @shoyer references (can do it in one of the existing test, just two lines), and potentially there's a [duplication](https://github.com/pydata/xarray/pull/3045/files#diff-99289912975ea19afc02f51c240ca451R111) in the whatsnew.

(I'm on vacation so don't wait for me to merge)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460680578
https://github.com/pydata/xarray/pull/3045#issuecomment-507487820,https://api.github.com/repos/pydata/xarray/issues/3045,507487820,MDEyOklzc3VlQ29tbWVudDUwNzQ4NzgyMA==,1217238,2019-07-02T01:59:11Z,2019-07-02T01:59:11Z,MEMBER,"Looking at the coverage report from codecov above, it looks like the lines where you raise `ValueError` for non-existent keys currently don't have any test coverage. Please add unit tests that verify the right error is raised, i.e., with `pytest.raises`.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460680578
https://github.com/pydata/xarray/pull/3045#issuecomment-507442274,https://api.github.com/repos/pydata/xarray/issues/3045,507442274,MDEyOklzc3VlQ29tbWVudDUwNzQ0MjI3NA==,2448579,2019-07-01T22:03:23Z,2019-07-01T22:03:23Z,MEMBER,"OK fixed whats-new. Sorry it gets a little confusing if there's been a release in the meantime.

This looks good to me. @max-sixty check once more and merge?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460680578
https://github.com/pydata/xarray/pull/3045#issuecomment-506055084,https://api.github.com/repos/pydata/xarray/issues/3045,506055084,MDEyOklzc3VlQ29tbWVudDUwNjA1NTA4NA==,1217238,2019-06-26T21:38:17Z,2019-06-26T21:38:17Z,MEMBER,"I would definitely  recommend reading through our contributor's guide on how to setup a local environment for testing your code: http://xarray.pydata.org/en/stable/contributing.html

It is  *much* easier to fix issues when you run tests locally rather than waiting on continuous integration tests (Travis-CI) to tell you that things are broken.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460680578
https://github.com/pydata/xarray/pull/3045#issuecomment-505998060,https://api.github.com/repos/pydata/xarray/issues/3045,505998060,MDEyOklzc3VlQ29tbWVudDUwNTk5ODA2MA==,5635139,2019-06-26T18:43:08Z,2019-06-26T18:43:08Z,MEMBER,FYI tests are failing with `E           NameError: name '_rename_var_dims_helper' is not defined`: https://travis-ci.org/pydata/xarray/jobs/550940568,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460680578
https://github.com/pydata/xarray/pull/3045#issuecomment-505980190,https://api.github.com/repos/pydata/xarray/issues/3045,505980190,MDEyOklzc3VlQ29tbWVudDUwNTk4MDE5MA==,2448579,2019-06-26T17:54:37Z,2019-06-26T17:54:37Z,MEMBER,@jukent You should also give yourself credit in `whats-new.rst` and add stuff to `api.rst`.  I also see that you're a first-time contributor. Welcome! We really appreciate your efforts.,"{""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460680578
https://github.com/pydata/xarray/pull/3045#issuecomment-505656004,https://api.github.com/repos/pydata/xarray/issues/3045,505656004,MDEyOklzc3VlQ29tbWVudDUwNTY1NjAwNA==,5635139,2019-06-25T23:12:36Z,2019-06-25T23:12:36Z,MEMBER,FYI the failure in appveyor is unrelated and can be ignored,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,460680578