html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2929#issuecomment-505148315,https://api.github.com/repos/pydata/xarray/issues/2929,505148315,MDEyOklzc3VlQ29tbWVudDUwNTE0ODMxNQ==,6213168,2019-06-24T19:32:36Z,2019-06-24T19:32:36Z,MEMBER,Sorry I didn't have time last week - I'll try merging into the pr ASAP. I'm in favour of merging to mainline too,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-502502167,https://api.github.com/repos/pydata/xarray/issues/2929,502502167,MDEyOklzc3VlQ29tbWVudDUwMjUwMjE2Nw==,6213168,2019-06-17T01:04:17Z,2019-06-17T01:04:17Z,MEMBER,@max-sixty you can keep adding type info to all functions in dataset.py. I don't think I'll have time to touch it next week anyway... ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-502465584,https://api.github.com/repos/pydata/xarray/issues/2929,502465584,MDEyOklzc3VlQ29tbWVudDUwMjQ2NTU4NA==,6213168,2019-06-16T16:15:57Z,2019-06-16T16:15:57Z,MEMBER,"@max-sixty I merged your branch in and did some tweaks to the OrderedDict's.
Now moving to add more typing info to dataset.py...","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-502397112,https://api.github.com/repos/pydata/xarray/issues/2929,502397112,MDEyOklzc3VlQ29tbWVudDUwMjM5NzExMg==,6213168,2019-06-15T20:27:54Z,2019-06-15T20:27:54Z,MEMBER,@max-sixty thanks for the work! I'll go through it ASAP,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-490325901,https://api.github.com/repos/pydata/xarray/issues/2929,490325901,MDEyOklzc3VlQ29tbWVudDQ5MDMyNTkwMQ==,6213168,2019-05-08T02:45:57Z,2019-05-08T02:45:57Z,MEMBER,"DataArray finished; unit tests (hopefully) successful. Will now move to Dataset.
Would appreciate an official, final decision from @shoyer et. al. on Hashable vs. str before I continue - also in light of all the hacks Hashable forced me to go through.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176
https://github.com/pydata/xarray/pull/2929#issuecomment-487671110,https://api.github.com/repos/pydata/xarray/issues/2929,487671110,MDEyOklzc3VlQ29tbWVudDQ4NzY3MTExMA==,6213168,2019-04-29T17:30:26Z,2019-04-29T17:30:26Z,MEMBER,"One of the many reasons why I'm strongly against generic Hashables instead of strings is that I expect user code all over the world to have string-specific functions and methods applied to variable names and dimensions.
e.g.
```
[d for d in arr.dims if d.startswith('foo')]
```
The above will produce an error in mypy, and the user will be forced to either disable the test or verbosely convince mypy with a ``typing.cast`` that actually in his project he never uses non-string dims.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,438421176