html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/2905#issuecomment-781406357,https://api.github.com/repos/pydata/xarray/issues/2905,781406357,MDEyOklzc3VlQ29tbWVudDc4MTQwNjM1Nw==,14808389,2021-02-18T15:04:02Z,2021-02-18T15:04:02Z,MEMBER,"thanks again, @blsqr","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,434502234 https://github.com/pydata/xarray/pull/2905#issuecomment-780909179,https://api.github.com/repos/pydata/xarray/issues/2905,780909179,MDEyOklzc3VlQ29tbWVudDc4MDkwOTE3OQ==,14808389,2021-02-17T22:56:29Z,2021-02-17T22:56:29Z,MEMBER,"@blsqr, I'm sorry for taking so long to review this. I updated your PR so this should be ready for merging. > I'm not sure that Variable is wrapping this CustomValues thing properly though. that turned out not to be true, we can't wrap it in a list because then `as_compatible_data` wouldn't be able to find `.values`. Instead, `Variable(dims=(), data=array)` (or converting it to a duckarray) is the way to go.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,434502234 https://github.com/pydata/xarray/pull/2905#issuecomment-560127829,https://api.github.com/repos/pydata/xarray/issues/2905,560127829,MDEyOklzc3VlQ29tbWVudDU2MDEyNzgyOQ==,2448579,2019-12-01T16:28:00Z,2019-12-01T16:28:00Z,MEMBER,I'm not sure that Variable is wrapping this CustomValues thing properly though. Someone else will need to chime in.,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,434502234 https://github.com/pydata/xarray/pull/2905#issuecomment-560127740,https://api.github.com/repos/pydata/xarray/issues/2905,560127740,MDEyOklzc3VlQ29tbWVudDU2MDEyNzc0MA==,2448579,2019-12-01T16:27:22Z,2019-12-01T16:27:22Z,MEMBER,We can ignore that for now. ,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,434502234 https://github.com/pydata/xarray/pull/2905#issuecomment-529125790,https://api.github.com/repos/pydata/xarray/issues/2905,529125790,MDEyOklzc3VlQ29tbWVudDUyOTEyNTc5MA==,2448579,2019-09-07T16:59:00Z,2019-09-07T16:59:00Z,MEMBER,"Thanks @blsqr. The tests are failing at this line: `orig = Variable(dims=('x'), data=array, attrs={'foo': 'bar'})` so your change isn't working yet. Can you fix it?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,434502234