html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/2782#issuecomment-473481213,https://api.github.com/repos/pydata/xarray/issues/2782,473481213,MDEyOklzc3VlQ29tbWVudDQ3MzQ4MTIxMw==,1217238,2019-03-16T00:36:12Z,2019-03-16T00:36:12Z,MEMBER,thanks @scottyhq !,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,412645481 https://github.com/pydata/xarray/pull/2782#issuecomment-469941846,https://api.github.com/repos/pydata/xarray/issues/2782,469941846,MDEyOklzc3VlQ29tbWVudDQ2OTk0MTg0Ng==,1217238,2019-03-06T02:27:49Z,2019-03-06T02:27:49Z,MEMBER,"I don't think it's essential to have an integration test doing real network access in xarray, so I would consider just dropping that part instead. On Tue, Mar 5, 2019 at 6:10 PM Ryan Abernathey wrote: > *@rabernat* commented on this pull request. > ------------------------------ > > In xarray/tests/test_backends.py > : > > > @@ -1955,6 +1955,39 @@ def test_dump_encodings_h5py(self): > assert actual.x.encoding['compression_opts'] is None > > > +@requires_h5fileobj > +class TestH5NetCDFFileObject(TestH5NetCDFData): > + h5py = pytest.importorskip('h5py', minversion='2.9.0') > + engine = 'h5netcdf' > + > + @network > + def test_h5remote(self): > + # alternative: http://era5-pds.s3.amazonaws.com/2008/01/main.nc > > > + import requests > + url = ('https://www.unidata.ucar.edu/' > + 'software/netcdf/examples/test_hgroups.nc') > > Rather than going over the network, it might be quite easy to fire up a > http.server.SimpleHTTPRequestHandler > > as part of a fixture. This would allow us to test the remote capability > without internet (and without depending on a third party to host a file.) > > — > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub > , > or mute the thread > > . > ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,412645481 https://github.com/pydata/xarray/pull/2782#issuecomment-466260533,https://api.github.com/repos/pydata/xarray/issues/2782,466260533,MDEyOklzc3VlQ29tbWVudDQ2NjI2MDUzMw==,1217238,2019-02-22T03:27:56Z,2019-02-22T03:27:56Z,MEMBER,"This looks great! I'll note one minor extension: you could look at the first few bytes of the file (the ""magic number"") to determine if it's a netCDF3 or netCDF4 file, and hence whether it can be opened with scipy or h5netcdf: - `CDF\001` or `CDF\002` would indicate [netCDF3](https://en.wikipedia.org/wiki/NetCDF) (use scipy) - `\211HDF\r\n\032\n` would indicate [netCDF4/HDF5](https://en.wikipedia.org/wiki/Hierarchical_Data_Format) (use h5netcdf) ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,412645481