html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2668#issuecomment-462303166,https://api.github.com/repos/pydata/xarray/issues/2668,462303166,MDEyOklzc3VlQ29tbWVudDQ2MjMwMzE2Ng==,6628425,2019-02-11T11:58:22Z,2019-02-11T11:58:22Z,MEMBER,Thanks for wrapping this up @fujiisoup!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,398468139
https://github.com/pydata/xarray/pull/2668#issuecomment-462268111,https://api.github.com/repos/pydata/xarray/issues/2668,462268111,MDEyOklzc3VlQ29tbWVudDQ2MjI2ODExMQ==,6815844,2019-02-11T09:47:24Z,2019-02-11T09:47:24Z,MEMBER,Thanks @spencerkclark for reviewing. Merged.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,398468139
https://github.com/pydata/xarray/pull/2668#issuecomment-462134943,https://api.github.com/repos/pydata/xarray/issues/2668,462134943,MDEyOklzc3VlQ29tbWVudDQ2MjEzNDk0Mw==,6628425,2019-02-10T13:55:55Z,2019-02-10T13:55:55Z,MEMBER,"> As I'm not a heavy user of `datetime` arrays, I personally do not mind if we do not have dask compatibility for `datetime_to_numeric`.
No worries @fujiisoup, this is totally fine with me. I think the most common use case for datetime arrays is in indexes, which currently need to be stored in memory anyway, so I don't think the dask use case would come up very often.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,398468139
https://github.com/pydata/xarray/pull/2668#issuecomment-462134112,https://api.github.com/repos/pydata/xarray/issues/2668,462134112,MDEyOklzc3VlQ29tbWVudDQ2MjEzNDExMg==,6815844,2019-02-10T13:44:54Z,2019-02-10T13:44:54Z,MEMBER,"@spencerkclark
Sorry for leaving it for a long time.
I was a little stressed these days...
> Should we strive to have compatibility in `datetime_to_numeric` there?
As I'm not a heavy user of `datetime` arrays, I personally do not mind if we do not have dask compatibility for `datetime_to_numeric`.
Probably it would be OK to leave it for the later development if someone wants this feature.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,398468139
https://github.com/pydata/xarray/pull/2668#issuecomment-454017544,https://api.github.com/repos/pydata/xarray/issues/2668,454017544,MDEyOklzc3VlQ29tbWVudDQ1NDAxNzU0NA==,6815844,2019-01-14T14:11:28Z,2019-01-14T14:11:28Z,MEMBER,"Thanks, @spencerkclark, for the PR.
It was super helpful.
I will finish it up tonight (hopefully).","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,398468139
https://github.com/pydata/xarray/pull/2668#issuecomment-453874778,https://api.github.com/repos/pydata/xarray/issues/2668,453874778,MDEyOklzc3VlQ29tbWVudDQ1Mzg3NDc3OA==,6628425,2019-01-13T23:14:00Z,2019-01-13T23:14:00Z,MEMBER,"> It looks I need more work for this (probably a week).
> It is not working for cftime stuffs, but I do not yet understand how it is handled in xarray.
Thanks @fujiisoup, no worries. There was only one place where I saw a potential issue for cftime dates, which I noted above. I made a PR to your branch with the fix (https://github.com/fujiisoup/xarray/pull/9); let me know if there were other places with issues and I can sort those out too.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,398468139
https://github.com/pydata/xarray/pull/2668#issuecomment-453867656,https://api.github.com/repos/pydata/xarray/issues/2668,453867656,MDEyOklzc3VlQ29tbWVudDQ1Mzg2NzY1Ng==,6815844,2019-01-13T21:35:07Z,2019-01-13T21:35:07Z,MEMBER,"Thanks, @spencerkclark
It looks I need more work for this (probably a week).
It is not working for cftime stuffs, but I do not yet understand how it is handled in xarray.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,398468139
https://github.com/pydata/xarray/pull/2668#issuecomment-453843848,https://api.github.com/repos/pydata/xarray/issues/2668,453843848,MDEyOklzc3VlQ29tbWVudDQ1Mzg0Mzg0OA==,1217238,2019-01-13T16:29:44Z,2019-01-13T16:29:44Z,MEMBER,"> I couldn't make `datetime_to_numeric` compatible both `np.ndarray` and `Variable`. I think it would be cleaner if `Variable` has a (private) method to do this, like `Variable._to_numeric(offset=None, datetime_unit=None)`.
Sounds good to me. It's definitely best to handle numpy arrays and xarray.Variable objects separately.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,398468139
https://github.com/pydata/xarray/pull/2668#issuecomment-453832982,https://api.github.com/repos/pydata/xarray/issues/2668,453832982,MDEyOklzc3VlQ29tbWVudDQ1MzgzMjk4Mg==,6815844,2019-01-13T14:10:32Z,2019-01-13T14:10:32Z,MEMBER,"I couldn't make `datetime_to_numeric` compatible both `np.ndarray` and `Variable`. I think it would be cleaner if `Variable` has a (private) method to do this, like `Variable._to_numeric(offset=None, datetime_unit=None)`.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,398468139
https://github.com/pydata/xarray/pull/2668#issuecomment-453680857,https://api.github.com/repos/pydata/xarray/issues/2668,453680857,MDEyOklzc3VlQ29tbWVudDQ1MzY4MDg1Nw==,1217238,2019-01-11T22:44:32Z,2019-01-11T22:44:32Z,MEMBER,"(at least for now, until we can figure out how to handle missing values)
On Fri, Jan 11, 2019 at 2:44 PM Stephan Hoyer wrote:
> OK, in that case let's only worry about NaT for datetime64/timedelta64
> arrays.
>
> On Fri, Jan 11, 2019 at 2:37 PM Spencer Clark
> wrote:
>
>> what convention do you use for missing values in cftime arrays?
>>
>> Currently there is nothing built in to xarray to support missing values
>> for cftime arrays. I think we would have to come up with a convention.
>>
>> —
>> You are receiving this because you commented.
>> Reply to this email directly, view it on GitHub
>> , or mute
>> the thread
>>
>> .
>>
>
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,398468139
https://github.com/pydata/xarray/pull/2668#issuecomment-453680807,https://api.github.com/repos/pydata/xarray/issues/2668,453680807,MDEyOklzc3VlQ29tbWVudDQ1MzY4MDgwNw==,1217238,2019-01-11T22:44:18Z,2019-01-11T22:44:18Z,MEMBER,"OK, in that case let's only worry about NaT for datetime64/timedelta64
arrays.
On Fri, Jan 11, 2019 at 2:37 PM Spencer Clark
wrote:
> what convention do you use for missing values in cftime arrays?
>
> Currently there is nothing built in to xarray to support missing values
> for cftime arrays. I think we would have to come up with a convention.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> , or mute
> the thread
>
> .
>
","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,398468139
https://github.com/pydata/xarray/pull/2668#issuecomment-453679270,https://api.github.com/repos/pydata/xarray/issues/2668,453679270,MDEyOklzc3VlQ29tbWVudDQ1MzY3OTI3MA==,6628425,2019-01-11T22:37:06Z,2019-01-11T22:37:06Z,MEMBER,"> what convention do you use for missing values in cftime arrays?
Currently there is nothing built in to xarray to support missing values for cftime arrays. I think we would have to come up with a convention.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,398468139
https://github.com/pydata/xarray/pull/2668#issuecomment-453675862,https://api.github.com/repos/pydata/xarray/issues/2668,453675862,MDEyOklzc3VlQ29tbWVudDQ1MzY3NTg2Mg==,1217238,2019-01-11T22:21:45Z,2019-01-11T22:21:45Z,MEMBER,@spencerkclark what convention do you use for missing values in cftime arrays?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,398468139