html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2652#issuecomment-633652366,https://api.github.com/repos/pydata/xarray/issues/2652,633652366,MDEyOklzc3VlQ29tbWVudDYzMzY1MjM2Ng==,5635139,2020-05-25T16:57:28Z,2020-05-25T16:57:28Z,MEMBER,@hrishikeshac in case you come back to see this: thank you for taking it so far; your code was helpful to eventually getting this feature in. And we'd of course appreciate any additional contributions. ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,396102183
https://github.com/pydata/xarray/pull/2652#issuecomment-556046073,https://api.github.com/repos/pydata/xarray/issues/2652,556046073,MDEyOklzc3VlQ29tbWVudDU1NjA0NjA3Mw==,5635139,2019-11-20T15:11:27Z,2019-11-20T15:11:27Z,MEMBER,@r-beer great—you were right to start your own PR,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,396102183
https://github.com/pydata/xarray/pull/2652#issuecomment-555756460,https://api.github.com/repos/pydata/xarray/issues/2652,555756460,MDEyOklzc3VlQ29tbWVudDU1NTc1NjQ2MA==,5635139,2019-11-19T23:02:37Z,2019-11-19T23:02:37Z,MEMBER,"Yeah those are pretty normal. Your suggestions look right: you can keep both on both sets and eliminate any duplicate imports in the first,
(FYI I edited your comment so it displayed properly, seems you need a line break after ``)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,396102183
https://github.com/pydata/xarray/pull/2652#issuecomment-555738102,https://api.github.com/repos/pydata/xarray/issues/2652,555738102,MDEyOklzc3VlQ29tbWVudDU1NTczODEwMg==,5635139,2019-11-19T22:06:49Z,2019-11-19T22:06:49Z,MEMBER,Yes 100%! Let me know if that doesn't work!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,396102183
https://github.com/pydata/xarray/pull/2652#issuecomment-555733366,https://api.github.com/repos/pydata/xarray/issues/2652,555733366,MDEyOklzc3VlQ29tbWVudDU1NTczMzM2Ng==,5635139,2019-11-19T21:54:26Z,2019-11-19T21:54:26Z,MEMBER,"Great @r-beer , we can be helpful in getting you up & running
Given this branch has diverged from master, I would make your own fork and merge in master; looks like you'll have some minor conflicts. (more details in our contributing.rst docs, or post here if confused). You can then open up your own draft PR.
Re the tests: pytest should print a list of the tests that failed and their stack traces, do you not see anything?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,396102183
https://github.com/pydata/xarray/pull/2652#issuecomment-452014148,https://api.github.com/repos/pydata/xarray/issues/2652,452014148,MDEyOklzc3VlQ29tbWVudDQ1MjAxNDE0OA==,1217238,2019-01-07T17:29:45Z,2019-01-07T17:29:45Z,MEMBER,"I agree that the case for DataArray.dot is questionable. It sort of makes
sense because numpy and pandas both have it as a method, but the @ operator
is a really a cleaner way to express this now that we're Python 3 only.
(Speaking of which, why don't we support @ in xarray yet? :).)
On Mon, Jan 7, 2019 at 1:43 AM Keisuke Fujii
wrote:
> @max-sixty
> I am not sure whether DataArray.dot is a right choice. But I am wondering
> for cov case, it sounds like to compute a covariance of the DataArray
> itself rather than the cross covariance with another DataArray.
>
> —
> You are receiving this because you commented.
> Reply to this email directly, view it on GitHub
> , or mute
> the thread
>
> .
>
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,396102183
https://github.com/pydata/xarray/pull/2652#issuecomment-451877705,https://api.github.com/repos/pydata/xarray/issues/2652,451877705,MDEyOklzc3VlQ29tbWVudDQ1MTg3NzcwNQ==,6815844,2019-01-07T09:43:17Z,2019-01-07T09:43:17Z,MEMBER,"@max-sixty
I am not sure whether `DataArray.dot` is a right choice. But I am wondering for `cov` case, it sounds like to compute a covariance of the DataArray itself rather than the cross covariance with another DataArray.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,396102183
https://github.com/pydata/xarray/pull/2652#issuecomment-451840629,https://api.github.com/repos/pydata/xarray/issues/2652,451840629,MDEyOklzc3VlQ29tbWVudDQ1MTg0MDYyOQ==,5635139,2019-01-07T07:04:46Z,2019-01-07T07:04:46Z,MEMBER,"> Probably a function like xr.cov(x, y) is better than method?
We should be more concerned with correctness than consistency - but is having `DataArray.dot` consistent with `DataArray.cov`? If not, what's the salient difference?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,396102183
https://github.com/pydata/xarray/pull/2652#issuecomment-451703221,https://api.github.com/repos/pydata/xarray/issues/2652,451703221,MDEyOklzc3VlQ29tbWVudDQ1MTcwMzIyMQ==,1217238,2019-01-06T00:05:49Z,2019-01-06T00:05:49Z,MEMBER,"I also think making this a function is probably a good idea, even though it's different from pandas.
One question: how should these functions align their arguments? Recall that xarray does an `inner` join for arithmetic (though there's an option to control this), and an `outer` join in most other cases. It's not entirely obvious to me what the right choice is here (or if it really even matters).","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,396102183
https://github.com/pydata/xarray/pull/2652#issuecomment-451661466,https://api.github.com/repos/pydata/xarray/issues/2652,451661466,MDEyOklzc3VlQ29tbWVudDQ1MTY2MTQ2Ng==,2448579,2019-01-05T14:44:28Z,2019-01-05T14:44:28Z,MEMBER,I agree with @fujisoup,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,396102183
https://github.com/pydata/xarray/pull/2652#issuecomment-451658613,https://api.github.com/repos/pydata/xarray/issues/2652,451658613,MDEyOklzc3VlQ29tbWVudDQ1MTY1ODYxMw==,6815844,2019-01-05T14:07:30Z,2019-01-05T14:07:30Z,MEMBER,"I am a little worrying that users could misunderstand `cov` is for (auto-)covariance rather than cross-covariance, which we are implementing here.
Probably a function like `xr.cov(x, y)` is better than method?
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,396102183