html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/2650#issuecomment-505057218,https://api.github.com/repos/pydata/xarray/issues/2650,505057218,MDEyOklzc3VlQ29tbWVudDUwNTA1NzIxOA==,1217238,2019-06-24T15:20:38Z,2019-06-24T15:20:38Z,MEMBER,"OK, in it goes. Thanks @max-sixty !","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,396084551 https://github.com/pydata/xarray/pull/2650#issuecomment-453923654,https://api.github.com/repos/pydata/xarray/issues/2650,453923654,MDEyOklzc3VlQ29tbWVudDQ1MzkyMzY1NA==,1217238,2019-01-14T07:58:26Z,2019-01-14T07:58:26Z,MEMBER,"> Does anyone have a view on the canonical way to implement these for Dataset, given potentially only a subset of the variables will have the dimension? > Tests fail when naively using `apply_ufunc`; `.reduce` looks like it has some functionality for skipping those variables. Or I could do it manually in a couple of lines. You could probably copy the logic from `Dataset.reduce`, which simply applies different logic for coordinates (they either get preserved or dropped depending on if they reuse the reduced dimension). That said, if EWM preserves the dimension size/labels you probably don't nee any special logic for coordinates -- see `DatasetRolling.reduce` as well.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,396084551 https://github.com/pydata/xarray/pull/2650#issuecomment-453843812,https://api.github.com/repos/pydata/xarray/issues/2650,453843812,MDEyOklzc3VlQ29tbWVudDQ1Mzg0MzgxMg==,1217238,2019-01-13T16:29:16Z,2019-01-13T16:29:16Z,MEMBER,"see https://github.com/pydata/xarray/pull/2669 for the tests issue On Sun, Jan 13, 2019 at 6:12 PM Maximilian Roos wrote: > Tests seem to be failing on a different issue? > https://travis-ci.org/pydata/xarray/jobs/479042667#L7759 > > — > You are receiving this because you commented. > > Reply to this email directly, view it on GitHub > , or mute > the thread > > . > ","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,396084551 https://github.com/pydata/xarray/pull/2650#issuecomment-452187740,https://api.github.com/repos/pydata/xarray/issues/2650,452187740,MDEyOklzc3VlQ29tbWVudDQ1MjE4Nzc0MA==,1217238,2019-01-08T06:15:09Z,2019-01-08T06:15:09Z,MEMBER,"I would lean towards a dedicated method, since there are method specific options. It's pretty awkward to reuse a single interface for that.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,396084551 https://github.com/pydata/xarray/pull/2650#issuecomment-451730029,https://api.github.com/repos/pydata/xarray/issues/2650,451730029,MDEyOklzc3VlQ29tbWVudDQ1MTczMDAyOQ==,1217238,2019-01-06T10:11:43Z,2019-01-06T10:11:43Z,MEMBER,"Before we add even an optional dependency on numbagg in xarray, we should probably do a bit of cleanup (e.g., making sure we're happy with its public interface, and putting a release up on pypi)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,396084551 https://github.com/pydata/xarray/pull/2650#issuecomment-451729769,https://api.github.com/repos/pydata/xarray/issues/2650,451729769,MDEyOklzc3VlQ29tbWVudDQ1MTcyOTc2OQ==,1217238,2019-01-06T10:06:40Z,2019-01-06T10:06:40Z,MEMBER,"I know the name `ewm` matches pandas, but I find it rather inscrutable if you don't already know the acronym. What about something a little longer, maybe `exp_rolling()`?","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,396084551