html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/2618#issuecomment-487003189,https://api.github.com/repos/pydata/xarray/issues/2618,487003189,MDEyOklzc3VlQ29tbWVudDQ4NzAwMzE4OQ==,10050469,2019-04-26T10:02:26Z,2019-04-26T10:02:26Z,MEMBER,"I'm sorry this has stalled now - I think this is a nice addition. @jsignell : would you have time to finish this up? ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,392361367 https://github.com/pydata/xarray/pull/2618#issuecomment-449067569,https://api.github.com/repos/pydata/xarray/issues/2618,449067569,MDEyOklzc3VlQ29tbWVudDQ0OTA2NzU2OQ==,10050469,2018-12-20T17:04:30Z,2018-12-20T17:04:30Z,MEMBER,"> Do we really want a np.masked_array or do we just want an array with np.Nans in it? I prefer nans, but I guess the downside is type conversion for ints? Masked arrays come with huge performance drops, I don't think we should use these.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,392361367 https://github.com/pydata/xarray/pull/2618#issuecomment-448542055,https://api.github.com/repos/pydata/xarray/issues/2618,448542055,MDEyOklzc3VlQ29tbWVudDQ0ODU0MjA1NQ==,10050469,2018-12-19T10:15:33Z,2018-12-19T10:15:33Z,MEMBER,"I wonder if `nodatavals` is the only attribute for masking - in the doc (https://rasterio.readthedocs.io/en/latest/topics/masks.html) they also mention `nodata`, which in my experience is also used","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,392361367