html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2616#issuecomment-505516435,https://api.github.com/repos/pydata/xarray/issues/2616,505516435,MDEyOklzc3VlQ29tbWVudDUwNTUxNjQzNQ==,35968931,2019-06-25T16:16:46Z,2019-06-25T16:16:46Z,MEMBER,"@shoyer I like that suggestion a lot - not sure why we didn't think of something similar before.

How does it work if I push to a merged PR?","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,391865060
https://github.com/pydata/xarray/pull/2616#issuecomment-505505734,https://api.github.com/repos/pydata/xarray/issues/2616,505505734,MDEyOklzc3VlQ29tbWVudDUwNTUwNTczNA==,35968931,2019-06-25T15:49:55Z,2019-06-25T15:49:55Z,MEMBER,:tada: Thanks for your help! ,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,391865060
https://github.com/pydata/xarray/pull/2616#issuecomment-504468333,https://api.github.com/repos/pydata/xarray/issues/2616,504468333,MDEyOklzc3VlQ29tbWVudDUwNDQ2ODMzMw==,35968931,2019-06-21T15:29:41Z,2019-06-21T15:29:41Z,MEMBER,"Okay I've changed those things. @shoyer if you want to just double check that the new error catching behaviour in `dimension_coords_exist()` is what you wanted, then this should be good to go! ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,391865060
https://github.com/pydata/xarray/pull/2616#issuecomment-496536455,https://api.github.com/repos/pydata/xarray/issues/2616,496536455,MDEyOklzc3VlQ29tbWVudDQ5NjUzNjQ1NQ==,35968931,2019-05-28T14:17:39Z,2019-05-28T14:17:39Z,MEMBER,"Thanks for the detailed review @shoyer !

> I'm loving all the documentation and test coverage here (though I haven't read them all carefully yet!).

Great - the only test I think you should definitely look at is `test_manual_concat_too_many_dims_at_once`, and my diagnosis of the issue it exposes in #2975.

","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,391865060
https://github.com/pydata/xarray/pull/2616#issuecomment-494100381,https://api.github.com/repos/pydata/xarray/issues/2616,494100381,MDEyOklzc3VlQ29tbWVudDQ5NDEwMDM4MQ==,35968931,2019-05-20T18:29:48Z,2019-05-20T18:29:48Z,MEMBER,"Thanks for the review - I've fixed those mistakes, and added a note explaining why there are 3 similar-sounding functions.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,391865060
https://github.com/pydata/xarray/pull/2616#issuecomment-493957592,https://api.github.com/repos/pydata/xarray/issues/2616,493957592,MDEyOklzc3VlQ29tbWVudDQ5Mzk1NzU5Mg==,35968931,2019-05-20T12:02:26Z,2019-05-20T12:02:26Z,MEMBER,"Ah yes that worked, thanks @dcherian !

I think this PR is finally complete - ready to merge @shoyer?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,391865060
https://github.com/pydata/xarray/pull/2616#issuecomment-493796718,https://api.github.com/repos/pydata/xarray/issues/2616,493796718,MDEyOklzc3VlQ29tbWVudDQ5Mzc5NjcxOA==,35968931,2019-05-19T22:17:56Z,2019-05-19T22:17:56Z,MEMBER,"@dcherian I added another section to the https://xarray.pydata.org/en/stable/combining.html docs page to explain what the new functions do.

One thing - this deprecation cycle means that for now warnings get thrown basically however you use `auto_combine`. The test suites are generating a lot of these warnings - is there a way to get pytest to ignore specific warnings for specific tests or is it okay leaving it?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,391865060
https://github.com/pydata/xarray/pull/2616#issuecomment-481899529,https://api.github.com/repos/pydata/xarray/issues/2616,481899529,MDEyOklzc3VlQ29tbWVudDQ4MTg5OTUyOQ==,35968931,2019-04-10T23:03:13Z,2019-04-10T23:03:13Z,MEMBER,"@dcherian the relevant docstrings have been significantly altered, including giving some examples.

However I haven't changed any of the main documentation pages, I guess I should look through to see if this will change any of the syntax in any of those examples.

Or are you suggesting there should be a new section of the documentation explaining what the difference between `combine_manual` and `combine_auto` is?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,391865060
https://github.com/pydata/xarray/pull/2616#issuecomment-474262793,https://api.github.com/repos/pydata/xarray/issues/2616,474262793,MDEyOklzc3VlQ29tbWVudDQ3NDI2Mjc5Mw==,35968931,2019-03-19T09:26:18Z,2019-03-19T09:26:18Z,MEMBER,@shoyer I think this is ready for a final review.,"{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,391865060
https://github.com/pydata/xarray/pull/2616#issuecomment-470939071,https://api.github.com/repos/pydata/xarray/issues/2616,470939071,MDEyOklzc3VlQ29tbWVudDQ3MDkzOTA3MQ==,35968931,2019-03-08T14:04:37Z,2019-03-08T14:04:37Z,MEMBER,"> We can deprecate the old auto_combine but keep it around for now to enable a smooth transition.

This might be a little bit confusing until the deprecation cycle is complete, but it will allow us to complete the cycle in only one edition, rather than two (one to introduce `combine_manual`, and one to change the behaviour of `auto_combine`). It also means that users who want to eventually use the ""coordinate-ordering"" behaviour will only have to change their code once.

I'll do it this way.

","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,391865060
https://github.com/pydata/xarray/pull/2616#issuecomment-469089587,https://api.github.com/repos/pydata/xarray/issues/2616,469089587,MDEyOklzc3VlQ29tbWVudDQ2OTA4OTU4Nw==,35968931,2019-03-04T01:34:25Z,2019-03-04T01:34:25Z,MEMBER,"I think that `manual_combine` and `auto_combine` (or `combine_auto` etc.) are pretty suitable. 

Any variation on `concat` is a little misleading because these functions will also `merge`. Anything with `nested` or `multi` is kind of superfluous when the idea of the library is sort of that multi-dimensional operations are as easy as single-dimensional operations. 

`combine` (dictionary definition: to join or merge to form a single unit or substance) does accurate describe what the functions do.

If we use `combine_auto` and `combine_manual` then it simplifies the deprecation cycle because we can have the old `auto_combine` and the new `combine_auto` in the API simultaneously (though maybe that's too confusing).","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,391865060
https://github.com/pydata/xarray/pull/2616#issuecomment-469019590,https://api.github.com/repos/pydata/xarray/issues/2616,469019590,MDEyOklzc3VlQ29tbWVudDQ2OTAxOTU5MA==,35968931,2019-03-03T12:46:08Z,2019-03-03T12:46:08Z,MEMBER,"Okay @shoyer so the way I've gone about this deprecation problem is to essentially introduce `manual_combine` whilst reverting `auto_combine`. That means that `auto_combine` isn't a breaking change yet, but it's inputs are checked and if they will break in future it throws a warning saying ""please use `manual_combine` instead because the behaviour of `auto_combine` will soon change"".

This way we don't have two publicly-accessible versions of `auto_combine` present simultaneously, and if users heed the warnings and switch to using `manual_combine` then their code won't break when we later update `auto_combine` from the old to the new behaviour.

This approach means there currently isn't a way to opt-in to the new `auto_combine` behaviour early, but as you can opt-in to future-compatible behaviour by using `manual_combine` instead, then I think that's fine?

","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,391865060
https://github.com/pydata/xarray/pull/2616#issuecomment-451786609,https://api.github.com/repos/pydata/xarray/issues/2616,451786609,MDEyOklzc3VlQ29tbWVudDQ1MTc4NjYwOQ==,35968931,2019-01-06T23:43:57Z,2019-01-07T01:09:53Z,MEMBER,"Okay so this is mostly done - I've completely rearranged the tests and they pass on my unmerged branch, there are just a few TODOs left.

~~However, when I tried to merge master in then everything failed again due to #2648, I don't understand what `ReprObject` does?~~ (Fixed with bfch4e3)

Some other questions: 

1) We didn't decide whether the ability to infer concatenation dimensions (i.e. when `concat_dim='_CONCAT_DIM_DEFAULT'`) should be retained or not. I'm not sure we need it at all any more - you're either using `auto_combine`, which will concatenate dimension coordinates and leave other dimensions alone, or you're using `manual_combine`, in which you're supposed to explicitly state all the dimensions you wish to concatenate along anyway. I think this is also related to a bug I don't properly understand (marked with an xfail in `test_manual_concat_too_many_dims_at_once`).

2) Ordering the datasets along one dimension according to the values in their dimension coordinates (done in `_infer_order_1d`) turned out to be a bit more complicated than I thought. Is the method using a `Pandas.Series` okay? Do we want to use natural sorting on strings? How should I deal with `datetime` objects? I also think it's probably easier to check that the coords can actually be arranged to be monotonic after all the concatenation has been done, not before.

3) Some input which previously wouldn't be valid now is (see the TODO in line 538 of `test_combine.py`), is that the desired behaviour in that case?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,391865060