html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/2616#issuecomment-505517099,https://api.github.com/repos/pydata/xarray/issues/2616,505517099,MDEyOklzc3VlQ29tbWVudDUwNTUxNzA5OQ==,1217238,2019-06-25T16:18:29Z,2019-06-25T16:18:29Z,MEMBER,Pushing to a merged PR definitely doesn't work :). You should start a new branch after syncing master.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,391865060 https://github.com/pydata/xarray/pull/2616#issuecomment-505514716,https://api.github.com/repos/pydata/xarray/issues/2616,505514716,MDEyOklzc3VlQ29tbWVudDUwNTUxNDcxNg==,1217238,2019-06-25T16:12:03Z,2019-06-25T16:12:03Z,MEMBER,"I started thinking about names for these functions again.... I don't love the non-descriptive nature of `combine_auto` and `combine_manual`. All ""auto"" and ""manual"" tells me is that one is more automatic than the other, without saying *how* it's more automatic. This is probably even more confusing because we used ""auto"" previously to mean some hybrid behavior between what we now call ""manual"" and ""auto"". What about calling these `combine_by_coords` and `combine_nested` instead? On `open_mfdataset`, these would be `combine='by_coords'` and `combine='nested'`.","{""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,391865060 https://github.com/pydata/xarray/pull/2616#issuecomment-505490600,https://api.github.com/repos/pydata/xarray/issues/2616,505490600,MDEyOklzc3VlQ29tbWVudDUwNTQ5MDYwMA==,1217238,2019-06-25T15:14:54Z,2019-06-25T15:14:54Z,MEMBER,"OK, in it goes! Thanks @TomNicholas for your perseverance here","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,391865060 https://github.com/pydata/xarray/pull/2616#issuecomment-503199369,https://api.github.com/repos/pydata/xarray/issues/2616,503199369,MDEyOklzc3VlQ29tbWVudDUwMzE5OTM2OQ==,1217238,2019-06-18T15:56:42Z,2019-06-18T15:56:42Z,MEMBER,"I left a couple of minor comments, but I think this is pretty much ready to go! We should merge this and let users give it a try :).","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,391865060 https://github.com/pydata/xarray/pull/2616#issuecomment-470260814,https://api.github.com/repos/pydata/xarray/issues/2616,470260814,MDEyOklzc3VlQ29tbWVudDQ3MDI2MDgxNA==,1217238,2019-03-06T20:19:32Z,2019-03-06T20:19:32Z,MEMBER,"> If we use combine_auto and combine_manual then it simplifies the deprecation cycle because we can have the old auto_combine and the new combine_auto in the API simultaneously (though maybe that's too confusing). I think this is a good idea. We can deprecate the old auto_combine but keep it around for now to enable a smooth transition.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,391865060 https://github.com/pydata/xarray/pull/2616#issuecomment-469086121,https://api.github.com/repos/pydata/xarray/issues/2616,469086121,MDEyOklzc3VlQ29tbWVudDQ2OTA4NjEyMQ==,1217238,2019-03-04T01:04:39Z,2019-03-04T01:04:39Z,MEMBER,"Do we want to stick with the names `manual_combine` and `auto_combine`? Some other possibilities: - Instead of `manual_combine`: `concat_nd`, `concat_nested`, `multi_concat` - Instead of `auto_combine`:`assemble`, `reassemble`, `combine_sorted`, `concat_sorted`, `unify` I guess `auto`/`manual` works well with the values of the keyword argument, and makes it clear that these are a different class of operation than the primitive `concat` and `merge`. Though if we really want to emphasize the similarity (especially to help auto-complete), we might consider even switching the order of the words, e.g., `combine_auto` and `combine_manual`.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,391865060