html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/2590#issuecomment-446666682,https://api.github.com/repos/pydata/xarray/issues/2590,446666682,MDEyOklzc3VlQ29tbWVudDQ0NjY2NjY4Mg==,1217238,2018-12-12T17:11:45Z,2018-12-12T17:11:45Z,MEMBER,"Thank @MBlaschek -- we appreciate your help here! It does get easier for next time, I promise :)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,387673324 https://github.com/pydata/xarray/pull/2590#issuecomment-446663592,https://api.github.com/repos/pydata/xarray/issues/2590,446663592,MDEyOklzc3VlQ29tbWVudDQ0NjY2MzU5Mg==,2448579,2018-12-12T17:03:05Z,2018-12-12T17:03:05Z,MEMBER,"Thanks, @MBlaschek. Looks great to me.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,387673324 https://github.com/pydata/xarray/pull/2590#issuecomment-444562863,https://api.github.com/repos/pydata/xarray/issues/2590,444562863,MDEyOklzc3VlQ29tbWVudDQ0NDU2Mjg2Mw==,2448579,2018-12-05T17:04:43Z,2018-12-05T17:07:30Z,MEMBER,"Thanks @MBlaschek. 1. You'll need to also add a note to `doc/whats-new.rst`. 2. Looks like there's trailing whitespace in `test_variable.py` that will need to be fixed. EDIT: Looks like the tests aren't running because of this ImportError ``` ImportError while importing test module '/home/travis/build/pydata/xarray/xarray/tests/test_variable.py'. Hint: make sure your test modules/packages have valid Python names. Traceback: xarray/tests/test_variable.py:27: in from . import ( E ImportError: cannot import name 'set_options' ``` I think you need `from xarray import set_options` as in `test_dataset.py`. You can test this out locally using pytest. We have some documentation on contributing here: http://xarray.pydata.org/en/stable/contributing.html. Feel free to ask if you have questions","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,387673324