html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/issues/2582#issuecomment-443786550,https://api.github.com/repos/pydata/xarray/issues/2582,443786550,MDEyOklzc3VlQ29tbWVudDQ0Mzc4NjU1MA==,2448579,2018-12-03T17:04:24Z,2018-12-03T17:04:24Z,MEMBER,"Hi @MBlaschek, almost there! You'll need to open your pull request in this repository :).

You'll also need to add some tests to make sure your changes keep working as the code is updated in the future. E.g. https://github.com/pydata/xarray/blob/0d6056e8816e3d367a64f36c7f1a5c4e1ce4ed4e/xarray/tests/test_variable.py#L1533","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,385716625
https://github.com/pydata/xarray/issues/2582#issuecomment-443286361,https://api.github.com/repos/pydata/xarray/issues/2582,443286361,MDEyOklzc3VlQ29tbWVudDQ0MzI4NjM2MQ==,2448579,2018-11-30T17:57:47Z,2018-11-30T17:57:47Z,MEMBER,"@MBlaschek This might help: https://help.github.com/articles/proposing-changes-to-your-work-with-pull-requests/ . You'd start by creating a fork, then a branch with your changes, push your changes to github and then initiate a pull request.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,385716625
https://github.com/pydata/xarray/issues/2582#issuecomment-443285132,https://api.github.com/repos/pydata/xarray/issues/2582,443285132,MDEyOklzc3VlQ29tbWVudDQ0MzI4NTEzMg==,5635139,2018-11-30T17:53:48Z,2018-11-30T17:53:48Z,MEMBER,"> Not sure what a PR is. (Sorry I'm not that advanced in coding)

PR is a pull-request! If you can open a PR with your code, we can merge it to the repo. Would be greatly appreciated from xarray, and you'd be an xarray contributor. Let us know if we can help guide you through the mechanics.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,385716625
https://github.com/pydata/xarray/issues/2582#issuecomment-442975920,https://api.github.com/repos/pydata/xarray/issues/2582,442975920,MDEyOklzc3VlQ29tbWVudDQ0Mjk3NTkyMA==,1217238,2018-11-29T20:09:29Z,2018-11-29T20:09:29Z,MEMBER,"Thanks for the report! It looks like we definitely overlooked this in arithmetic operations. I agree that `keep_attrs=True` should mean that attributes are maintained in arithmetic.

Any interest in putting together a PR? 
- https://github.com/pydata/xarray/pull/2482 has lots of examples of how to implement the option.
- https://github.com/pydata/xarray/blob/0d6056e8816e3d367a64f36c7f1a5c4e1ce4ed4e/xarray/core/variable.py#L1665 is where we forget to keep attributes in binary operations.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,385716625