html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/2559#issuecomment-444333050,https://api.github.com/repos/pydata/xarray/issues/2559,444333050,MDEyOklzc3VlQ29tbWVudDQ0NDMzMzA1MA==,1197350,2018-12-05T02:15:48Z,2018-12-05T02:15:48Z,MEMBER,"If anyone wants to see how awesome consolidated metadata is, you can try it in this binder:
https://github.com/rabernat/pangeo_ecco_examples/

I did a bit of lazy profiling here:
https://gist.github.com/rabernat/ce1fb414cf53541afe2245363b06c49d

Things that used to take ~40s now take ~1s. Especially since loading the data is one of the first steps in any pangeo notebook, this is a *huge* improvement in usability.

Thanks to everyone who helped make it happen!","{""total_count"": 2, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 1, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,382497709
https://github.com/pydata/xarray/pull/2559#issuecomment-444303363,https://api.github.com/repos/pydata/xarray/issues/2559,444303363,MDEyOklzc3VlQ29tbWVudDQ0NDMwMzM2Mw==,1197350,2018-12-04T23:47:06Z,2018-12-04T23:47:06Z,MEMBER,"👍

Sent from my iPhone

> On Dec 4, 2018, at 6:37 PM, Stephan Hoyer <notifications@github.com> wrote:
> 
> @rabernat if you're ready, let's merge this.
> 
> The failures on Appveyor are related (an issue with int32 and cftime)
> 
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub, or mute the thread.
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,382497709
https://github.com/pydata/xarray/pull/2559#issuecomment-444219121,https://api.github.com/repos/pydata/xarray/issues/2559,444219121,MDEyOklzc3VlQ29tbWVudDQ0NDIxOTEyMQ==,1197350,2018-12-04T19:06:16Z,2018-12-04T19:06:16Z,MEMBER,"> We may also need some text around updating consolidated data-sets, but that can maybe wait to see what kind of usage people try.

Since xarray cannot append or modify in-place existing zarr stores, this seems outside the scope of xarray for now. But maybe it is worth mentioning in the docs.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,382497709
https://github.com/pydata/xarray/pull/2559#issuecomment-443304443,https://api.github.com/repos/pydata/xarray/issues/2559,443304443,MDEyOklzc3VlQ29tbWVudDQ0MzMwNDQ0Mw==,1197350,2018-11-30T18:59:06Z,2018-11-30T18:59:06Z,MEMBER,"Keywords are now all `consolidated` and all tests are go.

Ready to merge?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,382497709
https://github.com/pydata/xarray/pull/2559#issuecomment-442580875,https://api.github.com/repos/pydata/xarray/issues/2559,442580875,MDEyOklzc3VlQ29tbWVudDQ0MjU4MDg3NQ==,1197350,2018-11-28T19:49:02Z,2018-11-28T19:49:02Z,MEMBER,"> Will the default for both options be `False` for the time being?

Yes","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,382497709
https://github.com/pydata/xarray/pull/2559#issuecomment-442575389,https://api.github.com/repos/pydata/xarray/issues/2559,442575389,MDEyOklzc3VlQ29tbWVudDQ0MjU3NTM4OQ==,1197350,2018-11-28T19:33:01Z,2018-11-28T19:33:01Z,MEMBER,"So if the test issues can be considered resolved, the only decision we need to make is about the API.

Do we prefer (the current way):
```python
ds.to_zarr(fname, consolidate=True)
xr.open_zarr(fname, consolidated=True)
```

or @shoyer's suggestion
```python
ds.to_zarr(fname, consolidated=True)
xr.open_zarr(fname, consolidated=True)
```
???","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,382497709
https://github.com/pydata/xarray/pull/2559#issuecomment-442557300,https://api.github.com/repos/pydata/xarray/issues/2559,442557300,MDEyOklzc3VlQ29tbWVudDQ0MjU1NzMwMA==,1197350,2018-11-28T18:38:23Z,2018-11-28T18:38:23Z,MEMBER,"Not sure I understand why there are tests failing now. The failing function is `test_basic_compute`. 

https://travis-ci.org/pydata/xarray/jobs/460873430#L7489

At first glance, this does not appear to have anything to do with my PR. The relevant error is:
```

______________________________ test_basic_compute ______________________________
    def test_basic_compute():
        ds = Dataset({'foo': ('x', range(5)),
                      'bar': ('x', range(5))}).chunk({'x': 2})
        for get in [dask.threaded.get,
                    dask.multiprocessing.get,
                    dask.local.get_sync,
                    None]:
            with (dask.config.set(scheduler=get)
                  if LooseVersion(dask.__version__) >= LooseVersion('0.19.4')
                  else dask.config.set(scheduler=get)
                  if LooseVersion(dask.__version__) >= LooseVersion('0.18.0')
                  else dask.set_options(get=get)):
>               ds.compute()
xarray/tests/test_dask.py:843: 
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
xarray/core/dataset.py:597: in compute
    return new.load(**kwargs)
xarray/core/dataset.py:494: in load
    evaluated_data = da.compute(*lazy_data.values(), **kwargs)
../../../miniconda/envs/test_env/lib/python3.6/site-packages/dask/base.py:390: in compute
    collections=collections)
../../../miniconda/envs/test_env/lib/python3.6/site-packages/dask/base.py:865: in get_scheduler
    return get_scheduler(scheduler=config.get('scheduler', None))
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 
get = None, scheduler = <function get at 0x7fc31d9ae048>, collections = None
cls = None
    def get_scheduler(get=None, scheduler=None, collections=None, cls=None):
        """""" Get scheduler function
    
        There are various ways to specify the scheduler to use:
    
        1.  Passing in get= parameters (deprecated)
        2.  Passing in scheduler= parameters
        3.  Passing these into global confiuration
        4.  Using defaults of a dask collection
    
        This function centralizes the logic to determine the right scheduler to use
        from those many options
        """"""
        if get is not None:
            if scheduler is not None:
                raise ValueError(""Both get= and scheduler= provided.  Choose one"")
            warn_on_get(get)
            return get
    
        if scheduler is not None:
>           if scheduler.lower() in named_schedulers:
E           AttributeError: 'function' object has no attribute 'lower'
../../../miniconda/envs/test_env/lib/python3.6/site-packages/dask/base.py:854: AttributeError
```
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,382497709
https://github.com/pydata/xarray/pull/2559#issuecomment-440285690,https://api.github.com/repos/pydata/xarray/issues/2559,440285690,MDEyOklzc3VlQ29tbWVudDQ0MDI4NTY5MA==,1197350,2018-11-20T14:09:16Z,2018-11-20T14:09:16Z,MEMBER,Also need to add some version checks...this will only work with zarr > 2.2.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,382497709
https://github.com/pydata/xarray/pull/2559#issuecomment-440136005,https://api.github.com/repos/pydata/xarray/issues/2559,440136005,MDEyOklzc3VlQ29tbWVudDQ0MDEzNjAwNQ==,1197350,2018-11-20T04:42:33Z,2018-11-20T04:42:33Z,MEMBER,Ping @lilyminium for a review.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,382497709