html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/pull/2107#issuecomment-394406007,https://api.github.com/repos/pydata/xarray/issues/2107,394406007,MDEyOklzc3VlQ29tbWVudDM5NDQwNjAwNw==,1217238,2018-06-04T15:54:51Z,2018-06-04T15:54:51Z,MEMBER,thanks @yohai!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674 https://github.com/pydata/xarray/pull/2107#issuecomment-394060337,https://api.github.com/repos/pydata/xarray/issues/2107,394060337,MDEyOklzc3VlQ29tbWVudDM5NDA2MDMzNw==,1217238,2018-06-02T05:33:27Z,2018-06-02T05:33:27Z,MEMBER,"It looks like the merge went OK, but you have a couple of tests that are failing. Click on the ""Travis-CI"" link above next to the red ""X"" to see details: https://travis-ci.org/pydata/xarray/jobs/386973465","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674 https://github.com/pydata/xarray/pull/2107#issuecomment-394040124,https://api.github.com/repos/pydata/xarray/issues/2107,394040124,MDEyOklzc3VlQ29tbWVudDM5NDA0MDEyNA==,1217238,2018-06-02T00:12:59Z,2018-06-02T00:12:59Z,MEMBER,"> Thanks @shoyer. I fixed everything except for the coverall part, which is weird. The lines it marks as untested are the function _line_facetgrid, which the main function that performs all of the testing. I suspect that it simply doesn't run my new tests for some reason. When I run pytest locally these lines do get tested (I verified by adding print commands there). Should I add decorators like pytest.mark.somethingfor coverall to notice these tests? The specific problematic lines are those marked red in coveralls, e.g., https://coveralls.io/builds/17253745/source?filename=xarray%2Fplot%2Fplot.py#L101 https://coveralls.io/builds/17253745/source?filename=xarray%2Fplot%2Fplot.py#L176 https://coveralls.io/builds/17253745/source?filename=xarray%2Fplot%2Fplot.py#L291 These are all cases where an error is raised.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674 https://github.com/pydata/xarray/pull/2107#issuecomment-386927718,https://api.github.com/repos/pydata/xarray/issues/2107,386927718,MDEyOklzc3VlQ29tbWVudDM4NjkyNzcxOA==,1217238,2018-05-07T00:15:20Z,2018-05-07T00:15:20Z,MEMBER,"I'm really excited about this! Could you kindly paste in examples of what the generated plots look like in your comment? (GitHub will upload an image when you paste it in.)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,320632674