html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1837#issuecomment-366479069,https://api.github.com/repos/pydata/xarray/issues/1837,366479069,MDEyOklzc3VlQ29tbWVudDM2NjQ3OTA2OQ==,1217238,2018-02-17T23:24:30Z,2018-02-17T23:24:30Z,MEMBER,"My final concern is about the name for these methods. Currently, you have two separate method names, `to_dataset` and `to_dataarray()`. These names are very descriptive, but unfortunately they are different for DataArray and Dataset, which means that users will need to write different code for different xarray types. I would slightly rather that we had a single method name that could be used for both, perhaps `construct()` or `build()`. Then you could write code like `xarray_obj.rolling(time=100).construct(rolling_dim='window')` without needing to know whether `xarray_obj` is a Dataset or DataArray.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,289556132
https://github.com/pydata/xarray/pull/1837#issuecomment-361664085,https://api.github.com/repos/pydata/xarray/issues/1837,361664085,MDEyOklzc3VlQ29tbWVudDM2MTY2NDA4NQ==,1217238,2018-01-30T17:10:44Z,2018-01-30T17:10:44Z,MEMBER,"I'll take a look, but I'm open to only fixing this nansum for numpy 1.13+
(or even requiring numpy 1.13 for rolling window arrays), as long as we
don't break existing behavior on earlier versions of numpy.

On Tue, Jan 30, 2018 at 3:16 AM Keisuke Fujii <notifications@github.com>
wrote:

> Hmm...
> The support of nansum for object-dtype is much more difficult than I
> expected.
>
> Now, I am stacked in supporting numpy<1.13.
> With numpy<1.13, nansum for the object type gives just a nan.
>
> nansum scripts defined in numpy==1.13 does not help because != operator
> used here
> <https://github.com/numpy/numpy/blob/6914bb41f0fb3c1ba500bae4e7d671da9536786f/numpy/lib/nanfunctions.py#L68>
> behaves differently in numpy<1.13.
>
> I think our best choice is to revert this PR to 4189d71
> <https://github.com/pydata/xarray/commit/4189d71d9998ff83deb9a5d7035a2edaf628ae25>
> and left this issue to #1866
> <https://github.com/pydata/xarray/issues/1866>.
>
> —
> You are receiving this because you commented.
>
> Reply to this email directly, view it on GitHub
> <https://github.com/pydata/xarray/pull/1837#issuecomment-361562466>, or mute
> the thread
> <https://github.com/notifications/unsubscribe-auth/ABKS1gBOXSErdmYDEYBql46Pl6DEm7uTks5tPvoTgaJpZM4Rim9O>
> .
>
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,289556132
https://github.com/pydata/xarray/pull/1837#issuecomment-359228984,https://api.github.com/repos/pydata/xarray/issues/1837,359228984,MDEyOklzc3VlQ29tbWVudDM1OTIyODk4NA==,1217238,2018-01-21T07:15:29Z,2018-01-21T07:15:29Z,MEMBER,"Would it make sense to add a `stride` argument to `to_dataarray`? You can always index afterwards, but that could be a nice shortcut. It will be much faster for dask, certainly. (We can also add this later if desired)","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,289556132