html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1817#issuecomment-360072572,https://api.github.com/repos/pydata/xarray/issues/1817,360072572,MDEyOklzc3VlQ29tbWVudDM2MDA3MjU3Mg==,10050469,2018-01-24T09:33:07Z,2018-01-24T09:33:07Z,MEMBER,"@rabernat no problem, will go back the rasterio tests soon ","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,287569331
https://github.com/pydata/xarray/pull/1817#issuecomment-359892573,https://api.github.com/repos/pydata/xarray/issues/1817,359892573,MDEyOklzc3VlQ29tbWVudDM1OTg5MjU3Mw==,1197350,2018-01-23T18:54:24Z,2018-01-23T18:54:24Z,MEMBER,@fmaussion - so sorry I accidentally deleted your tests. I was just rushing to resolve the conflicts so as not to hold up the other PRs. I hope this does not cause too much inconvenience.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,287569331
https://github.com/pydata/xarray/pull/1817#issuecomment-359849232,https://api.github.com/repos/pydata/xarray/issues/1817,359849232,MDEyOklzc3VlQ29tbWVudDM1OTg0OTIzMg==,1217238,2018-01-23T16:33:46Z,2018-01-23T16:33:46Z,MEMBER,This looks good so let's get it in!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,287569331
https://github.com/pydata/xarray/pull/1817#issuecomment-359848928,https://api.github.com/repos/pydata/xarray/issues/1817,359848928,MDEyOklzc3VlQ29tbWVudDM1OTg0ODkyOA==,1217238,2018-01-23T16:32:56Z,2018-01-23T16:32:56Z,MEMBER,@rabernat @fmaussion it's fine to merge your own PR once it's been reviewed & approved by another core developer.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,287569331
https://github.com/pydata/xarray/pull/1817#issuecomment-359827458,https://api.github.com/repos/pydata/xarray/issues/1817,359827458,MDEyOklzc3VlQ29tbWVudDM1OTgyNzQ1OA==,10050469,2018-01-23T15:32:15Z,2018-01-23T15:32:15Z,MEMBER,"test_nodata and test_nodata_missing are tests which were added in https://github.com/pydata/xarray/pull/1740, they shouldn't be deleted by your PR. It's fine if you don't refactorize them (I'll need to have a look at all the tests anyway once all conflicting PRs are merged, see https://github.com/pydata/xarray/issues/1843)","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,287569331
https://github.com/pydata/xarray/pull/1817#issuecomment-359814915,https://api.github.com/repos/pydata/xarray/issues/1817,359814915,MDEyOklzc3VlQ29tbWVudDM1OTgxNDkxNQ==,1197350,2018-01-23T14:54:07Z,2018-01-23T14:54:07Z,MEMBER,"I resolved conflicts. LGTM before it gets stale again!

Is it bad form to merge my own PR?","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,287569331
https://github.com/pydata/xarray/pull/1817#issuecomment-358707269,https://api.github.com/repos/pydata/xarray/issues/1817,358707269,MDEyOklzc3VlQ29tbWVudDM1ODcwNzI2OQ==,1217238,2018-01-18T16:47:50Z,2018-01-18T16:47:50Z,MEMBER,@rabernat this now has some conflicts to resolve. Can you fix those and merge this? Thanks!,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,287569331
https://github.com/pydata/xarray/pull/1817#issuecomment-357457030,https://api.github.com/repos/pydata/xarray/issues/1817,357457030,MDEyOklzc3VlQ29tbWVudDM1NzQ1NzAzMA==,10050469,2018-01-13T18:44:37Z,2018-01-13T18:44:37Z,MEMBER,"https://github.com/pydata/xarray/pull/1740 is OK since the tests are still missing. My PR is a bit more problematic, but I can handle it. I would favor pushing yours forward now and I'll rebase my PR on top of it.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,287569331
https://github.com/pydata/xarray/pull/1817#issuecomment-357456847,https://api.github.com/repos/pydata/xarray/issues/1817,357456847,MDEyOklzc3VlQ29tbWVudDM1NzQ1Njg0Nw==,1197350,2018-01-13T18:41:46Z,2018-01-13T18:41:46Z,MEMBER,"> this will mess with #1712 and #1740 quite a bit

I probably should have paid more attention to those PR's. My apologies.

Here is how I ended up refactoring the tests. I had to write a new test to catch the bug I discovered. I looked at the existing tests for guidance and saw lots of boilerplate. So rather than copying the boilerplate, I refactored it.

Let me know how I can help resolve this conflicts this may cause with the other open PRs. 
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,287569331
https://github.com/pydata/xarray/pull/1817#issuecomment-357450408,https://api.github.com/repos/pydata/xarray/issues/1817,357450408,MDEyOklzc3VlQ29tbWVudDM1NzQ1MDQwOA==,1197350,2018-01-13T17:08:50Z,2018-01-13T17:08:50Z,MEMBER,"I also refactored the rasterio test suite to eliminate a lot of boilerplate dataset creation and added tests for network urls. I'm not a geotiff expert, so please let me know if I have done anything silly.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,287569331
https://github.com/pydata/xarray/pull/1817#issuecomment-356799541,https://api.github.com/repos/pydata/xarray/issues/1817,356799541,MDEyOklzc3VlQ29tbWVudDM1Njc5OTU0MQ==,1217238,2018-01-11T01:56:53Z,2018-01-11T01:57:05Z,MEMBER,"You can test this by mocking `os.path.getmtime`, e.g.,
```python
from unittest import mock  # but note that we use a special import for mock in xarray

with mock.patch('os.path.getmtime', side_effect=RuntimeError):
    os.path.getmtime('fooasdf.txt')
```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,287569331