html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/issues/1813#issuecomment-356387489,https://api.github.com/repos/pydata/xarray/issues/1813,356387489,MDEyOklzc3VlQ29tbWVudDM1NjM4NzQ4OQ==,1217238,2018-01-09T19:25:05Z,2018-01-09T19:25:05Z,MEMBER,I think it was likely a work-around for some strange behavior in `issubdtype` -- likely exactly what was fixed on the numpy side by https://github.com/numpy/numpy/pull/9505.,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,287186057 https://github.com/pydata/xarray/issues/1813#issuecomment-356383197,https://api.github.com/repos/pydata/xarray/issues/1813,356383197,MDEyOklzc3VlQ29tbWVudDM1NjM4MzE5Nw==,2443309,2018-01-09T19:08:59Z,2018-01-09T19:08:59Z,MEMBER,"You're right. That's it. Do you know what the check for np.generic is trying to do here: https://github.com/pydata/xarray/blob/ab0db05a58fd47fe895d1a85c09c37d96263d3b7/xarray/plot/plot.py#L36-L43 All the tests seem to pass with: ```Python def _valid_other_type(x, types): """""" Do all elements of x have a type from types? """""" return all(any(isinstance(el, t) for t in types) for el in np.ravel(x)) ```","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,287186057 https://github.com/pydata/xarray/issues/1813#issuecomment-356380557,https://api.github.com/repos/pydata/xarray/issues/1813,356380557,MDEyOklzc3VlQ29tbWVudDM1NjM4MDU1Nw==,1217238,2018-01-09T18:59:35Z,2018-01-09T18:59:35Z,MEMBER,"NumPy 1.14 just came out, it might be related to that.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,287186057