html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue https://github.com/pydata/xarray/issues/1755#issuecomment-348716669,https://api.github.com/repos/pydata/xarray/issues/1755,348716669,MDEyOklzc3VlQ29tbWVudDM0ODcxNjY2OQ==,1217238,2017-12-02T20:09:17Z,2017-12-02T20:09:17Z,MEMBER,"> How about deprecating these? Would that be too much of a change you think? (I never use them) Yes, this is a good idea! Opened #1756 to keep track.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,278453914 https://github.com/pydata/xarray/issues/1755#issuecomment-348554537,https://api.github.com/repos/pydata/xarray/issues/1755,348554537,MDEyOklzc3VlQ29tbWVudDM0ODU1NDUzNw==,1217238,2017-12-01T17:19:53Z,2017-12-01T17:19:53Z,MEMBER,"If I did it again, I would remove the `inplace` keyword argument from even Dataset methods. Almost every method in xarray creates new underlying objects, so it's misleading to call them ""inplace"". (Most of our inplace methods actually create a new object and then assign its properties to an existing object.) Why not make your accessor method return a new DataArray object? That would be more inline with how most xarray methods work. If you have any special attributes you've set on the accessor you can copy those over to the new result.","{""total_count"": 2, ""+1"": 2, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,278453914