html_url,issue_url,id,node_id,user,created_at,updated_at,author_association,body,reactions,performed_via_github_app,issue
https://github.com/pydata/xarray/pull/1750#issuecomment-352518249,https://api.github.com/repos/pydata/xarray/issues/1750,352518249,MDEyOklzc3VlQ29tbWVudDM1MjUxODI0OQ==,1217238,2017-12-18T18:34:51Z,2017-12-18T18:34:51Z,MEMBER,@duncanwp that example looks good to me. I assume it runs locally with this branch?,"{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,278286073
https://github.com/pydata/xarray/pull/1750#issuecomment-352480739,https://api.github.com/repos/pydata/xarray/issues/1750,352480739,MDEyOklzc3VlQ29tbWVudDM1MjQ4MDczOQ==,1217238,2017-12-18T16:35:06Z,2017-12-18T16:35:06Z,MEMBER,"https://github.com/dask/dask/issues/2977 needs to be resolved to make it possible to properly translate dask arrays back and forth between xarray/Iris.
I don't want to hold up this PR which is coming along very nicely (and I'm sure would already be useful), so we can we simply differ handling of dask arrays for now? I would suggest raising `NotImplementedError` and printing an error message with a link to a follow-up issue in xarray's issue tracker.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,278286073
https://github.com/pydata/xarray/pull/1750#issuecomment-350033913,https://api.github.com/repos/pydata/xarray/issues/1750,350033913,MDEyOklzc3VlQ29tbWVudDM1MDAzMzkxMw==,1217238,2017-12-07T17:13:49Z,2017-12-07T17:13:49Z,MEMBER,"I don't know exactly what would go wrong, but I'm pretty sure masked Dask
arrays would break xarray in some subtle ways. It would be better to
convert them to using unmasked Dask arrays using NaN.
On Thu, Dec 7, 2017 at 1:18 AM Duncan Watson-Parris <
notifications@github.com> wrote:
> *@duncanwp* commented on this pull request.
> ------------------------------
>
> In xarray/convert.py
> :
>
> > @@ -181,7 +183,9 @@ def from_iris(cube):
> cell_methods = _iris_cell_methods_to_str(cube.cell_methods)
> if cell_methods:
> array_attrs['cell_methods'] = cell_methods
> - dataarray = DataArray(cube.data, coords=coords, name=name,
> +
> + cube_data = ma.filled(cube.core_data(), get_fill_value(cube.dtype)) if hasattr(cube, 'core_data') else cube.data
>
> OK, I hadn't appreciated that dask wasn't a hard requirement. I could
> leave them as whatever type they're currently stored in - how would xarray
> cope with a dask masked array?
>
> —
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> , or mute
> the thread
>
> .
>
","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,278286073
https://github.com/pydata/xarray/pull/1750#issuecomment-348559234,https://api.github.com/repos/pydata/xarray/issues/1750,348559234,MDEyOklzc3VlQ29tbWVudDM0ODU1OTIzNA==,1217238,2017-12-01T17:38:42Z,2017-12-01T17:38:42Z,MEMBER,"> I think it's OK in I/O (for now). This is also the place where we document serialization in pickle, and the from_dict methods.
Agreed. In the long term, the IO docs have gotten pretty long, it could make sense to split them up into several subpages.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,278286073
https://github.com/pydata/xarray/pull/1750#issuecomment-348489979,https://api.github.com/repos/pydata/xarray/issues/1750,348489979,MDEyOklzc3VlQ29tbWVudDM0ODQ4OTk3OQ==,10050469,2017-12-01T13:05:59Z,2017-12-01T13:05:59Z,MEMBER,"> Do you have a feel for if/where else this should be documented? I'm not sure if really fits in I/O...
I think it's OK in I/O (for now). This is also the place where we document serialization in pickle, and the `from_dict` methods.","{""total_count"": 0, ""+1"": 0, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,278286073
https://github.com/pydata/xarray/pull/1750#issuecomment-348387554,https://api.github.com/repos/pydata/xarray/issues/1750,348387554,MDEyOklzc3VlQ29tbWVudDM0ODM4NzU1NA==,1217238,2017-12-01T02:55:41Z,2017-12-01T02:55:41Z,MEMBER,"@pelson any thoughts here?
I think this may be a reasonable place to start, though it is certainly not leveraging Iris's full metadata decoding capabilities.
It would also be nice to pass dask arrays back and forth, but that will probably need to wait until after Iris 2.0 and https://github.com/pydata/xarray/issues/1372 is solved.","{""total_count"": 1, ""+1"": 1, ""-1"": 0, ""laugh"": 0, ""hooray"": 0, ""confused"": 0, ""heart"": 0, ""rocket"": 0, ""eyes"": 0}",,278286073